import { tmpdir } from 'node:os'; import { join } from 'node:path'; import { afterEach, describe, expect, it } from 'vitest'; import { generateKeyPairSync } from 'node:crypto'; import { mkdtemp, writeFile, rm } from 'node:fs/promises'; import type { Actor, Release } from '@wishforge/contracts'; import { verifyRunnerTask, type SignedRunnerTask } from '@wishforge/runtime'; import { MemoryStore } from './helpers/memory-store.js'; import { deliverable } from './helpers/delivery.js'; import { ControlPlane } from '../apps/api/src/domain/control-plane.js'; import { Connections } from '../apps/api/src/domain/connections.js'; import { Releases } from '../apps/api/src/domain/releases.js'; import { RunnerBroker } from '../apps/api/src/domain/runner-broker.js'; import { applicationUrlFor, assertApplicationConfigured } from '../apps/api/src/domain/application-access.js'; const owner: Actor = { tenantId: 'alpha', userId: 'owner', role: 'owner', kind: 'human' }, deployer: Actor = { ...owner, userId: 'deployer', kind: 'deployer' }; const dirs: string[] = []; afterEach(async () => { for (const dir of dirs.splice(0)) await rm(dir, { recursive: true, force: true }); }); async function fixture() { const db = new MemoryStore(); db.seed('alpha'); const temp = await mkdtemp(join(tmpdir(), 'wishforge-access-')); dirs.push(temp); await writeFile( `${temp}/key.pem`, generateKeyPairSync('ed25519').privateKey.export({ type: 'pkcs8', format: 'pem' }), ); const env = { NODE_ENV: 'test', WF_VAULT_KEY: 'a'.repeat(64), WF_RUNNER_SIGNING_KEY_FILE: `${temp}/key.pem` }; const control = new ControlPlane(db, env), releases = new Releases(db, env), broker = new RunnerBroker(db, releases, env); const project = await control.createProject(owner, { name: 'Application', repositoryUrl: 'https://example.test/repo.git', verificationCommands: [['node', '--test']], }); await db.transaction('alpha', tx => tx.put('project', { ...project, deliveryConfig: { containerPort: 3000, healthPath: '/health', smokeChecks: [{ path: '/catalog', expectedStatus: 200 }], }, }), ); await new Connections(db, env).create(owner, { provider: 'codex', label: 'fixture', apiKey: 'not-a-real-key' }); const { run_id: id } = await control.submit( owner, project.id, { goal: 'Deliver a catalog', acceptanceCriteria: ['Catalog contains records'] }, 'url-fixture-submit', ); const { verification, build } = await deliverable(control, 'alpha', id, { image: `registry.example/web@sha256:${'b'.repeat(64)}`, }); const environment = await releases.createEnvironment(owner, { projectId: project.id, name: 'URL fixture', type: 'compose', applicationUrl: 'https://app.example.test/catalog', }); const input = { runId: id, environmentId: environment.id, verificationEvidenceId: verification.id, buildEvidenceId: build.id, }; return { db, env, control, releases, broker, project, environment, id, input }; } const access = (url: string) => ({ applicationUrl: url, stableOrigin: new URL(url).origin, checkedAt: new Date().toISOString(), checks: ['application-url', 'public-access'], }); describe('immutable release delivery URL and access evidence', () => { it('requires human owner/admin configuration and rejects invalid URLs', async () => { const f = await fixture(); const environment = await f.releases.createEnvironment(owner, { projectId: f.project.id, name: 'Without URL', type: 'compose', }); expect(environment.applicationUrl).toBeUndefined(); await expect( f.releases.createEnvironment( { ...owner, kind: 'connector' }, { projectId: f.project.id, name: 'Forbidden', type: 'compose' }, ), ).rejects.toMatchObject({ code: 'HUMAN_APPROVAL_REQUIRED' }); await expect( f.releases.updateApplicationUrl({ ...owner, role: 'developer' }, environment.id, { applicationUrl: 'https://app.example.test/', }), ).rejects.toMatchObject({ code: 'FORBIDDEN' }); await expect( f.releases.updateApplicationUrl(owner, environment.id, { applicationUrl: 'https://service.ns.svc/' }), ).rejects.toMatchObject({ code: 'APPLICATION_URL_INVALID' }); }); it('rejects application URLs on console and API authentication origins', () => { for (const key of ['WF_PUBLIC_URL', 'WF_API_PUBLIC_URL']) expect(() => applicationUrlFor( { applicationUrl: 'https://shared.example.test/app', production: true }, { [key]: 'https://shared.example.test/console' }, ), ).toThrow('separate'); }); it('requires an explicit URL in production', () => { expect(() => assertApplicationConfigured({}, { NODE_ENV: 'production' })).toThrow('explicit application URL'); expect(() => assertApplicationConfigured({}, { NODE_ENV: 'development' })).not.toThrow(); }); it('binds the application URL into approval and rejects a changed or removed URL', async () => { for (const change of [{ applicationUrl: 'https://next.example.test/' }, { applicationUrl: null }]) { const f = await fixture(); const release = await f.releases.request(owner, f.input, 'binding-url-release'); expect(release).toMatchObject({ applicationUrl: f.environment.applicationUrl, deliveryRequired: true }); await f.releases.updateApplicationUrl(owner, f.environment.id, change); await expect( f.releases.decide(owner, release.approvalId!, { decision: 'approve', bindingDigest: release.bindingDigest }), ).rejects.toMatchObject({ code: 'RELEASE_STALE' }); } }); it('signature covers the URL and a healthy receipt without an access check cannot deliver', async () => { const f = await fixture(); const release = await f.releases.request(owner, f.input, 'signed-url-release'); await f.releases.decide(owner, release.approvalId!, { decision: 'approve', bindingDigest: release.bindingDigest }); const registration = await f.broker.register(owner, f.environment.id); const runner = { ...deployer, userId: `runner:${f.environment.id}`, clientId: registration.id }; const envelope = (await f.broker.poll(runner, f.environment.id))!; const scope = { tenantId: 'alpha', environmentId: f.environment.id, publicKeys: registration.publicKeys }; expect(verifyRunnerTask(envelope as SignedRunnerTask, scope).release.applicationUrl).toBe( f.environment.applicationUrl, ); const tampered = structuredClone(envelope); tampered.payload.release.applicationUrl = 'https://attacker.example.test/'; expect(() => verifyRunnerTask(tampered as SignedRunnerTask, scope)).toThrow('signature'); const result = { releaseId: release.id, status: 'verified', target: 'compose', evidence: { identityMatched: true, trafficSwitched: true, checks: ['health', 'business-smoke'] }, }; expect(await f.broker.result(runner, envelope.payload.id, { result })).toMatchObject({ delivered: false }); expect(await f.db.transaction('alpha', tx => tx.get('release', release.id))).not.toHaveProperty('deliveryUrl'); }); it('records and returns only the exact application URL after matching access acceptance', async () => { const f = await fixture(); const release = await f.releases.request(owner, f.input, 'accepted-url-release'); await f.releases.decide(owner, release.approvalId!, { decision: 'approve', bindingDigest: release.bindingDigest }); const registration = await f.broker.register(owner, f.environment.id); const runner = { ...deployer, userId: `runner:${f.environment.id}`, clientId: registration.id }; const envelope = (await f.broker.poll(runner, f.environment.id))!; await expect( f.releases.updateApplicationUrl(owner, f.environment.id, { applicationUrl: null }), ).rejects.toMatchObject({ code: 'ENVIRONMENT_CONFLICT' }); const result = { releaseId: release.id, status: 'verified', target: 'compose', evidence: { identityMatched: true, trafficSwitched: true, checks: ['health', 'business-smoke'], accessEvidence: access(f.environment.applicationUrl!), }, }; expect(await f.broker.result(runner, envelope.payload.id, { result })).toMatchObject({ delivered: true, url: f.environment.applicationUrl, }); const saved = await f.db.transaction('alpha', tx => tx.get('release', release.id)); expect(saved).toMatchObject({ status: 'healthy', deliveryUrl: f.environment.applicationUrl }); expect(await f.releases.delivery(owner, f.id)).toMatchObject({ url: f.environment.applicationUrl, accepted: true }); await f.releases.updateApplicationUrl(owner, f.environment.id, { applicationUrl: null }); expect(await f.releases.delivery(owner, f.id)).not.toHaveProperty('url'); expect((await f.releases.list(owner))[0]).not.toHaveProperty('deliveryUrl'); }); it('binds operator secret policy into approval and the signed Runner manifest', async () => { const f = await fixture(), policy = `sha256:${'c'.repeat(64)}`; await expect( f.releases.updateDeploymentSecrets(owner, f.environment.id, { secretVersionRefs: ['database@version-7'], deploymentSecretPolicyDigest: null, }), ).rejects.toMatchObject({ code: 'DEPLOYMENT_SECRET_POLICY_REQUIRED' }); await f.releases.updateDeploymentSecrets(owner, f.environment.id, { secretVersionRefs: ['database@version-7'], deploymentSecretPolicyDigest: policy, }); const release = await f.releases.request(owner, f.input, 'secret-policy-signed'); expect(release).toMatchObject({ secretVersionRefs: ['database@version-7'], deploymentSecretPolicyDigest: policy }); await f.releases.decide(owner, release.approvalId!, { decision: 'approve', bindingDigest: release.bindingDigest }); const registration = await f.broker.register(owner, f.environment.id), runner = { ...deployer, userId: `runner:${f.environment.id}`, clientId: registration.id }; const envelope = (await f.broker.poll(runner, f.environment.id))!; expect(envelope.payload.release.deploymentSecretPolicyDigest).toBe(policy); await expect( f.releases.updateDeploymentSecrets(owner, f.environment.id, { secretVersionRefs: [], deploymentSecretPolicyDigest: null, }), ).rejects.toMatchObject({ code: 'ENVIRONMENT_CONFLICT' }); }); it('only human Owner/Admin may update references and changed policy invalidates old approval', async () => { const f = await fixture(), policy = `sha256:${'c'.repeat(64)}`; await expect( f.releases.updateDeploymentSecrets({ ...owner, kind: 'connector' }, f.environment.id, { secretVersionRefs: [], deploymentSecretPolicyDigest: null, }), ).rejects.toMatchObject({ code: 'HUMAN_APPROVAL_REQUIRED' }); await expect( f.releases.updateDeploymentSecrets({ ...owner, role: 'developer' }, f.environment.id, { secretVersionRefs: [], deploymentSecretPolicyDigest: null, }), ).rejects.toMatchObject({ code: 'FORBIDDEN' }); await f.releases.updateDeploymentSecrets(owner, f.environment.id, { secretVersionRefs: ['database@version-7'], deploymentSecretPolicyDigest: policy, }); const release = await f.releases.request(owner, f.input, 'secret-policy-change'); await f.releases.updateDeploymentSecrets(owner, f.environment.id, { secretVersionRefs: ['database@version-7'], deploymentSecretPolicyDigest: `sha256:${'d'.repeat(64)}`, }); await expect( f.releases.decide(owner, release.approvalId!, { decision: 'approve', bindingDigest: release.bindingDigest }), ).rejects.toMatchObject({ code: 'RELEASE_STALE' }); const cleared = await f.releases.updateDeploymentSecrets(owner, f.environment.id, { secretVersionRefs: [], deploymentSecretPolicyDigest: null, }); expect(cleared.secretVersionRefs).toEqual([]); expect(cleared.deploymentSecretPolicyDigest).toBeUndefined(); }); });