Adds prettier 3.9.8 (exact) with a shared config (single quotes, 120 columns, trailing commas), .prettierignore, .editorconfig and the `format` / `format:check` scripts, then formats all TypeScript, JavaScript, CSS, JSON and YAML sources. Purely mechanical: no behaviour change. Typecheck passes, the vitest suite and the 74 IDE node tests produce the same results as before (socket-binding tests still cannot run inside this sandbox). Previously the longest source line was ~3000 characters; reviewing the following semantic changes now produces readable diffs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
119 lines
5.4 KiB
TypeScript
119 lines
5.4 KiB
TypeScript
import { afterEach, describe, expect, it } from 'vitest';
|
|
import { mkdtemp, writeFile, rm } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { resolveProvisionerTarget } from '../apps/api/src/domain/provisioner-target.js';
|
|
|
|
const directories: string[] = [];
|
|
const token = 'test-only-scoped-provisioner-token-32-plus';
|
|
async function configuration(tenants: Record<string, unknown>) {
|
|
const directory = await mkdtemp(join(tmpdir(), 'wishforge-provisioner-map-'));
|
|
directories.push(directory);
|
|
const path = join(directory, 'targets.json');
|
|
await writeFile(path, JSON.stringify({ schemaVersion: 1, tenants }));
|
|
return {
|
|
NODE_ENV: 'production',
|
|
WF_PROVISIONER_TARGETS_FILE: path,
|
|
WF_ALPHA_PROVISIONER_TOKEN: `${token}-alpha`,
|
|
WF_BETA_PROVISIONER_TOKEN: `${token}-beta`,
|
|
};
|
|
}
|
|
afterEach(async () => {
|
|
await Promise.all(directories.splice(0).map(directory => rm(directory, { recursive: true, force: true })));
|
|
});
|
|
describe('operator-only tenant provisioner routing', () => {
|
|
it('routes each tenant only to its configured endpoint and token reference', async () => {
|
|
const env = await configuration({
|
|
alpha: { url: 'https://provisioner-alpha.internal/', tokenEnv: 'WF_ALPHA_PROVISIONER_TOKEN' },
|
|
beta: { url: 'https://provisioner-beta.internal', tokenEnv: 'WF_BETA_PROVISIONER_TOKEN' },
|
|
});
|
|
expect(await resolveProvisionerTarget(env, 'alpha')).toEqual({
|
|
url: 'https://provisioner-alpha.internal',
|
|
token: env.WF_ALPHA_PROVISIONER_TOKEN,
|
|
});
|
|
expect(await resolveProvisionerTarget(env, 'beta')).toEqual({
|
|
url: 'https://provisioner-beta.internal',
|
|
token: env.WF_BETA_PROVISIONER_TOKEN,
|
|
});
|
|
});
|
|
it('never falls back to a global credential when an operator map omits the tenant', async () => {
|
|
const env = await configuration({
|
|
alpha: { url: 'https://provisioner-alpha.internal', tokenEnv: 'WF_ALPHA_PROVISIONER_TOKEN' },
|
|
});
|
|
expect(
|
|
await resolveProvisionerTarget(
|
|
{
|
|
...env,
|
|
WF_PROVISIONER_URL: 'https://legacy.internal',
|
|
WF_PROVISIONER_TOKEN: token,
|
|
WF_PROVISIONER_TENANT_ID: 'beta',
|
|
},
|
|
'beta',
|
|
),
|
|
).toBeUndefined();
|
|
});
|
|
it('requires legacy globals to have exactly one bound tenant', async () => {
|
|
const env = { NODE_ENV: 'production', WF_PROVISIONER_URL: 'https://legacy.internal', WF_PROVISIONER_TOKEN: token };
|
|
await expect(
|
|
resolveProvisionerTarget({ ...env, WF_DISPATCH_TENANTS: 'alpha,beta' }, 'alpha'),
|
|
).rejects.toMatchObject({ code: 'PROVISIONER_TENANT_BINDING_REQUIRED' });
|
|
expect(await resolveProvisionerTarget({ ...env, WF_DISPATCH_TENANTS: 'alpha' }, 'alpha')).toMatchObject({
|
|
url: env.WF_PROVISIONER_URL,
|
|
});
|
|
expect(await resolveProvisionerTarget({ ...env, WF_PROVISIONER_TENANT_ID: 'alpha' }, 'beta')).toBeUndefined();
|
|
expect(await resolveProvisionerTarget({}, 'alpha')).toBeUndefined();
|
|
});
|
|
it('keeps generated credentials without an installed endpoint unconfigured', async () => {
|
|
expect(
|
|
await resolveProvisionerTarget({ WF_PROVISIONER_TOKEN: token, WF_DISPATCH_TENANTS: 'alpha,beta' }, 'alpha'),
|
|
).toBeUndefined();
|
|
await expect(
|
|
resolveProvisionerTarget(
|
|
{ WF_PROVISIONER_URL: 'https://provisioner.internal', WF_PROVISIONER_TENANT_ID: 'alpha' },
|
|
'alpha',
|
|
),
|
|
).rejects.toMatchObject({ code: 'PROVISIONER_CONFIGURATION_INVALID' });
|
|
});
|
|
it('rejects plaintext remote targets, embedded credentials and unsafe credential names', async () => {
|
|
for (const url of [
|
|
'http://provisioner.internal',
|
|
'https://user:secret@provisioner.internal',
|
|
'https://provisioner.internal/?token=unsafe',
|
|
'https://provisioner.internal/#fragment',
|
|
]) {
|
|
const env = await configuration({ alpha: { url, tokenEnv: 'WF_ALPHA_PROVISIONER_TOKEN' } });
|
|
await expect(resolveProvisionerTarget(env, 'alpha')).rejects.toMatchObject({
|
|
code: 'PROVISIONER_CONFIGURATION_INVALID',
|
|
});
|
|
}
|
|
const env = await configuration({ alpha: { url: 'https://provisioner.internal', tokenEnv: 'HOME' } });
|
|
await expect(resolveProvisionerTarget(env, 'alpha')).rejects.toMatchObject({
|
|
code: 'PROVISIONER_CONFIGURATION_INVALID',
|
|
});
|
|
const local = {
|
|
NODE_ENV: 'test',
|
|
WF_PROVISIONER_TENANT_ID: 'alpha',
|
|
WF_PROVISIONER_URL: 'http://127.0.0.1:4450',
|
|
WF_PROVISIONER_TOKEN: token,
|
|
};
|
|
expect(await resolveProvisionerTarget(local, 'alpha')).toMatchObject({ url: local.WF_PROVISIONER_URL });
|
|
await expect(resolveProvisionerTarget({ ...local, NODE_ENV: 'production' }, 'alpha')).rejects.toMatchObject({
|
|
code: 'PROVISIONER_CONFIGURATION_INVALID',
|
|
});
|
|
});
|
|
it('rejects missing token material, malformed or oversized map files', async () => {
|
|
const env = await configuration({ alpha: { url: 'https://provisioner.internal', tokenEnv: 'WF_MISSING_TOKEN' } });
|
|
await expect(resolveProvisionerTarget(env, 'alpha')).rejects.toMatchObject({
|
|
code: 'PROVISIONER_CONFIGURATION_INVALID',
|
|
});
|
|
await writeFile(env.WF_PROVISIONER_TARGETS_FILE, '{');
|
|
await expect(resolveProvisionerTarget(env, 'alpha')).rejects.toMatchObject({
|
|
code: 'PROVISIONER_CONFIGURATION_INVALID',
|
|
});
|
|
await writeFile(env.WF_PROVISIONER_TARGETS_FILE, ' '.repeat(65537));
|
|
await expect(resolveProvisionerTarget(env, 'alpha')).rejects.toMatchObject({
|
|
code: 'PROVISIONER_CONFIGURATION_INVALID',
|
|
});
|
|
});
|
|
});
|