- handleAuthLogin now authenticates via store.FindUserByPhone instead of FindUserByEmail; the login/bootstrap-super-admin request payload field is now `phone`. Old email addresses are no longer valid login credentials. - bootstrap-super-admin now validates phone format (isValidChinaMobilePhone) instead of net/mail.ParseAddress; net/mail is fully removed from internal/api. - Same-class gap fix: handleAdminOrganizationUsersCreate (the legacy per-organization admin endpoint, not touched by ticket 02) still created users by email only, which would have left them unable to log in under the new phone-only login. Switched it to phone validation/uniqueness too, and removed the now-dead normalizeUserInput/validateUserEmailAvailable helpers. - Frontend: authApi.login, UserContext's login signature, and UserBootstrapPanel's submit handler now send `phone` instead of `email` (the form/labels were already phone-based from ticket 04). - Updated ~20 Go test files whose fixtures/helpers logged in via user.Email; adminCreateUser/loginSession/bootstrapSuperAdminSession now work in terms of phone (deterministically derived from existing email-shaped test identities via testPhoneFromSeed, to avoid rewriting every call site). Added internal/api/auth_phone_login_test.go covering phone login success/failure and old-email rejection. go test ./internal/api/... and npm run test:frontend match their pre-ticket baselines exactly (75 Go failures / 599 frontend tests with 586 pass, 13 fail) by failing test name, not just count.
364 lines
20 KiB
Go
364 lines
20 KiB
Go
package api
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"droboticflow/internal/domain"
|
|
"droboticflow/internal/store"
|
|
)
|
|
|
|
func TestProjectSupplierSelectionPreservesHistoricalDirectory(t *testing.T) {
|
|
items := []domain.SupplierRecord{{ID: "main", Status: "active"}, {ID: "history", Status: "active"}, {ID: "disabled", Status: "disabled"}}
|
|
selected := projectSelectableSuppliers(items, " main ")
|
|
if len(selected) != 1 || selected[0].ID != "main" {
|
|
t.Fatalf("selected=%v", selected)
|
|
}
|
|
if len(items) != 3 || items[1].ID != "history" {
|
|
t.Fatal("picker changed historical directory")
|
|
}
|
|
if len(projectSelectableSuppliers(items, "")) != 2 {
|
|
t.Fatal("unconfigured environments must retain active suppliers")
|
|
}
|
|
if len(projectSelectableSuppliers(items, "unknown")) != 0 {
|
|
t.Fatal("invalid configuration must not select another supplier")
|
|
}
|
|
}
|
|
|
|
func TestProjectMemberEndpointsInheritSingleAccountRole(t *testing.T) {
|
|
t.Setenv("DROBOTICFLOW_REQUIRE_SESSION_AUTH", "true")
|
|
ctx := context.Background()
|
|
dataStore := store.NewMemoryStore()
|
|
handler := NewHandler(dataStore, nil)
|
|
rootCookie := bootstrapSuperAdminSession(t, handler)
|
|
organization := adminCreateOrganization(t, handler, rootCookie, "Project members", "project-members")
|
|
admin := adminCreateUser(t, handler, rootCookie, organization.ID, "Org Admin", "org-admin@example.com", domain.UserRoleAdmin, "org-admin-password")
|
|
member := adminCreateUser(t, handler, rootCookie, organization.ID, "Worker", "worker@example.com", domain.UserRoleAnnotator, "worker-password")
|
|
adminCookie := loginSession(t, handler, admin.Phone, "org-admin-password")
|
|
project, err := dataStore.CreateProject(ctx, domain.CreateProjectInput{OrganizationID: organization.ID, Name: "测试项目"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
body, _ := json.Marshal(map[string]any{"userId": member.ID, "memberType": "internal", "roles": []string{"annotator"}})
|
|
created := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members", body, adminCookie)
|
|
if created.Code != http.StatusCreated {
|
|
t.Fatalf("create member=%d body=%s", created.Code, created.Body.String())
|
|
}
|
|
var stored domain.ProjectMemberRecord
|
|
if err := json.Unmarshal(created.Body.Bytes(), &stored); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(stored.Roles) != 1 || stored.SupplierID != domain.DefaultSupplierID(organization.ID) {
|
|
t.Fatalf("member=%#v", stored)
|
|
}
|
|
duplicate := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members", body, adminCookie)
|
|
if duplicate.Code != http.StatusConflict {
|
|
t.Fatalf("duplicate member=%d body=%s", duplicate.Code, duplicate.Body.String())
|
|
}
|
|
memberCookie := loginSession(t, handler, member.Phone, "worker-password")
|
|
listed := serveJSONWithCookie(handler, http.MethodGet, "/api/projects/"+project.ID+"/members", nil, memberCookie)
|
|
if listed.Code != http.StatusOK || !jsonContains(listed.Body.String(), member.ID) {
|
|
t.Fatalf("member list=%d body=%s", listed.Code, listed.Body.String())
|
|
}
|
|
updatedBody, _ := json.Marshal(map[string]any{"roles": []string{"acceptance_reviewer"}})
|
|
forbidden := serveJSONWithCookie(handler, http.MethodPatch, "/api/projects/"+project.ID+"/members/"+stored.ID, updatedBody, memberCookie)
|
|
if forbidden.Code != http.StatusForbidden {
|
|
t.Fatalf("member must not edit project roles: %d body=%s", forbidden.Code, forbidden.Body.String())
|
|
}
|
|
updated := serveJSONWithCookie(handler, http.MethodPatch, "/api/projects/"+project.ID+"/members/"+stored.ID, updatedBody, adminCookie)
|
|
if updated.Code != http.StatusBadRequest {
|
|
t.Fatalf("update=%d body=%s", updated.Code, updated.Body.String())
|
|
}
|
|
bulkRoles, _ := json.Marshal(map[string]any{"action": "set_roles", "memberIds": []string{stored.ID}, "roles": []string{"annotator", "quality_reviewer"}})
|
|
bulkUpdated := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members/bulk", bulkRoles, adminCookie)
|
|
if bulkUpdated.Code != http.StatusConflict {
|
|
t.Fatalf("bulk roles=%d body=%s", bulkUpdated.Code, bulkUpdated.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestOrganizationAdminCreatesButCannotChangeUserSupplierAssignment(t *testing.T) {
|
|
t.Setenv("DROBOTICFLOW_REQUIRE_SESSION_AUTH", "true")
|
|
ctx := context.Background()
|
|
dataStore := store.NewMemoryStore()
|
|
handler := NewHandler(dataStore, nil)
|
|
rootCookie := bootstrapSuperAdminSession(t, handler)
|
|
organization := adminCreateOrganization(t, handler, rootCookie, "User suppliers", "user-suppliers")
|
|
admin := adminCreateUser(t, handler, rootCookie, organization.ID, "Org Admin", "user-supplier-admin@example.com", domain.UserRoleAdmin, "admin-password")
|
|
adminCookie := loginSession(t, handler, admin.Phone, "admin-password")
|
|
supplierA := domain.SupplierRecord{ID: "user-supplier-a", OrganizationID: organization.ID, Name: "Supplier A", Status: "active"}
|
|
supplierB := domain.SupplierRecord{ID: "user-supplier-b", OrganizationID: organization.ID, Name: "Supplier B", Status: "active"}
|
|
if err := dataStore.UpsertSupplier(ctx, supplierA); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := dataStore.UpsertSupplier(ctx, supplierB); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
createBody, _ := json.Marshal(map[string]any{
|
|
"name": "Supplier Worker", "phone": "13800003001", "role": "annotator",
|
|
"supplierId": supplierA.ID, "password": "worker-password",
|
|
})
|
|
created := serveJSONWithCookie(handler, http.MethodPost, "/api/users", createBody, adminCookie)
|
|
if created.Code != http.StatusCreated || !jsonContains(created.Body.String(), `"supplierId":"user-supplier-a"`) {
|
|
t.Fatalf("create user supplier=%d body=%s", created.Code, created.Body.String())
|
|
}
|
|
var user domain.UserRecord
|
|
if err := json.Unmarshal(created.Body.Bytes(), &user); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
updateBody, _ := json.Marshal(map[string]any{"supplierId": supplierB.ID})
|
|
updated := serveJSONWithCookie(handler, http.MethodPut, "/api/users/"+user.ID, updateBody, adminCookie)
|
|
if updated.Code != http.StatusConflict || !jsonContains(updated.Body.String(), `"code":"supplier_immutable"`) {
|
|
t.Fatalf("update user supplier=%d body=%s", updated.Code, updated.Body.String())
|
|
}
|
|
invalidBody, _ := json.Marshal(map[string]any{"supplierId": "missing-supplier"})
|
|
invalid := serveJSONWithCookie(handler, http.MethodPut, "/api/users/"+user.ID, invalidBody, adminCookie)
|
|
if invalid.Code != http.StatusConflict || !jsonContains(invalid.Body.String(), `"code":"supplier_immutable"`) {
|
|
t.Fatalf("invalid user supplier=%d body=%s", invalid.Code, invalid.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestBulkProjectMemberRemovalReleasesClaimedTasks(t *testing.T) {
|
|
t.Setenv("DROBOTICFLOW_REQUIRE_SESSION_AUTH", "true")
|
|
ctx := context.Background()
|
|
dataStore := store.NewMemoryStore()
|
|
handler := NewHandler(dataStore, nil)
|
|
rootCookie := bootstrapSuperAdminSession(t, handler)
|
|
organization := adminCreateOrganization(t, handler, rootCookie, "Bulk members", "bulk-members")
|
|
admin := adminCreateUser(t, handler, rootCookie, organization.ID, "Org Admin", "bulk-admin@example.com", domain.UserRoleAdmin, "admin-password")
|
|
worker := adminCreateUser(t, handler, rootCookie, organization.ID, "Worker", "bulk-worker@example.com", domain.UserRoleAnnotator, "worker-password")
|
|
adminCookie := loginSession(t, handler, admin.Phone, "admin-password")
|
|
project, err := dataStore.CreateProject(ctx, domain.CreateProjectInput{OrganizationID: organization.ID, Name: "Bulk project"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
memberBody, _ := json.Marshal(map[string]any{"userId": worker.ID, "memberType": "internal", "roles": []string{"annotator"}})
|
|
created := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members", memberBody, adminCookie)
|
|
if created.Code != http.StatusCreated {
|
|
t.Fatalf("create member=%d body=%s", created.Code, created.Body.String())
|
|
}
|
|
var member domain.ProjectMemberRecord
|
|
if err := json.Unmarshal(created.Body.Bytes(), &member); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
item := domain.HumanItemRecord{
|
|
ID: "bulk-item", OrganizationID: organization.ID, ProjectID: project.ID, CurrentStageID: domain.FanyuV58StageAnnotationCombined,
|
|
Status: domain.HumanItemClaimed, AssignedUserID: worker.ID, Version: 1, CreatedAt: nowISO(), UpdatedAt: nowISO(),
|
|
}
|
|
if err := dataStore.UpsertHumanItem(ctx, item); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
removeBody, _ := json.Marshal(map[string]any{"action": "remove", "memberIds": []string{member.ID}})
|
|
removed := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members/bulk", removeBody, adminCookie)
|
|
if removed.Code != http.StatusOK || !jsonContains(removed.Body.String(), `"updated":1`) {
|
|
t.Fatalf("bulk remove=%d body=%s", removed.Code, removed.Body.String())
|
|
}
|
|
released, _ := dataStore.GetHumanItem(ctx, item.ID)
|
|
if released == nil || released.Status != domain.HumanItemReady || released.AssignedUserID != "" || released.Version != 2 {
|
|
t.Fatalf("claimed task was not released: %#v", released)
|
|
}
|
|
deleted, _ := dataStore.GetProjectMember(ctx, member.ID)
|
|
if deleted != nil {
|
|
t.Fatalf("member still exists after bulk removal: %#v", deleted)
|
|
}
|
|
}
|
|
|
|
func TestBulkProjectMemberAddValidatesWholeRequestBeforeWriting(t *testing.T) {
|
|
t.Setenv("DROBOTICFLOW_REQUIRE_SESSION_AUTH", "true")
|
|
ctx := context.Background()
|
|
dataStore := store.NewMemoryStore()
|
|
handler := NewHandler(dataStore, nil)
|
|
rootCookie := bootstrapSuperAdminSession(t, handler)
|
|
organization := adminCreateOrganization(t, handler, rootCookie, "Bulk add members", "bulk-add-members")
|
|
admin := adminCreateUser(t, handler, rootCookie, organization.ID, "Org Admin", "bulk-add-admin@example.com", domain.UserRoleAdmin, "admin-password")
|
|
first := adminCreateUser(t, handler, rootCookie, organization.ID, "First", "bulk-first@example.com", domain.UserRoleAnnotator, "worker-password")
|
|
second := adminCreateUser(t, handler, rootCookie, organization.ID, "Second", "bulk-second@example.com", domain.UserRoleQualityReviewer, "worker-password")
|
|
third := adminCreateUser(t, handler, rootCookie, organization.ID, "Third", "bulk-third@example.com", domain.UserRoleAnnotator, "worker-password")
|
|
adminCookie := loginSession(t, handler, admin.Phone, "admin-password")
|
|
project, err := dataStore.CreateProject(ctx, domain.CreateProjectInput{OrganizationID: organization.ID, Name: "Bulk add project"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
supplier := domain.SupplierRecord{ID: domain.DefaultSupplierID(organization.ID), OrganizationID: organization.ID, Name: "Bulk supplier"}
|
|
if err := dataStore.UpsertSupplier(ctx, supplier); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
addBody, _ := json.Marshal(map[string]any{
|
|
"action": "add",
|
|
"entries": []map[string]any{
|
|
{"userId": first.ID, "supplierId": supplier.ID, "roles": []string{"annotator"}},
|
|
{"userId": second.ID, "memberType": "internal", "roles": []string{"quality_reviewer"}},
|
|
},
|
|
})
|
|
added := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members/bulk", addBody, adminCookie)
|
|
if added.Code != http.StatusOK || !jsonContains(added.Body.String(), `"created":2`) || !jsonContains(added.Body.String(), `"updated":0`) {
|
|
t.Fatalf("bulk add=%d body=%s", added.Code, added.Body.String())
|
|
}
|
|
firstMember, _ := dataStore.GetProjectMemberByProjectUser(ctx, organization.ID, project.ID, first.ID)
|
|
secondMember, _ := dataStore.GetProjectMemberByProjectUser(ctx, organization.ID, project.ID, second.ID)
|
|
if firstMember == nil || firstMember.SupplierID != supplier.ID || len(firstMember.Roles) != 1 {
|
|
t.Fatalf("first member=%#v", firstMember)
|
|
}
|
|
if secondMember == nil || len(secondMember.Roles) != 1 {
|
|
t.Fatalf("second member=%#v", secondMember)
|
|
}
|
|
|
|
conflictBody, _ := json.Marshal(map[string]any{
|
|
"action": "add",
|
|
"entries": []map[string]any{
|
|
{"userId": third.ID, "memberType": "internal", "roles": []string{"annotator"}},
|
|
{"userId": first.ID, "roles": []string{"annotator"}},
|
|
},
|
|
})
|
|
conflict := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members/bulk", conflictBody, adminCookie)
|
|
if conflict.Code != http.StatusConflict || !jsonContains(conflict.Body.String(), `"code":"project_member_exists"`) {
|
|
t.Fatalf("existing conflict=%d body=%s", conflict.Code, conflict.Body.String())
|
|
}
|
|
thirdMember, _ := dataStore.GetProjectMemberByProjectUser(ctx, organization.ID, project.ID, third.ID)
|
|
if thirdMember != nil {
|
|
t.Fatalf("bulk conflict partially created third member: %#v", thirdMember)
|
|
}
|
|
|
|
duplicateBody, _ := json.Marshal(map[string]any{
|
|
"action": "add",
|
|
"entries": []map[string]any{
|
|
{"userId": third.ID, "memberType": "internal", "roles": []string{"annotator"}},
|
|
{"userId": third.ID, "memberType": "internal", "roles": []string{"quality_reviewer"}},
|
|
},
|
|
})
|
|
duplicate := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members/bulk", duplicateBody, adminCookie)
|
|
if duplicate.Code != http.StatusConflict || !jsonContains(duplicate.Body.String(), `"code":"duplicate_project_member_entry"`) {
|
|
t.Fatalf("payload duplicate=%d body=%s", duplicate.Code, duplicate.Body.String())
|
|
}
|
|
thirdMember, _ = dataStore.GetProjectMemberByProjectUser(ctx, organization.ID, project.ID, third.ID)
|
|
if thirdMember != nil {
|
|
t.Fatalf("duplicate payload partially created third member: %#v", thirdMember)
|
|
}
|
|
|
|
memberCookie := loginSession(t, handler, third.Phone, "worker-password")
|
|
forbidden := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members/bulk", duplicateBody, memberCookie)
|
|
if forbidden.Code != http.StatusForbidden {
|
|
t.Fatalf("ordinary member bulk add=%d body=%s", forbidden.Code, forbidden.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestSupplierManagerMaintainsOnlyOwnSupplierProjectMembers(t *testing.T) {
|
|
t.Setenv("DROBOTICFLOW_REQUIRE_SESSION_AUTH", "true")
|
|
ctx := context.Background()
|
|
dataStore := store.NewMemoryStore()
|
|
handler := NewHandler(dataStore, nil)
|
|
rootCookie := bootstrapSuperAdminSession(t, handler)
|
|
organization := adminCreateOrganization(t, handler, rootCookie, "Supplier member scope", "supplier-member-scope")
|
|
supplierA := domain.SupplierRecord{ID: "supplier-a", OrganizationID: organization.ID, Name: "Supplier A", Status: "active"}
|
|
supplierB := domain.SupplierRecord{ID: "supplier-b", OrganizationID: organization.ID, Name: "Supplier B", Status: "active"}
|
|
if err := dataStore.UpsertSupplier(ctx, supplierA); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := dataStore.UpsertSupplier(ctx, supplierB); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
admin := adminCreateUser(t, handler, rootCookie, organization.ID, "Organization Admin", "supplier-org-admin@example.com", domain.UserRoleAdmin, "admin-password")
|
|
adminCookie := loginSession(t, handler, admin.Phone, "admin-password")
|
|
manager := adminCreateUser(t, handler, rootCookie, organization.ID, "Supplier Manager", "supplier-manager@example.com", domain.UserRoleSupplierManager, "manager-password", supplierA.ID)
|
|
storedManager, err := dataStore.GetUser(ctx, manager.ID)
|
|
if err != nil || storedManager == nil {
|
|
t.Fatalf("load manager: %#v err=%v", storedManager, err)
|
|
}
|
|
storedManager.SupplierID = supplierA.ID
|
|
if err := dataStore.UpsertUser(ctx, *storedManager); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
workerA := adminCreateUser(t, handler, rootCookie, organization.ID, "Worker A", "supplier-worker-a@example.com", domain.UserRoleAnnotator, "worker-password", supplierA.ID)
|
|
storedWorkerA, err := dataStore.GetUser(ctx, workerA.ID)
|
|
if err != nil || storedWorkerA == nil {
|
|
t.Fatalf("load worker A: %#v err=%v", storedWorkerA, err)
|
|
}
|
|
storedWorkerA.SupplierID = supplierA.ID
|
|
if err := dataStore.UpsertUser(ctx, *storedWorkerA); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
workerB := adminCreateUser(t, handler, rootCookie, organization.ID, "Worker B", "supplier-worker-b@example.com", domain.UserRoleAnnotator, "worker-password", supplierB.ID)
|
|
storedWorkerB, err := dataStore.GetUser(ctx, workerB.ID)
|
|
if err != nil || storedWorkerB == nil {
|
|
t.Fatalf("load worker B: %#v err=%v", storedWorkerB, err)
|
|
}
|
|
storedWorkerB.SupplierID = supplierB.ID
|
|
if err := dataStore.UpsertUser(ctx, *storedWorkerB); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
managerCookie := loginSession(t, handler, manager.Phone, "manager-password")
|
|
project, err := dataStore.CreateProject(ctx, domain.CreateProjectInput{OrganizationID: organization.ID, Name: "Supplier project"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
ownBody, _ := json.Marshal(map[string]any{"userId": workerA.ID, "supplierId": supplierA.ID, "roles": []string{"annotator"}})
|
|
created := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members", ownBody, managerCookie)
|
|
if created.Code != http.StatusCreated {
|
|
t.Fatalf("supplier manager create own member=%d body=%s", created.Code, created.Body.String())
|
|
}
|
|
var ownMember domain.ProjectMemberRecord
|
|
if err := json.Unmarshal(created.Body.Bytes(), &ownMember); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
updateBody, _ := json.Marshal(map[string]any{"supplierId": supplierA.ID, "roles": []string{"annotator", "quality_reviewer"}})
|
|
updated := serveJSONWithCookie(handler, http.MethodPatch, "/api/projects/"+project.ID+"/members/"+ownMember.ID, updateBody, managerCookie)
|
|
if updated.Code != http.StatusBadRequest {
|
|
t.Fatalf("supplier manager update own member=%d body=%s", updated.Code, updated.Body.String())
|
|
}
|
|
|
|
otherBody, _ := json.Marshal(map[string]any{"userId": workerB.ID, "supplierId": supplierB.ID, "roles": []string{"annotator"}})
|
|
forbidden := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members", otherBody, managerCookie)
|
|
if forbidden.Code != http.StatusForbidden || !jsonContains(forbidden.Body.String(), `"code":"supplier_scope_forbidden"`) {
|
|
t.Fatalf("supplier manager crossed supplier scope=%d body=%s", forbidden.Code, forbidden.Body.String())
|
|
}
|
|
otherMember, _ := dataStore.GetProjectMemberByProjectUser(ctx, organization.ID, project.ID, workerB.ID)
|
|
if otherMember != nil {
|
|
t.Fatalf("cross-supplier member was created: %#v", otherMember)
|
|
}
|
|
createdOther := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members", otherBody, adminCookie)
|
|
if createdOther.Code != http.StatusCreated {
|
|
t.Fatalf("organization admin create other supplier member=%d body=%s", createdOther.Code, createdOther.Body.String())
|
|
}
|
|
if err := json.Unmarshal(createdOther.Body.Bytes(), &otherMember); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
bulkCrossSupplier, _ := json.Marshal(map[string]any{
|
|
"action": "remove",
|
|
"memberIds": []string{ownMember.ID, otherMember.ID},
|
|
"roles": []string{"acceptance_reviewer"},
|
|
})
|
|
bulkForbidden := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members/bulk", bulkCrossSupplier, managerCookie)
|
|
if bulkForbidden.Code != http.StatusForbidden || !jsonContains(bulkForbidden.Body.String(), `"code":"supplier_scope_forbidden"`) {
|
|
t.Fatalf("supplier manager bulk crossed supplier scope=%d body=%s", bulkForbidden.Code, bulkForbidden.Body.String())
|
|
}
|
|
unchangedOwn, _ := dataStore.GetProjectMember(ctx, ownMember.ID)
|
|
if unchangedOwn == nil || len(unchangedOwn.Roles) != 1 || unchangedOwn.Roles[0] != domain.AnnotationRoleAnnotator {
|
|
t.Fatalf("cross-supplier bulk request partially changed own member: %#v", unchangedOwn)
|
|
}
|
|
bulkOwn, _ := json.Marshal(map[string]any{
|
|
"action": "set_roles",
|
|
"memberIds": []string{ownMember.ID},
|
|
"roles": []string{"acceptance_reviewer"},
|
|
})
|
|
bulkUpdated := serveJSONWithCookie(handler, http.MethodPost, "/api/projects/"+project.ID+"/members/bulk", bulkOwn, managerCookie)
|
|
if bulkUpdated.Code != http.StatusConflict {
|
|
t.Fatalf("supplier manager bulk own member=%d body=%s", bulkUpdated.Code, bulkUpdated.Body.String())
|
|
}
|
|
}
|
|
|
|
func jsonContains(value string, expected string) bool {
|
|
return len(expected) == 0 || (len(value) >= len(expected) && containsText(value, expected))
|
|
}
|
|
|
|
func containsText(value string, expected string) bool {
|
|
for index := 0; index+len(expected) <= len(value); index++ {
|
|
if value[index:index+len(expected)] == expected {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|