droboticflow/internal/api/acceptance_priority_stats_test.go
d-robotics 6fbd805e47
Some checks failed
web-ci / checks (push) Has been cancelled
web-ci / pool-search-mongo (push) Has been cancelled
web-ci / work-availability (push) Has been cancelled
web-ci / query-serving (push) Has been cancelled
🛠️ Decouple acceptance priority settings from statistics
2026-11-16 21:30:49 -08:00

147 lines
5.0 KiB
Go

package api
import (
"context"
"droboticflow/internal/domain"
"droboticflow/internal/store"
"encoding/json"
"errors"
"fmt"
"sync/atomic"
"testing"
"time"
)
type priorityStatsGuard struct {
store.Store
calls atomic.Int32
wait bool
}
func (s *priorityStatsGuard) ListReviewCandidates(ctx context.Context, org, project, user string, mine bool, offset, limit int, stages ...string) ([]domain.HumanItemRecord, error) {
s.calls.Add(1)
if s.wait {
<-ctx.Done()
return nil, ctx.Err()
}
return nil, errors.New("statistics unavailable")
}
func TestAcceptancePriorityConfigDoesNotWaitForStatistics(t *testing.T) {
f := priorityFixture(t)
g := &priorityStatsGuard{Store: f.store}
f.handler = NewHandler(g, nil)
// Representative backlog is irrelevant to metadata GET/save/cancel.
for i := 0; i < 5600; i++ {
v := f.item
v.ID = fmt.Sprintf("backlog-%d", i)
_ = f.store.UpsertHumanItem(f.ctx, v)
}
for _, op := range []struct {
method string
body any
}{{"GET", nil}, {"PUT", map[string]any{"enabled": true, "version": 0, "expiresAt": time.Now().Add(time.Hour).UTC().Format(time.RFC3339)}}, {"PUT", map[string]any{"enabled": false, "version": 1}}} {
at := time.Now()
r := f.request(op.method, "/api/suppliers/priority-production/acceptance-priority", f.admin, op.body)
if r.Code != 200 || time.Since(at) >= time.Second {
t.Fatalf("config blocked %d %s", r.Code, r.Body)
}
var v map[string]any
_ = json.Unmarshal(r.Body.Bytes(), &v)
if v["remainingCount"] != nil || v["unresolvedCount"] != nil {
t.Fatal("unknown statistics became zero")
}
}
if g.calls.Load() != 0 {
t.Fatal("config touched candidate scan")
}
rows, _ := f.store.ListAcceptancePriorities(f.ctx, f.item.OrganizationID)
if len(rows) != 1 || rows[0].Version != 2 || rows[0].Enabled || len(rows[0].History) != 2 {
t.Fatal("save/cancel not persisted")
}
}
func TestAcceptancePriorityStatisticsFailureAndDeadline(t *testing.T) {
for _, wait := range []bool{false, true} {
t.Run(fmt.Sprint(wait), func(t *testing.T) {
f := priorityFixture(t)
g := &priorityStatsGuard{Store: f.store, wait: wait}
f.handler = NewHandler(g, nil)
at := time.Now()
r := f.request("GET", "/api/suppliers/priority-production/acceptance-priority/statistics?version=0", f.admin, nil)
if r.Code != 200 || !json.Valid(r.Body.Bytes()) {
t.Fatalf("stats %d %s", r.Code, r.Body)
}
var v map[string]any
_ = json.Unmarshal(r.Body.Bytes(), &v)
if v["status"] != "incomplete" || v["remainingCount"] != nil || v["unresolvedCount"] != nil {
t.Fatalf("partial stats mistaken for count %s", r.Body)
}
if g.calls.Load() != 1 || time.Since(at) > 3*time.Second {
t.Fatal("statistics deadline not enforced")
}
})
}
}
func TestAcceptancePriorityStatisticsVersionAndBoundary(t *testing.T) {
f := priorityFixture(t)
path := "/api/suppliers/priority-production/acceptance-priority/statistics"
for _, actor := range []domain.UserRecord{f.annotator, f.reviewer} {
if r := f.request("GET", path+"?version=0", actor, nil); r.Code != 403 {
t.Fatal("stats identity leaked")
}
}
r := f.request("GET", path+"?version=0", f.admin, nil)
var v map[string]any
_ = json.Unmarshal(r.Body.Bytes(), &v)
if r.Code != 200 || v["status"] != "completed" || v["remainingCount"] != float64(0) {
t.Fatalf("real zero %d %s", r.Code, r.Body)
}
priorityPolicy(t, f, true, 0, time.Now().Add(time.Hour).UTC().Format(time.RFC3339), nil)
r = f.request("GET", path+"?version=0", f.admin, nil)
_ = json.Unmarshal(r.Body.Bytes(), &v)
if v["status"] != "incomplete" || v["remainingCount"] != nil {
t.Fatal("stale scope counted")
}
}
// Saving must be independent even while an earlier statistics request is waiting.
type priorityConcurrentStatsStore struct {
store.Store
started chan struct{}
release chan struct{}
}
func (s *priorityConcurrentStatsStore) ListReviewCandidates(ctx context.Context, org, project, user string, mine bool, offset, limit int, stages ...string) ([]domain.HumanItemRecord, error) {
select {
case s.started <- struct{}{}:
default:
}
select {
case <-ctx.Done():
return nil, ctx.Err()
case <-s.release:
}
return s.Store.ListReviewCandidates(ctx, org, project, user, mine, offset, limit, stages...)
}
func TestAcceptancePrioritySaveWhileStatisticsIsPending(t *testing.T) {
f := priorityFixture(t)
g := &priorityConcurrentStatsStore{Store: f.store, started: make(chan struct{}, 1), release: make(chan struct{})}
f.handler = NewHandler(g, nil)
done := make(chan string, 1)
go func() {
r := f.request("GET", "/api/suppliers/priority-production/acceptance-priority/statistics?version=0", f.admin, nil)
done <- r.Body.String()
}()
<-g.started
at := time.Now()
priorityPolicy(t, f, true, 0, time.Now().Add(time.Hour).UTC().Format(time.RFC3339), []string{f.item.ProjectID})
if time.Since(at) >= time.Second {
t.Fatal("save waited for statistics")
}
close(g.release)
var v map[string]any
_ = json.Unmarshal([]byte(<-done), &v)
if v["status"] != "incomplete" || v["remainingCount"] != nil {
t.Fatal("old version statistics published after save")
}
}