🐛 Retain referenced release snapshots when removing templates

This commit is contained in:
eust-w 2026-09-06 23:51:08 +08:00
parent 5d76376d74
commit 2afe12bfeb
3 changed files with 59 additions and 8 deletions

View File

@ -1157,14 +1157,21 @@ func (store *MemoryStore) CreateTemplate(_ context.Context, input domain.CreateT
func (store *MemoryStore) DeleteTemplate(_ context.Context, id string) (bool, error) {
store.mu.Lock()
defer store.mu.Unlock()
for releaseID, release := range store.workflowReleases {
if release.TemplateID == id {
delete(store.workflowReleases, releaseID)
}
}
if _, ok := store.templates[id]; !ok {
return false, nil
}
referenced := map[string]bool{}
for _, instance := range store.projectWorkflowInstances {
referenced[instance.ReleaseID] = true
}
for _, run := range store.runs {
referenced[run.ReleaseID] = true
}
for releaseID, release := range store.workflowReleases {
if release.TemplateID == id && !referenced[releaseID] {
delete(store.workflowReleases, releaseID)
}
}
delete(store.templates, id)
return true, nil
}

View File

@ -892,7 +892,17 @@ func (store *MongoStore) DeleteTemplate(ctx context.Context, id string) (bool, e
if id == "" {
return false, nil
}
if _, err := store.workflowReleases.DeleteMany(ctx, bson.M{"templateId": id}); err != nil {
// Removing the template entry must not invalidate immutable snapshots
// still used by project instances or historical/active Runs.
referenced := []any{}
for _, collection := range []*mongo.Collection{store.projectWorkflowInstances, store.runs} {
ids, err := collection.Distinct(ctx, "releaseId", bson.M{"releaseId": bson.M{"$exists": true, "$ne": ""}})
if err != nil {
return false, err
}
referenced = append(referenced, ids...)
}
if _, err := store.workflowReleases.DeleteMany(ctx, bson.M{"templateId": id, "id": bson.M{"$nin": referenced}}); err != nil {
return false, err
}
result, err := store.templates.DeleteOne(ctx, bson.M{"id": id})

View File

@ -217,6 +217,42 @@ func TestMemoryStoreDeleteProjectCascadesAllResources(t *testing.T) {
}
}
func TestMemoryStoreDeleteTemplateRetainsReferencedReleases(t *testing.T) {
ctx := context.Background()
s := NewMemoryStore()
if err := s.UpsertTemplate(ctx, domain.TemplateRecord{ID: "template", OrganizationID: "org-a"}); err != nil {
t.Fatal(err)
}
for _, id := range []string{"instance-release", "run-release", "unused-release"} {
if err := s.UpsertWorkflowRelease(ctx, domain.WorkflowReleaseRecord{ID: id, TemplateID: "template", OrganizationID: "org-a"}); err != nil {
t.Fatal(err)
}
}
if err := s.UpsertProjectWorkflowInstance(ctx, domain.ProjectWorkflowInstanceRecord{ID: "instance", ReleaseID: "instance-release", SourceTemplateID: "template", OrganizationID: "org-a"}); err != nil {
t.Fatal(err)
}
if err := s.UpsertRun(ctx, domain.RunRecord{ID: "run", ReleaseID: "run-release", OrganizationID: "org-a"}); err != nil {
t.Fatal(err)
}
if ok, err := s.DeleteTemplate(ctx, "template"); err != nil || !ok {
t.Fatalf("delete: %v %v", ok, err)
}
for _, id := range []string{"instance-release", "run-release"} {
if r, err := s.GetWorkflowRelease(ctx, id); err != nil || r == nil {
t.Fatalf("referenced release lost: %s %v", id, err)
}
}
if r, _ := s.GetWorkflowRelease(ctx, "unused-release"); r != nil {
t.Fatal("unused release retained")
}
if item, _ := s.GetTemplate(ctx, "template"); item != nil {
t.Fatal("template entry retained")
}
if ok, err := s.DeleteTemplate(ctx, "template"); err != nil || ok {
t.Fatalf("repeat delete: %v %v", ok, err)
}
}
func TestMemoryStoreDeleteTemplateCascadesWorkflowReleases(t *testing.T) {
ctx := context.Background()
dataStore := NewMemoryStore()
@ -262,5 +298,3 @@ func TestMemoryStoreDeleteOrganizationCascadesAnnotationLabels(t *testing.T) {
t.Fatalf("labels should be cascaded: %#v err=%v", labels, err)
}
}