📝 Record integrated review flow verification

This commit is contained in:
d-robotics 2026-09-23 07:14:56 +08:00
parent fc04d7d929
commit 2e7d563dcb
8 changed files with 100 additions and 25 deletions

View File

@ -11,10 +11,10 @@ Status: resolved
## Acceptance criteria
- [ ] 公开API接受同目标不同ID,保留输入稳定顺序和既有目标校验
- [ ] 只更新/删除明确问题ID,其余保留;重复ID仍拒绝
- [ ] 重复operationId不重复保存;旧版本/旧页面写入仍拒绝
- [ ] 针对质检及终审聚合来源的API红绿回归通过
- [x] 公开API接受同目标不同ID,保留输入稳定顺序和既有目标校验
- [x] 只更新/删除明确问题ID,其余保留;重复ID仍拒绝
- [x] 重复operationId不重复保存;旧版本/旧页面写入仍拒绝
- [x] 针对质检及终审聚合来源的API红绿回归通过
## Comments

View File

@ -1,7 +1,7 @@
# 02: 批注新增、回查、编辑、删除与焦点闭环
Type: task
Status: claimed
Status: resolved
**What to build:** 完整打通两阶段四布局的F分步录入、多问题、CtrlEnter清空、Esc退出、列表导航、删除、可边看边写以及未决保存恢复。
@ -11,14 +11,20 @@ Status: claimed
## Acceptance criteria
- [ ] 按spec规则2–9和11–12完整接线,原数据只读
- [ ] F新增与Enter编辑区分,Ctrl上下只选择,输入框保留原生行为
- [ ] 保存成功/取消/删除后的焦点回工作台,导航不抢焦点
- [ ] 真实浏览器+API验证同对象两条、编辑/删除/刷新和失败核对
- [ ] 按spec记录所有异步/版本/接管边界并通过类型检查
- [x] 按spec规则2–9和11–12完整接线,原数据只读
- [x] F新增与Enter编辑区分,Ctrl上下只选择,输入框保留原生行为
- [x] 保存成功/取消/删除后的焦点回工作台,导航不抢焦点
- [x] 真实浏览器+API验证同对象两条、编辑/删除/刷新和失败核对
- [x] 按spec记录所有异步/版本/接管边界并通过类型检查
## Comments
由Pi实现;主代理审查后决定resolved,不由实现者自行宣布整合完成。
Assigned to: Pi dg/glm-5.3; UI contract implemented in parallel; integration after 01/03/04 review.
## Answer
Pi 02 完成编辑流程,主代理整合为 `a41fc3e7`,审查修复整合为 `9823cbee`、`ce210b7c`、`45f3646c`。两项独立审查发现的四个焦点/回查问题均已修复并复核。
Pi 05 在独立本地数据库完成质检/终审 × 普通/专注四组合浏览器与 API 回读验收:独立多条批注、保存清空、回查与编辑区分、确认删除、Esc、边看边写、原生输入键位、未知结果核对、跨聚合来源画面定位均通过;延迟写入与多页面接管回归通过。主代理复核结果文件、测试断言与类型检查。完整证据汇总见 [验证报告](../../../docs/review-problem-flow-validation-2026-09-23.md)。

View File

@ -1,7 +1,7 @@
# 03: 主动进入自动连续与异常暂停
Type: task
Status: claimed
Status: resolved
**What to build:** 领取或继续任务后自动开启连续审查,刷新和各种暂停仍可靠。
@ -21,3 +21,7 @@ Status: claimed
由Pi实现;主代理审查后决定resolved,不由实现者自行宣布整合完成。
Assigned to: Pi dg/glm-5.3; isolated ticket 03 worktree.
## Answer
Pi 实现并修复了显式领取/继续后的单次自动连续审查、刷新与预览不自动启动、普通与专注布局的缩窗暂停、手动恢复及等待态控制。主代理在整合根版本以真实 API 和浏览器复测通过:质检 10 项、终审 5 项,包含小窗口进入锁存、重复继续、布局切换、陈旧意图和空队列等待。验收脚本为 `tests/browser/review-automatic-entry.mjs`,本地隔离夹具会修复旧 attempt ID;未改生产存储逻辑。

View File

@ -11,10 +11,10 @@ Status: resolved
## Acceptance criteria
- [ ] 移除审查JSON入口和内容,保留长描述全文及证据异常提示
- [ ] 无效仅显示无效片段,舍弃/空白业务状态不混淆
- [ ] 单/双画面与1413×615样式不破坏,不改变标注员页面
- [ ] 模型k3对实际截图检查并记录观察与限制
- [x] 移除审查JSON入口和内容,保留长描述全文及证据异常提示
- [x] 无效仅显示无效片段,舍弃/空白业务状态不混淆
- [x] 单/双画面与1413×615样式不破坏,不改变标注员页面
- [x] 模型k3对实际截图检查并记录观察与限制
## Comments

View File

@ -1,7 +1,7 @@
# 05: 真实工作流整合验收与说明书
Type: task
Status: claimed
Status: resolved
**What to build:** 完成两角色的实际浏览器复测、必要API回归、整体检查及说明书,使完整修订可审查交付。
@ -19,7 +19,11 @@ Status: claimed
## Comments
由Pi实现;主代理审查后决定resolved,不由实现者自行宣布整合完成。
由Pi实现;主代理审查后决定 resolved。
## Answer
浏览器整合矩阵、字幕几何、草稿保存/延迟写入、普通 HTTP 接管、正式决定确认及全量基线检查均已记录在 [验证报告](../../docs/review-problem-flow-validation-2026-09-23.md) 和 [操作说明](../../docs/review-workspace-guide.zh-CN.md)。整合验收通过;决策恢复脚本因默认夹具已被消耗而保留为未通过的测试限制,重复提交 409 门禁仍通过,未伪报为产品通过。
## Execution

View File

@ -0,0 +1,55 @@
# Review log
Candidate: `a41fc3e7`; comparison: `git diff b6c3f32b...a41fc3e7`.
Ticket 03 and final integrated verification were still pending during this first review.
## Standards
No hard documented-standard violations. Two correctness findings:
1. Discarding dirty text synchronously retries the guarded action before `dirtyRef` updates, reopening the guard instead of continuing.
2. Aggregate whole-task picture recall maps the global problem's empty target fields instead of its `viewAnchor`; the raw slice ID cannot select the composite acceptance group.
## Spec
Three correctness findings against confirmed rules 3, 8 and 9:
1. Dirty text → F → discard does not continue into the new scope picker.
2. Whole-task recall across acceptance source members does not restore the recorded picture.
3. Dirty text → F → save and continue → Esc during the request can reopen the cancelled flow when the response arrives.
The first two overlap with the Standards findings. Both reviewers inspected code only; browser evidence is required separately. The existing editor test suppressed the first failure with a swallowed timeout and covered the anchor only within one slice; those assertions must be corrected as part of the fixes.
## Follow-up
All findings returned to Pi 02. Resolution and final re-review are pending; this record does not represent approval to push.
## Ticket 03 checkpoint review
Candidate `a79ec6b0` (integrated as `a6b9b9ff`), with live worktree follow-up. Standards reviewer reported two rule-10 correctness gaps: ordinary waiting sessions lose their Pause control once the current item retires; ordinary continuous review ignores the undersized-window pause. Both returned to Pi03. Returning to the task pool must still pause, so the existing focused return handler is intentional; its layout-toggle comment needs clarification.
## Editor re-review
Root `9823cbee` resolved the original three causes and strengthened their browser assertions. A fourth focus race was found: successful 保存并继续 queued an old workbench focus after the new scope picker appeared. Pi corrected this in `da3c19cc` (root `45f3646c`) with cancellable focus delivery and a two-animation-frame browser assertion. Spec reviewer confirms all four resolved statically; independent browser matrix remains required. No concrete regression found in the follow-up diff.
## Continuation re-review
At `64d63acd`, waiting controls and shrinking an already active ordinary session were fixed. A narrower P2 remains: explicitly entering while the ordinary window is already undersized can leave a pending auto-start intent that fires when the window is enlarged. Returned to Pi03 with an already-small → enter → enlarge → remain paused regression case. Parent TypeScript check at this integrated commit passed.
At `1a0b2fe9`, the pending entry intent is also consumed when entry happens in an already undersized window. Standards re-review confirms all three continuation findings resolved statically. Browser verification must still demonstrate the corresponding entry, resize and waiting cases before ticket 03 closes.
## Integrated baseline checks
Parent checks at `1a0b2fe9`: TypeScript and production build pass. The full frontend suite reports 609 tests, 596 passed and 13 existing failures; all 13 names are in the recorded upstream baseline, with no new failures. Full tracked Go packages (`go test -json ./cmd/... ./internal/...`) report the same 107 leaf failures as the recorded baseline, after normalizing one generated supplier-ID suffix; no new failure family or package build error.
An initial `go test ./...` also discovered ignored local verification helpers with multiple `main` functions. Those are outside tracked source; the subsequent command covers every tracked Go package. No company environment was changed for these checks.
## Test-fixture correction and separate follow-up
The ticket-03 claim test initially hit a Mongo composite-key conflict: its captured stage-attempt fixtures used abbreviated IDs, while the real claim path generates deterministic IDs. Repairing only the isolated fixture identities is appropriate. An attempted generic duplicate-key fallback in `MongoStore.UpsertHumanStageAttempt` was rejected and removed before integration: its raw update would bypass supplier deletion fencing and overwrite metadata.
Static review also identified a pre-existing compatibility risk outside this revision: aggregate rejection can create an operation-based attempt ID for a new round (`review_decision_plan.go`), while a later continuation claim supplies no ID and generates a deterministic one (`review_continuation.go`). This deserves a separate reproduction and guarded identity fix; it is not represented as a reproduced failure or silently fixed by this PR. Existing baseline failures remain disclosed separately.
## Final integrated verification
The integrated browser entry suite passed after resetting only the owned local fixtures: quality scenarios covered direct URL, layout preview, explicit claim/continue, refresh, small-window entry and resize, stale intent, waiting controls, and return-to-pool; acceptance covered pool preview, claim, refresh, continue, and small-window recovery. The suite hard-counted continuation starts and found no duplicate start. Pi05's independent matrix also passed both roles in ordinary and focused layouts for F-based problems, deletion, Esc, viewing while unsaved, delayed writes, takeover, view anchors, captions, and decision confirmation. The recovery-only decision script remains a known fixture limitation: the selected item was already submitted and correctly returned 409.

View File

@ -1,6 +1,6 @@
# 审查批注流程修订验证报告(2026-09-23)
> 状态:**整合验证完成(除 03 自动进入浏览器票)**。规格:[.scratch/review-problem-flow/spec.md](../.scratch/review-problem-flow/spec.md);说明书:[review-workspace-guide.zh-CN.md](review-workspace-guide.zh-CN.md)。产品最终基线:根 `1a0b2fe9`(本 worktree HEAD `1a91a004`,含 02 编辑器 + 9c349944/da3c19cc 修复、03 c8aa7300/7310d6a1)。本报告只记录实际运行结果。
> 状态:**整合验证完成**。规格:[.scratch/review-problem-flow/spec.md](../.scratch/review-problem-flow/spec.md);说明书:[review-workspace-guide.zh-CN.md](review-workspace-guide.zh-CN.md)。产品最终基线:根 `1a0b2fe9`(含 02 编辑器 + 9c349944/da3c19cc 修复、03 c8aa7300/7310d6a1)。本报告只记录实际运行结果。
## 环境
@ -24,7 +24,7 @@
| 9 | 迟到写入:处理中 Esc 可退出、不二次发送;迟到成功不抢焦点;迟到失败提供“恢复未保存内容”恢复原文;同操作原样重放返回 200 且不重复建条 | S9;`review-draft-latency.mjs` 两角色 | ✅ PASS |
| 10 | 整体问题 viewAnchor:质检 capture-seconds;终审 slice-seconds、按聚合来源隔离;跨成员点击回查回到原来源画面 | S10 | ✅ PASS(02 修复后) |
| 11 | 无“原始记录 JSON”入口;无“无效动作”旧文案 | S11;另见 review-captions 行 | ✅ PASS |
| 12 | 主动进入自动连续审查一次等 03 行为 | `review-automatic-entry.mjs`(03 拥有) | ⏳ 待 03 浏览器票(父代追加) |
| 12 | 主动进入自动连续审查一次等 03 行为 | `review-automatic-entry.mjs`(真实 API + 浏览器) | ✅ PASS:质检 10 项、终审 5 项;夹具重置后无新增启动 |
| 13 | 正式决定门禁/接管/版本校验不回退 | `review-session.mjs` 两角色、`review-decision-confirmation.mjs`、`review-focus-layout.mjs` | ✅ PASS;recovery 见下行说明 |
| 14 | 1413×615 左/右/双目截图 + 每相机字幕几何断言 | `review-camera-captions.mjs` 四组合 | ✅ PASS + K3 读图 |
@ -56,4 +56,4 @@
- 2026-09-23 准备:说明书、本报告骨架、workflow 重写、旧测试契约更新(提交 6d01e1cf)。
- 2026-09-23 整合运行:上述实测结果;两个 02 缺陷暴露→修复→复测通过;环境处理(Vite allowedHosts、普通 HTTP 主机名、字幕瞬态)。未运行完整套件(主代理已在根完成并照录于此)。
- 待办:03 自动进入浏览器票结果由父代补入;review-decision-recovery 需未来准备未被消耗的本地夹具后重跑。
- 03 入口浏览器票已在整合根版本重跑通过;`review-decision-recovery` 本轮仍因默认夹具已被确认套件消耗而未通过,重复正式决定正确返回 409,未弱化门禁。后续若需重跑,应准备新的未消耗夹具。

View File

@ -133,7 +133,7 @@ try {
// Q2: layout toggle focused -> ordinary -> focused never starts and never
// pauses a (not yet running) queue.
await page.getByRole("button", { name: "返回任务池", exact: true }).first().click();
await page.getByRole("button", { name: /^(返回任务池|返回我的任务)$/ }).first().click();
await waitForPaused(page); // ordinary session-bar toggle
await page.getByRole("button", { name: "进入专注审查", exact: true }).click();
await waitForPaused(page);
@ -237,7 +237,7 @@ try {
await page.setViewportSize(BIG);
await page.waitForTimeout(1200);
assert.equal(starts(calls), 5, "focused shrink/enlarge never auto-resumes");
await page.getByRole("button", { name: "返回任务池", exact: true }).first().click();
await page.getByText(/^(返回任务池|返回我的任务)$/, { exact: true }).first().click();
await waitForPaused(page);
assert.equal(starts(calls), 5, "explicit return-to-pool pauses without new starts");
reports.push("quality focused shrink pauses; layout toggle and return keep rule");
@ -298,11 +298,14 @@ try {
// fallback bar up to this point are entirely real API behavior.
const activeWorkbench = page.getByTestId("capture-annotation-workbench");
await activeWorkbench.getByRole("button", { name: /^(返回我的任务|返回任务池)$/ }).click();
await activeWorkbench.waitFor({ state: "detached" });
await page.getByText("本页可编辑审查意见", { exact: true }).waitFor({ state: "detached" });
// Returning clears the route immediately, while the detail/session cleanup
// follows the next React commit. Wait for both observable states rather
// than asserting during that transition.
await page.waitForFunction(() => !new URL(window.location.href).searchParams.has("taskId"), undefined, {
timeout: 10000,
});
await waitForPaused(page);
await page.getByTestId("review-continuation-toggle").waitFor();
assert.equal(await page.getByText("本页可编辑审查意见", { exact: true }).count(), 0, "no session after return");
let mockGeneration = 100;
const waitingSnapshot = () => ({
generation: ++mockGeneration,
@ -355,6 +358,9 @@ try {
await page.waitForTimeout(1500);
assert.equal(starts(calls), 0, "header preview never auto-starts");
reports.push("acceptance pool browsing and header preview stay paused");
await page.goto(acceptancePath());
await page.getByTestId("human-task-pool-available").click();
await card.waitFor();
// A3: explicit claim auto-starts exactly once for the claimed item.
const claimButton = card.getByRole("button", { name: "领取任务", exact: true });