diff --git a/.scratch/annotation-workspace-layout/README.md b/.scratch/annotation-workspace-layout/README.md index ac55de58..dc6774df 100644 --- a/.scratch/annotation-workspace-layout/README.md +++ b/.scratch/annotation-workspace-layout/README.md @@ -1,6 +1,6 @@ # 专注标注工作页任务索引 -用户已确认拆分并授权发布,共 8 份独立任务。已按编号顺序完成实施及逐票独立审查;最终全功能双轴审查另行记录。 +用户已确认拆分并授权发布,共 8 份独立任务。已按编号顺序完成实施及逐票独立审查;最终全功能双轴审查已完成,见[最终报告](../../docs/verification/annotation-workspace-layout/final-review.md)。 父规格:[专注工作页布局规格](./spec.md)。设计记录:[map.md](./map.md)。已确认的拆分及覆盖矩阵:[ticket-breakdown.md](./ticket-breakdown.md)。布局示意:[preview.html](./preview.html)。 diff --git a/.scratch/annotation-workspace-layout/spec.md b/.scratch/annotation-workspace-layout/spec.md index 42d8a995..0e2b1e12 100644 --- a/.scratch/annotation-workspace-layout/spec.md +++ b/.scratch/annotation-workspace-layout/spec.md @@ -1,8 +1,8 @@ # 人工标注专注工作页布局规格 -Status: ready-for-agent +Status: resolved -设计确认:2026-09-18,四轮边界确认及交互示意均已接受。本文记录已确认的范围;实施票 01–07 已完成并独立审查,08 正在完成整体验收与说明书,最终审核尚未结束。 +设计确认:2026-09-18,四轮边界确认及交互示意均已接受。本文记录已确认的范围;实施票 01–08 已完成并独立审查,整体验收、说明书及最终双轴审核均已交付;覆盖限制与维护建议见[最终报告](../../docs/verification/annotation-workspace-layout/final-review.md)。 ## Problem Statement diff --git a/docs/verification/annotation-workspace-layout/acceptance-results.md b/docs/verification/annotation-workspace-layout/acceptance-results.md index 1d71141e..404f4bd8 100644 --- a/docs/verification/annotation-workspace-layout/acceptance-results.md +++ b/docs/verification/annotation-workspace-layout/acceptance-results.md @@ -1,6 +1,6 @@ # 专注标注工作页整体验收 -日期:2026-09-18。实施票 01–07 已经逐票独立审查通过;本报告为 08 的组合验收,最终审查尚待完成,不代替前置验收。产品范围以[父规格](../../../.scratch/annotation-workspace-layout/spec.md)为准,操作说明见[中文手册](../../annotation-workspace-layout.md)。 +日期:2026-09-18。实施票 01–08 已经逐票独立审查通过;本报告为 08 的组合验收,不代替前置验收。最终[双轴审查](./final-review.md)已完成,无未解决的阻断项。产品范围以[父规格](../../../.scratch/annotation-workspace-layout/spec.md)为准,操作说明见[中文手册](../../annotation-workspace-layout.md)。 所有实际业务写入仅发生在本机 Vite 5173、API 3001、snapshot Mongo 27018 的隔离任务。使用 Microsoft Edge / Playwright,`--no-proxy-server`;没有公司集群、BOS 写入、部署、合并或推送。认证文件、视频、截图、原始日志与隔离浏览器配置均在忽略的 `local-data/` 内,不进入版本库。 diff --git a/docs/verification/annotation-workspace-layout/execution-ledger.md b/docs/verification/annotation-workspace-layout/execution-ledger.md new file mode 100644 index 00000000..c31fef4b --- /dev/null +++ b/docs/verification/annotation-workspace-layout/execution-ledger.md @@ -0,0 +1,112 @@ +# SDD ledger — plan: local-data/verification/annotation-workspace-layout/annotation-workspace-layout-plan.md + +Implementation baseline: ee2e355b. Current branch: feature/local-dev-toolkit. Full final review compares this baseline to final HEAD. + +Ruling: Implement the eight newly published workspace-layout tickets, not repeat the eleven completed keyboard tickets — the user referenced the previous count while asking to execute the current tickets — if wrong, a separately scoped additional task may be needed. + +Ruling: Work in the current clean feature checkout — the explicitly invoked implement skill requires commits on the current branch and this checkout owns the local verification stack — if wrong, later isolation would require moving local commits. + +Ruling: Use ee2e355b as the final code-review fixed point — it is the recorded implementation-start HEAD immediately after all eight tickets were published — if wrong, a broader historical review would need a different baseline. + +## Preflight: individual tickets +| Task | Internal consistency | +|---|---| +| 1 | Published behavior, dependency and browser/API acceptance agree; no source-string tests required. | +| 2 | Published behavior, dependency and browser/API acceptance agree; no source-string tests required. | +| 3 | Published behavior, dependency and browser/API acceptance agree; no source-string tests required. | +| 4 | Published behavior, dependency and browser/API acceptance agree; no source-string tests required. | +| 5 | Published behavior, dependency and browser/API acceptance agree; no source-string tests required. | +| 6 | Published behavior, dependency and browser/API acceptance agree; no source-string tests required. | +| 7 | Published behavior, dependency and browser/API acceptance agree; no source-string tests required. | +| 8 | Published behavior, dependency and browser/API acceptance agree; no source-string tests required. | + +## Preflight: shared surfaces +| Pair | Producer / consumer and finding | +|---|---| +| 1 / 2 | Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found. | +| 1 / 3 | Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found. | +| 1 / 4 | Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found. | +| 1 / 5 | Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found. | +| 1 / 6 | Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found. | +| 1 / 7 | Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found. | +| 1 / 8 | Task 1 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found. | +| 2 / 3 | Task 2 establishes shared video/timeline/editor regions; later changes consume this stable geometry without replacing media/session state. No conflicting requirement found. | +| 2 / 4 | Task 2 establishes shared video/timeline/editor regions; later changes consume this stable geometry without replacing media/session state. No conflicting requirement found. | +| 2 / 5 | Task 2 establishes shared video/timeline/editor regions; later changes consume this stable geometry without replacing media/session state. No conflicting requirement found. | +| 2 / 6 | Task 2 establishes shared video/timeline/editor regions; later changes consume this stable geometry without replacing media/session state. No conflicting requirement found. | +| 2 / 7 | Task 2 establishes shared video/timeline/editor regions; later changes consume this stable geometry without replacing media/session state. No conflicting requirement found. | +| 2 / 8 | Task 2 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found. | +| 3 / 4 | Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found. | +| 3 / 5 | Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found. | +| 3 / 6 | Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found. | +| 3 / 7 | Viewport suspension wraps existing play/continuation boundaries independently of panel contents; delayed results must still reconcile. No conflicting requirement found. | +| 3 / 8 | Task 3 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found. | +| 4 / 5 | Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found. | +| 4 / 6 | Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found. | +| 4 / 7 | Viewport suspension wraps existing play/continuation boundaries independently of panel contents; delayed results must still reconcile. No conflicting requirement found. | +| 4 / 8 | Task 4 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found. | +| 5 / 6 | Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found. | +| 5 / 7 | Viewport suspension wraps existing play/continuation boundaries independently of panel contents; delayed results must still reconcile. No conflicting requirement found. | +| 5 / 8 | Task 5 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found. | +| 6 / 7 | Viewport suspension wraps existing play/continuation boundaries independently of panel contents; delayed results must still reconcile. No conflicting requirement found. | +| 6 / 8 | Task 6 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found. | +| 7 / 8 | Task 7 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found. | + +## Tasks +- Task 1: complete; base ee2e355b, implementation a5753731, fix6acc5803. /root/review_workspace_01 approved scoped re-review. Browser/API+44 focused tests+typecheck/build pass. +- Task 2: complete; base304fbca5, heada3c780e8; /root/review_workspace_02 approved. Five-sizebrowser52tests/typecheck/buildpass; generationversion5 four slices412s. Reviewer actualerror-control hit-testpass; Minor durableassertion to08. Fixturepool01ownedslice. +- Task 3: complete; base9fae45f4, heade462437a; /root/review_workspace_03 approved. Browser5size/N/N/drafts/save409/history/cancel+56tests/type/buildpass. Realannotate-delayedquality_reviewv6 independentlyread. Minor CSSactionrowduplicate970vs882/887 tofinalcleanup. +- Task 4: complete; base2c242df5, implementation94b238d5, fixe95adca8; /root/review_workspace_04 re-review approved. Manybrowser/tinyordinal/crossscopehistory/frozenpointer/API +shell56tests/type/buildpass. Finalmanyannov47,slicev1. +- Task 5: complete; base64397225 impl1de1d85b fix6c76e5d2; /root/review_workspace_05 re-reviewapproved. Inline/longtext+47tests/type/buildpass; focusfixrealbrowserbothdict+typepass. Primaryv61; nativeOSIMEunverifiedlimit. +- Task 6: complete; base db5e6d23 impl ee3d6b16 fix af7df833; /root/review_workspace_06 approved. Corrected real minimum dual410.54x334/single531x432,0occlusion; hidden camera recovery preservesframe/nodes/prefs;79tests/type/build/browserpass. +- Task 7: complete; base39bed0fc, implcb74444e, fix972721e. /root/review_workspace_07 scoped re-review approved; actual browser/API,35tests,type/build pass; owned lookup race fixed with real RED/GREEN. +- Task 8: complete; basec0d344bf, impl89c9e168, fixab89c63a. /root/review_workspace_08 scoped re-review approved. Exactfinalrunner full3taskchain exit0,12zoom,5size,error/dict/reviewercases,54tests/type/build pass within documented limits. + +## Final gates +- Full tests: complete with documented baseline failures; full-suite-results.md +- Standards review: a313b22a reviewed; map violation fixed b83e810e and scoped review approved;3 advisory smells deferred with reasons/costs. +- Spec review: /root/workspace_final_spec no actionable findings, documented coverage limits retained. +- Final report/manual: delivered; task reports,finalreviews,ledger archived under docs/verification/annotation-workspace-layout. + +Task 1 fix round 1: reviewer requests behavioral stop-after-current preservation across toggles; /root/workspace_01 assigned scoped test addition. Controller independently verified baseline tag54a35afa and complete bundle (git bundle verify okay). + +Ruling: Keep proportional timeline entries within each bounded four-item page and provide exact ordinal search/selection — the spec requires bounded accessible navigation, while existing duration/drag mapping must remain meaningful — if wrong, equal-width list cards would need an additional presentation surface; tiny entries must still be selectable through search and editable in the fixed editor. + +Task 4 fix round 1: /root/review_workspace_04 found twoImportant: destination scope resets crossslice history target; pageedge drag clamp/rescale drift. /root/workspace_04 assigned reproduce/fix/browserregression before nextticket. + +Task 4 fix round 1 delivered e95adca8, re-review /root/review_workspace_04. Both actualbrowserREDs reproduced; crossscope nulleditorpage4 and frozenpointerbothdirections/samexstable pass; sharedframepublicAPI persistence verified. manyannov47, slicev1. Existing56tests/type/build/shell+five-size pass. + +Task 5 fix round 1: reviewer reproduced Tabfromdictpager tooutsideUndo followedEsc leavesdictopen andglobalkeysblocked. /root/workspace_05 assigned focusedfix+bothdict outsidefocus browserregression. + +Task5fixround1 delivered6c76e5d2, /root/review_workspace_05 scopedre-review. BothdictTab/outsideclick→EscSpace noPOST/draftloss/geometrychange; selectiontextfocusretained; typecheckpass. + +Native OS IME supplemental attempt: separate headed Edge draft-only window prepared; cua.getApp tool blocked for an abnormally long time and returned unrelated existing browser window. No native typing/input-source changes were performed. Own runner stopped; its browser had already closed. No native IME pass claimed. Avoid further desktop tool calls for this attempt. + +Task6 fixround1: reviewer identifies inspection progress overlay atvideo bottom and original camera flags trapping hidden camera on return focused. /root/workspace_06 assigned reproduce/fix, realpicture occlusion checks and successful screenshots. + +Task6 fixround1 delivered af7df833, scopedreview /root/review_workspace_06. Corrected single531x432 with reserved28px progress and0occlusion; nonzero frame6 original hide-left/right recovery retains nodes/draft/prefs/sync;79tests/type/build/browserpass. Rootviewed successfulleft/right screenshots. +Browser zoom readiness independently proven in isolated persistent Edge profile via actual setDefaultZoom; see ignored zoom-readiness.md. No user browser profile modified. + +Final verification started for unchanged backend surfaces: full Go source packages, Python in .venv, Rust offline. Logs and exit codes in local-data/verification/annotation-workspace-layout/final-checks. Sessions Go60933/Python48131/Rust84597. Frontend suite awaits Task07 product completion. +Additional create-once local fixtures: workspace-viewport-unknown (two unowned ready slices), workspace-viewport-generation (owned slice-primary), workspace-full-workflow (owned slice-primary plus two ready pool tasks, reserved for Task08). No previous task/evidence reset. + +Root final backend checks completed: Go13 packages pass/2 no tests/60 existing API failures exact name set; Python648pass25fail3skip, no new failures vs prior25 (old json_to_csv cache failures absent); Rust25tests/lint/release pass; Go builds/script syntax pass; Go formatting existing single-file debt; K8s client discovery localhost8080 blocked,22 local YAML structures pass. Full-suite-status.md and final-checks comparison JSON retain evidence. Backup tag and complete bundle reverified successfully. + +Task07 implemented cb74444e; review package39bed0fc..cb74444e dispatched /root/review_workspace_07. Root visually checked actual1100×600 pause prompt, screenshot root-pause-visual.png; no task writes. Full frontend initial578/568/10:9baseline plusobsolete dictionary portal source assertion, assigned08 behavioral verification/retirement. Fullformat53warnings:Layout.tsx only touchedwarning, assigned08 formatting;52untoucheddebt. + +Task07 fix round1 dispatched /root/workspace_07: /root/review_workspace_07 actual browser RED delayed owned-pool GET switches completed annotate-primary to owned pool-01 while viewport suspended (no writes). Root agrees Important: owned lookup is not an allocated claim; defer opening next owned task until explicit Continue, retaining handoff intent. Existing in-flight actual claim reconciliation unchanged. Reviewer final report pending. + +Task07 fix1 delivered972721e; scoped re-review /root/review_workspace_07. Real pool and summary delays independently RED→GREEN, both continuous/resume-only;0writes/claims,versions3/2 unchanged. Prior viewport suite/type/build pass after fix. + +Task08 runtime assistance: fresh workspace-full-workflow2 created after runner seek-timing consumed initial fixtures; prior generated/submitted effects retained. Added two new local reviewer users with correct global quality_reviewer / acceptance_reviewer roles and copied12project memberships each, since snapshot fanyu-full-qc/acceptance are globally annotators. New ignored qc-reviewer-auth.json / acceptance-reviewer-auth.json mode0600; existing users/tasks untouched. Original QA/acceptance login200 but route redirects; opsadmin single known-password login401, no password changes. + +Task08 implementation89c9e168, review /root/review_workspace_08. Important committed test-runner cleanup error independently confirmed: wrong annotate assertion before mutation, loop closed early and out-of-scope names. Fixround1 /root/workspace_08; fresh full-workflow4 prepared for runtimeRED(no writes,verifyv1) then finalcandidate completeGREEN. Earlier authoritative3-task evidence retained, never reset. Root archive initial20reports prepared; refresh after fixes/reviews. + +Task08 fix1 runtime investigation: finalcandidate runner hash a20779d7c1187106f1f01e441574094bc19bc507964e82f9a78f5b8a14fa9f56; committedRED on fresh4 beforewrites verifiedv1. Generation later interrupted despite unchangedproductsource. Actual controlled Markdown append/restore each emitted ViteWSfull-reload→pagehide/navigation→explicitrecovery,0POST; rootonlydocwrites caused interference. API99553/Vite97816 unchanged, no restart. Coordinated ALL-file-write freeze; freshfull-workflow5 exactcandidate complete exit0,3generate/3save/3handoff/2successclaims/1empty, primaryv8 pools v9QA. Freeze ended afterexit; previousfull4v4 preserved. Fixcommit/report pending. + +Ruling: Defer shared browser reachability-helper extraction — current independent acceptance runners passed and extraction would broaden final test changes without a product defect — if wrong, duplicated helpers may drift and need coordinated future updates. +Ruling: Defer centralized four-entry pagination policy — both current consumers agree on the accepted fixed page size, with actual cross-page evidence — if wrong, a future page-size change could miss a consumer until refactoring. +Ruling: Defer shared viewport-size predicate extraction — all current checks match and fresh dispatch-time reads protect races; no behavior defect was found — if wrong, a future minimum-size change could diverge until the checks are centralized. +Final whole-feature fixed HEADa313b22a, Standards1docviolation+3lowheuristics,Spec0. /root/workspace_final_docs_fix assigned sole documented violation. + +Final root APIreadback: full-workflow5 primaryv8, pool02/pool01v9, allquality_review/ready. FinalSpec0,Standardsdocviolationclosed+3nonblockingadvisories. Localfeaturebranch preserved; no push/deploy/merge. Plan execution complete. diff --git a/docs/verification/annotation-workspace-layout/execution-record.md b/docs/verification/annotation-workspace-layout/execution-record.md index 5869769d..63f0ce26 100644 --- a/docs/verification/annotation-workspace-layout/execution-record.md +++ b/docs/verification/annotation-workspace-layout/execution-record.md @@ -24,6 +24,16 @@ | 最终全量代码审查以 ee2e355b 为固定点 | 这是 8 张票发布后的实施起点 | 若要审查更早历史,需要另选更早基线扩大审查范围 | | 每页最多 4 项的时间轴仍保持时长比例,并提供精确序号查找 | 既满足有限空间下访问全部条目,也保留时间长度与拖动映射的意义 | 若改成等宽卡片,需要增加另一种呈现;极短条目仍必须可搜索并在固定编辑区修改 | +## 最终审查的维护建议处理 + +三项均为低优先级的代码结构判断,不是已发现的功能故障;本轮保留现状: + +| 裁决 | 原因 | 后续代价 | +| --- | --- | --- | +| 暂不抽取浏览器控件可达性公共测试助手 | 各场景已有独立的成功验收;交付前抽取会扩大测试代码变动 | 重复助手可能漂移,未来修改需同步或再抽取 | +| 暂不统一每页 4 项的常量入口 | 当前两处值一致,跨页导航已实测 | 未来调整页大小时可能漏改一处,应届时集中策略 | +| 暂不抽取小窗口判断公共谓词 | 当前阈值一致,并保留请求发出时读取最新窗口大小的竞态保护 | 未来改变支持底线时需要同步修改或集中判断 | + ## 已发现并修复的主要问题 - 跨切片重做后目标页被重置;页边缘拖动被当前页限制且移动比例漂移。 @@ -34,8 +44,10 @@ - 大窗口中切片错误提示遮住逐帧按钮。 - 最终验收脚本在清理临时分支时破坏循环作用域,语法检查无法发现;独立审核发现后要求以最终脚本完整重跑。 -每项修复均有针对性的真实浏览器回归或持久化 API 回读,详细证据将在最终验收与审查报告中链接。完整测试中的既有失败单列于 [全仓测试结果](./full-suite-results.md)。 +产品问题均有针对性的真实浏览器回归或持久化 API 回读;验收脚本修正版完成一轮完整真实流程。详细证据见[整体验收](./acceptance-results.md)与[最终审查](./final-review.md)。完整测试中的既有失败单列于 [全仓测试结果](./full-suite-results.md)。 ## 最终关口 -全部 8 票已独立审核通过;全功能 Standards/Spec 两轴审核尚待完成。逐票记录见[归档索引](./task-evidence/README.md)。 +全部 8 票已独立审核通过;全功能 Standards/Spec 两轴审核完成,文档问题经 b83e810e 修复并复审关闭。3 项低优先级维护建议按上表记录;没有未解决的阻断项。逐票记录见[归档索引](./task-evidence/README.md),最终结论见[双轴审查](./final-review.md)。 + +主任务再次通过公共 API 回读最终隔离项目:slice-primary 为 v8,pool-02 与 pool-01 为 v9,三者均为 quality_review / ready,与最终浏览器日志一致。所有改动保留在本地 feature/local-dev-toolkit;没有推送、合并或部署。 diff --git a/docs/verification/annotation-workspace-layout/final-docs-fix-report.md b/docs/verification/annotation-workspace-layout/final-docs-fix-report.md new file mode 100644 index 00000000..2364edba --- /dev/null +++ b/docs/verification/annotation-workspace-layout/final-docs-fix-report.md @@ -0,0 +1,24 @@ +# Final documentation fix report + +## Commit + +`b83e810e` — `📋 Record resolved annotation workspace decisions` + +The commit contains only `.scratch/annotation-workspace-layout/map.md`. + +## Changes + +- Marked tickets 01–08 as resolved and independently reviewed. +- Added one linked, concise result for each ticket, including its implementation and review-fix commit where applicable. +- Linked the operator manual, combined acceptance report, full-suite result, and execution record. +- Preserved the design and preview observations while labeling them as historical, and replaced obsolete present-tense claims about implementation, browser verification, the original workbench, and local 5173. +- Recorded the retained limits: native OS IME, physical display/OS-scale coverage, zero final-acceptance media members, and no push, deployment, or QA approval. + +## Checks + +- `git diff --check` passed before the commit. +- A local Markdown-link check verified all 18 links in `map.md` resolve. +- `git diff --cached --check` passed immediately before the commit. +- No browser run, company-service access, push, deployment, or QA approval was performed. + +`docs/verification/annotation-workspace-layout/execution-record.md` was already modified in the working tree and was left unstaged and uncommitted. diff --git a/docs/verification/annotation-workspace-layout/final-review.md b/docs/verification/annotation-workspace-layout/final-review.md new file mode 100644 index 00000000..83885f5a --- /dev/null +++ b/docs/verification/annotation-workspace-layout/final-review.md @@ -0,0 +1,15 @@ +# 最终双轴审查结果 + +固定基线 `ee2e355ba1838578b0611628bc764abbbeec6eef`,完整功能审查 HEAD 为 `a313b22a`。两位独立 reviewer 并行审查 Standards 与 Spec,不以逐票通过代替组合审查。 + +## Standards + +[原始规范审查](./final-standards-review.md)提出 1 项文档规范问题及 3 项低优先级维护判断。设计 map 的当前状态及 8 票结果链接已在 `b83e810e` 修复,[针对性复审](./final-standards-fix-review.md)确认问题关闭,18 个链接与 8 个已解决任务引用有效。没有未解决的规范违规或生产代码规范问题。 + +3 项维护建议仍然保留:抽取浏览器可达性测试助手、集中每页 4 项的策略、集中小窗口阈值判断。它们不是功能缺陷,未伪称已修复;保留现状的原因与后续代价见[执行裁决](./execution-record.md)。 + +## Spec + +[原始需求审查](./final-spec-review.md)没有发现可确认的缺失实现、范围扩张或错误行为。reviewer 独立核对了最终脚本哈希与三条完整业务链路日志。原生 OS 输入法、全部物理设备/系统缩放及本地缺失验收媒体仍是明示覆盖限制。 + +两轴分别结论:Standards 的 1 项违规已关闭,剩余 3 项低优先级维护建议;Spec 为 0 项可确认的问题。没有未解决的阻断项,也没有全仓测试全绿、质检通过或已部署的声明。 diff --git a/docs/verification/annotation-workspace-layout/final-spec-review.md b/docs/verification/annotation-workspace-layout/final-spec-review.md new file mode 100644 index 00000000..58c898da --- /dev/null +++ b/docs/verification/annotation-workspace-layout/final-spec-review.md @@ -0,0 +1,17 @@ +# Final whole-feature Spec review + +Reviewed `ee2e355ba1838578b0611628bc764abbbeec6eef...a313b22ae824208feb9fc6ac30103b36c3325e65` against the layout specification, tickets 01–08, retained keyboard contract, CONTEXT.md and ADR-0001. Read the production diff, relevant browser runners, acceptance/manual/execution records and task evidence. No product, index or HEAD mutations; no browser or broad-suite rerun. + +**Result: no confirmed actionable Spec findings.** + +- **Missing/partial implementation:** none established. The shared mounted editor/session/media, account-local preference, original fallback, bounded timelines/dictionaries, fixed actions, camera inspection and undersized-window recovery implement the requested boundaries. Pending claim reconciliation remains distinct from deferred owned-task reads; explicit viewport continuation preserves stop/hard-pause intent. +- **Unrequested behavior/scope creep:** none established. No backend/schema/allocation changes; reviewer layout is excluded. Four-item proportional timelines and ordinal lookup follow the recorded execution decision. +- **Implemented-but-wrong behavior:** none established after independently checking interactions among history reveal, layout switching, media visibility, viewport suspension, in-flight responses and post-handoff continuation. + +**Coverage limits, not proven defects:** + +- Spec L09 says “Chinese input composition and native text undo continue to work” (`.scratch/annotation-workspace-layout/spec.md:130`). Native cut/undo and synthetic composition checks exist; native OS IME remains unverified, explicitly recorded at `docs/verification/annotation-workspace-layout/acceptance-results.md:25`. +- Spec L03 requests representative windows with “100%, 125% and 150% browser zoom” (`spec.md:124`). Twelve actual browser-window/zoom cases satisfy that matrix; physical monitor/OS scaling coverage remains limited (`acceptance-results.md:19`). +- L16 original/reviewer isolation has real panel/style evidence, but the old acceptance artifact exposes zero media members. This does not establish loaded-media or end-to-end acceptance success; the report explicitly limits that claim. + +Independent corroboration: final runner SHA-256 matches the documented `a20779d7…fa9f56`; raw `task08-runner-review-green5.log` records three generation/save/handoff cycles, two successful claims and one empty claim. Earlier interruptions remain disclosed. Baseline frontend/Go/Python failures are not new feature defects; no full-suite-green, quality approval or deployment claim is warranted. diff --git a/docs/verification/annotation-workspace-layout/final-standards-fix-review.md b/docs/verification/annotation-workspace-layout/final-standards-fix-review.md new file mode 100644 index 00000000..f6506c04 --- /dev/null +++ b/docs/verification/annotation-workspace-layout/final-standards-fix-review.md @@ -0,0 +1,11 @@ +# Standards correction review + +Reviewed only documentation correction `b83e810e` and its report. + +**Documented violation closed.** `.scratch/annotation-workspace-layout/map.md:34–41` now contains a linked resolution summary for each of tickets 01–08 within Decisions-so-far, satisfying `docs/agents/issue-tracker.md:31–32`. Current implementation status is explicit at lines 5 and 33; earlier design observations are clearly historical at lines 13, 44, 61, 65 and 81–83. Coverage limitations remain explicit at line 42. No residual finding in this correction. + +Read-only verification confirmed all 18 local Markdown links resolve and all 8 tickets linked from Decisions-so-far contain `Status: resolved` and `## Answer`. No browser or test suites rerun; no Git mutations. + +**Three low-priority advisories remain deferred, not fixed:** duplicated browser reachability helpers; page-size policy duplicated between pagination and the workbench; repeated viewport threshold predicates. The execution record documents separate reasons and future maintenance costs. These remain judgment calls, not documented-standard violations or demonstrated current functional failures. + +Final Standards disposition: 0 open documented-standard violations; 3 deferred low-priority smell advisories. This scoped re-review does not replace the independent Spec-axis assessment. diff --git a/docs/verification/annotation-workspace-layout/final-standards-review.md b/docs/verification/annotation-workspace-layout/final-standards-review.md new file mode 100644 index 00000000..bf46a0a8 --- /dev/null +++ b/docs/verification/annotation-workspace-layout/final-standards-review.md @@ -0,0 +1,15 @@ +# Standards review + +Reviewed `git diff ee2e355ba1838578b0611628bc764abbbeec6eef...a313b22a`, including production, browser-test, ticket and evidence changes. No browser or broad test suites rerun. Findings below distinguish documented requirements from maintainability judgments. + +**Documented-standard violation** + +- **Resolution map omitted.** The new resolved-ticket hunks, e.g. `.scratch/annotation-workspace-layout/issues/01-focused-view-and-legacy-switch.md:33` and `issues/08-full-workflow-acceptance-and-guide.md:31`, add Answers and link *to* the map, but add no resolution summaries or ticket links *in* its Decisions-so-far section. `docs/agents/issue-tracker.md:31–32` explicitly requires all three resolution steps. `.scratch/annotation-workspace-layout/map.md:29–46` remains unchanged and still ends “没有开始改动产品代码”. Add concise resolution summaries and links there, and distinguish historical design statements from current implementation status. This is a documentation/workflow issue; no production standards breach found. + +**Smell baseline — judgment calls, low priority** + +- **Possible Duplicated Code:** `tests/browser/annotation-workspace-annotation.mjs:26`, `annotation-workspace-navigation.mjs:36`, `annotation-workspace-dictionaries.mjs:25` and `annotation-workspace-camera-inspection.mjs:62` copy viewport/hit-test assertions, including `e.contains(document.elementFromPoint(r.x + r.width / 2, r.y + r.height / 2))`. Copies already differ in positive-width/height checks. Share the reachability measurement/assertion so acceptance improvements apply consistently; retain scenario-specific assertions locally. +- **Possible Shotgun Surgery:** `src/components/TimelinePageNavigation.tsx:5` defines `const pageSize = 4`, while `src/components/CaptureAnnotationWorkbench.tsx:777` independently uses `pageContaining(slices, slice.id, 4)`. Changing the list policy requires coordinated edits outside its owner. Expose a reveal-by-ID operation on the pagination hook, or share the policy constant. +- **Possible Duplicated Code:** `src/pages/AnnotationOperations.tsx:522,529,533` repeats the focused-layout minimum predicate, including `window.innerWidth < 1280 || window.innerHeight < 640`. Extract the dimension predicate/constants while retaining fresh window reads at dispatch boundaries; otherwise render, suspension and dispatch eligibility can drift during future threshold changes. + +Totals: 1 documented-standard violation; 3 low-priority smell judgments. No tooling-enforced findings or unrelated baseline cleanup requested. diff --git a/docs/verification/annotation-workspace-layout/full-suite-results.md b/docs/verification/annotation-workspace-layout/full-suite-results.md index 65dc19bc..57ba0d3f 100644 --- a/docs/verification/annotation-workspace-layout/full-suite-results.md +++ b/docs/verification/annotation-workspace-layout/full-suite-results.md @@ -1,6 +1,6 @@ # 全仓测试结果 -本报告记录专注工作页实现的完整测试,基线为 `ee2e355b`。全流程验收仍在执行;本报告保留完整测试的原始结果,并将后续局部复验分开列出,不以既有失败掩盖新增回归。 +本报告记录专注工作页实现的完整测试,基线为 `ee2e355b`。全流程验收与最终双轴审查已完成。本报告保留完整测试的原始结果,并将后续局部复验分开列出,不以既有失败掩盖新增回归。 | 检查 | 当前结果 | 对照说明 | | --- | --- | --- |