Contract step of the account-phone-login expand-migrate-contract rollout.
Phone is now the sole account identifier end to end:
- domain.UserRecord/CreateUserInput: delete Email, drop Phone's omitempty
(required going forward).
- store: delete email_unique Mongo index; phone_unique is now non-sparse
(unique, not sparse) since every account creation path requires a phone.
Delete FindUserByEmail, ensureUserEmailAvailableLocked, and
ErrDuplicateUserEmail (confirmed dead via grep - all real call sites were
already migrated to the *Phone equivalents by tickets 01-03). Mongo
duplicate-key fallback and the account-mutation-guard's stale-write
snapshot/filter now key off Phone instead of Email.
- api: drop the now-impossible ErrDuplicateUserEmail branch in
renderUserMutationError. The account-hierarchy audit endpoint and the
supplier-deletion receipt struct both switch their identifying field from
Email to Phone, since both are populated fresh from current account state
(not frozen historical snapshots) - continuing to read a "email" key would
silently go blank for every account created after this change.
- frontend: src/types.ts User.phone is now required (email removed);
AccountHierarchyIssue.email -> .phone in services/api/users.ts and
pages/Users.tsx to match the backend audit endpoint's renamed field.
- Rewrote the wide blast radius of Go test fixtures that constructed users
by email across internal/api/*_test.go and internal/store/*_test.go,
including the two dedicated memory-store uniqueness tests (merged into
phone-only equivalents) and several opt-in "live" acceptance-fixture
tests gated behind env vars for real Fanyu deployments.
Repo-wide grep of Go and TS/TSX for Email/email/邮箱 turned up no remaining
account-identifier references outside of a few harmless test-only cosmetic
labels (e.g. "Email Tenant" as an org display name in a seed helper) and
assertions that explicitly check "邮箱" text is absent from API responses.
go build/vet clean. go test ./internal/api/... ./internal/store/...
./internal/domain/... : 75 failures, identical test names to the
pre-ticket-05 baseline (diffed against a throwaway worktree at the prior
tip). npm run lint:web (tsc --noEmit) clean. npm run test:frontend:
599/586/13, matching the stated baseline exactly.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- handleAuthLogin now authenticates via store.FindUserByPhone instead of
FindUserByEmail; the login/bootstrap-super-admin request payload field
is now `phone`. Old email addresses are no longer valid login credentials.
- bootstrap-super-admin now validates phone format (isValidChinaMobilePhone)
instead of net/mail.ParseAddress; net/mail is fully removed from
internal/api.
- Same-class gap fix: handleAdminOrganizationUsersCreate (the legacy
per-organization admin endpoint, not touched by ticket 02) still created
users by email only, which would have left them unable to log in under
the new phone-only login. Switched it to phone validation/uniqueness too,
and removed the now-dead normalizeUserInput/validateUserEmailAvailable
helpers.
- Frontend: authApi.login, UserContext's login signature, and
UserBootstrapPanel's submit handler now send `phone` instead of `email`
(the form/labels were already phone-based from ticket 04).
- Updated ~20 Go test files whose fixtures/helpers logged in via
user.Email; adminCreateUser/loginSession/bootstrapSuperAdminSession now
work in terms of phone (deterministically derived from existing
email-shaped test identities via testPhoneFromSeed, to avoid rewriting
every call site). Added internal/api/auth_phone_login_test.go covering
phone login success/failure and old-email rejection.
go test ./internal/api/... and npm run test:frontend match their
pre-ticket baselines exactly (75 Go failures / 599 frontend tests with
586 pass, 13 fail) by failing test name, not just count.
Admin account-management UI and API now validate/enforce phone instead
of email on create/edit. Production Fanyu data migration deferred to
deployment time per spec decision 7 — not executed here.
Merge conflict resolution + gap fixes found while reconciling 02 and 04:
- src/types.ts / UserContext.tsx / users.ts: kept Email required + Phone
optional (matches current migration state — login still uses email
until ticket 03); createUser/updateCurrentUser signatures reconciled
to the versions that are actually wired to real backend behavior.
- internal/api/project_members.go: projectMemberView never exposed
Phone (ticket 04's frontend rename to userPhone had nothing to read).
Renamed UserEmail->UserPhone and populated it from user.Phone.
- internal/store/memory.go + mongo.go: ListProjectMemberUsers's field
whitelist projection dropped Phone entirely (pre-existed the Phone
field, never updated) — same root cause as project_members.go, one
layer down.
- internal/api/auth.go: handleCurrentUserProfileUpdate/
currentUserProfilePatch still only supported Email; self-service
profile edit silently no-opped on phone. Wired to phone validation
mirroring the ticket-02 admin create/edit pattern.
- Updated 3 tests whose expectations depended on the self-profile-update
gap above (TestSessionAuthTenantIsolationAndRolePermissions,
TestUserEmailUniquenessValidation, TestProjectMemberDisplayScopedBatch)
to phone; verified full internal/api suite back to the 75-failure
baseline (byte-identical failing test names) and frontend suite at
599/586/13 baseline.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Wires the Phone field/validation/uniqueness helpers added in ticket 01
into the account-management create/edit path, per the
account-phone-login migration spec.
Backend (internal/api/server.go, internal/domain/types.go,
internal/store/{memory,mongo}.go, internal/api/store_errors.go):
- handleUsersCreate/handleUsersUpdate now validate and enforce phone
(^1[3-9]\d{9}$, uniqueness) instead of email; duplicate-phone errors
return field "phone" with no "邮箱" wording.
- CreateUserInput gained a Phone field, wired through both store
backends' CreateUser.
- Email remains on UserRecord (still used by login/self-profile,
untouched here) but is no longer required/validated on account
create/edit.
Frontend (src/pages/Users.tsx, src/services/api/users.ts,
src/types.ts, src/context/UserContext.tsx):
- Account management create/edit form, search box, and table column
switch from email to phone (type="tel", client-side
^1[3-9]\d{9}$ validation, Chinese labels updated to "手机号").
- User type gained an optional `phone` field; usersApi.create's
payload field renamed from email to phone to match.
- UserContext's createUser helper type/impl updated to match (dead
code today, unused by any caller, but kept building); login/session
bootstrap logic in UserContext.tsx is untouched.
Explicitly out of scope, per the research notes' scope boundary and
spec decision 7: the real "存量账号迁移" (migrating Fanyu's live
accounts to real phone numbers) is a human-supervised, deployment-time
operation, not something this session executed. No production Fanyu
Mongo/kubeconfig was touched. This ticket only makes the admin
UI/API *capable* of setting a phone number on new or existing
accounts, verified against the in-memory store and local fixtures.
Also left untouched, per scope: login page/flow, auth.ts,
UserContext's login/session logic (ticket 03); Sidebar.tsx,
ProjectMembersPanel.tsx, UserBootstrapPanel.tsx (ticket 04).
Verified: go build ./... clean; go vet ./... clean; gofmt clean on
touched files; go test ./internal/api/... and ./internal/store/...
produce the exact same 75 pre-existing failing test names as the
ticket-01 baseline (only two account/edit-adjacent tests updated to
assert phone instead of email behavior, plus a new
TestUserPhoneValidationAndUniquenessOnCreateAndEdit covering
create/edit phone format + uniqueness + role/supplier preservation);
npm run lint:web (tsc --noEmit) clean; node --test
tests/frontend/*.test.mjs matches the pre-existing baseline exactly
(599 tests, 586 pass, 13 fail, identical failing test names).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>