package api import ( "context" "droboticflow/internal/domain" "fmt" "strings" "testing" ) type finalizeHeadBrowser struct { *resumableObjectSyncBrowser heads int } func (b *finalizeHeadBrowser) GetObjectSummary(ctx context.Context, bucket, key string) (domain.ObjectStorageObjectSummary, error) { b.heads++ return b.fakeObjectStorageBrowser.GetObjectSummary(ctx, bucket, key) } func TestDirectCompletionRegistersWithOneHeadAndRetriesWithoutHead(t *testing.T) { data, _, session, request := cancellationRaceFixture(t, domain.ObjectSyncSessionRunning) browser := &finalizeHeadBrowser{resumableObjectSyncBrowser: &resumableObjectSyncBrowser{fakeObjectStorageBrowser: newFakeObjectStorageBrowser()}} original := storageConnectionBrowserResolver storageConnectionBrowserResolver = func(context.Context, *domain.StorageConnectionRecord) (objectStorageBrowser, func(), error) { return browser, func() {}, nil } t.Cleanup(func() { storageConnectionBrowserResolver = original }) lease, ok, e := data.AcquireObjectSyncLease(t.Context(), domain.ObjectSyncLeaseRecord{ID: "lease", ResourceHash: "resource", OrganizationID: session.OrganizationID, OwnerSessionID: session.ID, OwnerItemID: "i"}, objectSyncLeaseTTL) if e != nil || !ok { t.Fatal(e) } item := domain.ObjectSyncItemRecord{ID: "i", OrganizationID: session.OrganizationID, SessionID: session.ID, Action: "create", UploadMode: "direct", Status: domain.ObjectSyncItemUploading, TargetKey: "formal/file", StagingKey: "formal/file", SizeBytes: 4, MD5Sum: strings.Repeat("a", 32), LeaseID: lease.ID, FencingToken: lease.FencingToken} data.UpsertObjectSyncItems(t.Context(), []domain.ObjectSyncItemRecord{item}) browser.objects["fixture|formal/file"] = domain.ObjectStorageObjectSummary{Bucket: "fixture", Key: item.TargetKey, SizeBytes: 4, ETag: "owned", VersionID: "v", Metadata: map[string]any{"drosync-session": session.ID, "drosync-item": item.ID, "drosync-md5sum": item.MD5Sum, "drosync-fence": fmt.Sprint(item.FencingToken)}} for _, key := range []string{"complete-first", "complete-repeat"} { r := request("items/i/uploads/direct/complete", map[string]any{}, key) if r.Code != 200 { t.Fatalf("complete %d %s", r.Code, r.Body.String()) } } got, _ := data.GetObjectSyncItem(t.Context(), item.ID) if got.Status != domain.ObjectSyncItemCommitted || got.CommittedVersion.VersionID != "v" || browser.heads != 1 { t.Fatalf("status=%s version=%s heads=%d", got.Status, got.CommittedVersion.VersionID, browser.heads) } r := request("items/i/commit", map[string]any{}, "commit-replay") if r.Code != 202 || browser.heads != 1 { t.Fatal("commit replay failed") } }