droboticflow/internal/api/acceptance_misreports_test.go

61 lines
2.6 KiB
Go

package api
import (
"droboticflow/internal/domain"
"encoding/json"
"testing"
)
func TestAcceptanceMisreportsOwnerRevocationAndVersionChecks(t *testing.T) {
f := newCombinedDraftFixture(t)
item := f.item
item.CurrentStageID = domain.FanyuV58StageQualityReview
item.Status = domain.HumanItemClaimed
item.AssignedUserID = f.reviewer.ID
item.ReviewRound = 2
if err := f.store.UpsertHumanItem(f.ctx, item); err != nil {
t.Fatal(err)
}
op := domain.ReviewOperation{ID: "accept-reject", OrganizationID: item.OrganizationID, ProjectID: item.ProjectID, ItemID: "aggregate", StageID: "prepackage_acceptance", Status: "completed", Decision: "rejected", UserID: "acceptor", SourceItemIDs: []string{item.ID}, Draft: domain.ReviewDraft{Problems: []domain.ReviewProblem{{ID: "problem", SourceItemID: item.ID, Scope: "slice", Text: "bad"}, {ID: "other", SourceItemID: "other-item", Scope: "slice"}}}}
if ok, err := f.store.CompareAndSwapReviewOperation(f.ctx, op, 0); err != nil || !ok {
t.Fatalf("seed op %v %v", ok, err)
}
if err := f.store.AppendHumanEvent(f.ctx, domain.HumanEventRecord{ID: "reject-event", OrganizationID: item.OrganizationID, ItemID: item.ID, Round: 2, EventType: "aggregate_acceptance_rejected", Payload: map[string]any{"operationId": op.ID}}); err != nil {
t.Fatal(err)
}
path := "/api/human-items/" + item.ID + "/acceptance-misreports"
r := f.request("GET", path, f.reviewer, nil)
if r.Code != 200 {
t.Fatal(r.Code, r.Body.String())
}
var got struct{ Problems []domain.ReviewProblem }
_ = json.Unmarshal(r.Body.Bytes(), &got)
if len(got.Problems) != 1 {
t.Fatal("foreign source leaked")
}
payload := map[string]any{"operationId": op.ID, "itemVersion": item.Version, "version": 0, "skippedOpinionIds": []string{"problem"}}
if r = f.request("PUT", path, f.annotator, payload); r.Code != 403 {
t.Fatal("annotator can mutate acceptance handling", r.Code)
}
if r = f.request("PUT", path, f.reviewer, payload); r.Code != 200 {
t.Fatal(r.Code, r.Body.String())
}
if r = f.request("PUT", path, f.reviewer, payload); r.Code != 409 {
t.Fatal("stale CAS accepted")
}
payload["version"] = 1
payload["skippedOpinionIds"] = []string{}
if r = f.request("PUT", path, f.reviewer, payload); r.Code != 200 {
t.Fatal("revoke", r.Body.String())
}
h, _ := f.store.GetReworkHandling(f.ctx, item.ID+":acceptance-handling:"+op.ID)
if h == nil || len(h.SkippedOpinionIDs) != 0 || h.OperationID != op.ID {
t.Fatal("revocation not persisted")
}
item.CurrentStageID = "annotation_combined"
_ = f.store.UpsertHumanItem(f.ctx, item)
if r = f.request("PUT", path, f.reviewer, payload); r.Code != 409 {
t.Fatal("stage change not fenced", r.Code)
}
}