droboticflow/internal/api/acceptance_workspace_test.go

44 lines
1.8 KiB
Go

package api
import (
"context"
"droboticflow/internal/domain"
"droboticflow/internal/store"
"encoding/json"
"strings"
"testing"
)
func TestAcceptanceReviewSummariesScopeAndAnonymity(t *testing.T) {
ctx := context.Background()
db := store.NewMemoryStore()
s := &server{store: db}
task := domain.AnnotationTaskRecord{ID: "task-a", OrganizationID: "org-a", ProjectID: "project-a", WorkflowID: "workflow-a", RunID: "run-a"}
if err := db.UpsertAnnotationTask(ctx, task); err != nil {
t.Fatal(err)
}
review := domain.AnnotationReviewRecord{ID: "review-a", OrganizationID: "org-a", TaskID: task.ID, Stage: domain.AnnotationReviewStageQuality, Decision: domain.AnnotationReviewDecision("approved"), ReviewerUserID: "private-reviewer", CreatedAt: "2026-09-08T10:00:00Z"}
if err := db.UpsertAnnotationReview(ctx, review); err != nil {
t.Fatal(err)
}
item := domain.HumanItemRecord{OrganizationID: "org-a", ProjectID: "project-a", WorkflowID: "workflow-a", CurrentStageID: fanyuV5PrePackageAcceptanceStageID, UpdatedAt: "2026-09-08T11:00:00Z", Subject: domain.HumanSubjectRef{Payload: map[string]any{"items": []map[string]any{{"taskId": task.ID, "runId": "run-a"}}}}}
summaries, err := s.acceptanceReviewSummaries(ctx, item)
if err != nil || len(summaries) != 1 {
t.Fatalf("summaries=%v err=%v", summaries, err)
}
raw, _ := json.Marshal(summaries)
if strings.Contains(string(raw), "private-reviewer") || strings.Contains(string(raw), "reviewerUserId") {
t.Fatal("identity leaked")
}
item.ProjectID = "other-project"
if _, err = s.acceptanceReviewSummaries(ctx, item); err == nil {
t.Fatal("cross-project task accepted")
}
item.ProjectID = "project-a"
item.UpdatedAt = "2026-09-08T09:00:00Z"
summaries, err = s.acceptanceReviewSummaries(ctx, item)
if err != nil || len(summaries) != 0 {
t.Fatal("future review leaked into snapshot")
}
}