forked from longtao.wu/droboticflow
51 lines
1.6 KiB
Go
51 lines
1.6 KiB
Go
package api
|
|
|
|
import (
|
|
"context"
|
|
"droboticflow/internal/domain"
|
|
"droboticflow/internal/store"
|
|
"testing"
|
|
)
|
|
|
|
type membershipReadProbe struct {
|
|
store.Store
|
|
broad, scoped int
|
|
}
|
|
|
|
func (s *membershipReadProbe) ListProjectMembers(ctx context.Context, org, project string) ([]domain.ProjectMemberRecord, error) {
|
|
s.broad++
|
|
return s.Store.ListProjectMembers(ctx, org, project)
|
|
}
|
|
func (s *membershipReadProbe) ListProjectMembersForUser(ctx context.Context, org, project, user string) ([]domain.ProjectMemberRecord, error) {
|
|
s.scoped++
|
|
return s.Store.ListProjectMembersForUser(ctx, org, project, user)
|
|
}
|
|
func TestAnnotationMembershipReadsOnlyActorAndStillSeesRevocation(t *testing.T) {
|
|
f := newCombinedDraftFixture(t)
|
|
probe := &membershipReadProbe{Store: f.store}
|
|
s := &server{store: probe}
|
|
for _, project := range []string{f.task.ProjectID, ""} {
|
|
roles, e := s.loadAnnotationMembershipsForUser(f.ctx, f.item.OrganizationID, project, f.annotator.ID)
|
|
if e != nil || len(roles) == 0 {
|
|
t.Fatalf("roles=%+v err=%v", roles, e)
|
|
}
|
|
for _, role := range roles {
|
|
if role.UserID != f.annotator.ID {
|
|
t.Fatal("foreign member leaked")
|
|
}
|
|
}
|
|
}
|
|
if probe.broad != 0 || probe.scoped != 2 {
|
|
t.Fatalf("role lookup read entire member lists: broad=%d scoped=%d", probe.broad, probe.scoped)
|
|
}
|
|
user := f.annotator
|
|
user.Status = domain.UserStatusDisabled
|
|
if e := f.store.UpsertUser(f.ctx, user); e != nil {
|
|
t.Fatal(e)
|
|
}
|
|
roles, e := s.loadAnnotationMembershipsForUser(f.ctx, f.item.OrganizationID, f.task.ProjectID, user.ID)
|
|
if e != nil || len(roles) != 0 {
|
|
t.Fatalf("disabled account retained roles: %+v %v", roles, e)
|
|
}
|
|
}
|