forked from longtao.wu/droboticflow
56 lines
2.1 KiB
Go
56 lines
2.1 KiB
Go
package api
|
|
|
|
import (
|
|
"droboticflow/internal/domain"
|
|
"net/http"
|
|
"testing"
|
|
)
|
|
|
|
func TestUserDefaultProjectRolesAreRejected(t *testing.T) {
|
|
f := newCombinedDraftFixture(t)
|
|
r := f.request(http.MethodPut, "/api/users/"+f.annotator.ID, f.admin, map[string]any{"defaultProjectRoles": []string{"annotator", "quality_reviewer"}})
|
|
if r.Code != http.StatusBadRequest {
|
|
t.Fatalf("update: %d %s", r.Code, r.Body.String())
|
|
}
|
|
u, _ := f.store.GetUser(f.ctx, f.annotator.ID)
|
|
if len(u.DefaultProjectRoles) != 0 {
|
|
t.Fatalf("defaults=%v", u.DefaultProjectRoles)
|
|
}
|
|
if validDefaultProjectRoles([]domain.AnnotationAssignmentRole{"admin"}) {
|
|
t.Fatal("admin must not be a default project role")
|
|
}
|
|
r = f.request(http.MethodPut, "/api/users/"+f.annotator.ID, f.admin, map[string]any{"defaultProjectRoles": []string{}})
|
|
if r.Code != http.StatusOK {
|
|
t.Fatalf("clear: %d", r.Code)
|
|
}
|
|
u, _ = f.store.GetUser(f.ctx, f.annotator.ID)
|
|
if len(u.DefaultProjectRoles) != 0 {
|
|
t.Fatal("defaults not cleared")
|
|
}
|
|
}
|
|
|
|
func TestQualityApprovalRejectsOutstandingIssueNotes(t *testing.T) {
|
|
f := newCombinedDraftFixture(t)
|
|
r := f.request(http.MethodPost, "/api/plugins/annotation-qa/tasks/"+f.task.ID+"/reviews", f.reviewer, map[string]any{"stage": "quality", "decision": "approved", "comment": "切片边界错误", "problemSliceIds": []string{"slice-a"}})
|
|
if r.Code != http.StatusBadRequest {
|
|
t.Fatalf("approval: %d %s", r.Code, r.Body.String())
|
|
}
|
|
i, _ := f.store.GetHumanItem(f.ctx, f.item.ID)
|
|
if i.Version != f.item.Version {
|
|
t.Fatal("rejected approval changed task")
|
|
}
|
|
}
|
|
|
|
func TestDefaultProjectRolesDoNotGrantAccessToEmptyProjects(t *testing.T) {
|
|
t.Setenv("DROBOTICFLOW_REQUIRE_SESSION_AUTH", "true")
|
|
f := newCombinedDraftFixture(t)
|
|
p := domain.ProjectRecord{ID: "unassigned-project", OrganizationID: f.task.OrganizationID, Name: "no members"}
|
|
if err := f.store.UpsertProject(f.ctx, p); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
r := f.request(http.MethodGet, "/api/projects/"+p.ID, f.annotator, nil)
|
|
if r.Code != http.StatusForbidden {
|
|
t.Fatalf("empty project access = %d %s", r.Code, r.Body.String())
|
|
}
|
|
}
|