droboticflow/internal/api/review_draft_test.go
d-robotics 74ea7f8274 🛡️ 03: deprecate task-scope review comments (ADR 0009)
Server: reject NEW task-scope problems on draft PUT (409
review_task_scope_deprecated, ID-matched against stored entries;
existing entries round-trip unchanged, full-replace semantics kept);
formal-rejection flattening no longer emits 整体任务 lines or
expands ProblemSliceIDs; rework-baseline reads hide task problems
(read-only narrowing); workforce stats stop counting task scope.

Frontend: remove task from composer scope lists and card cycle;
hide stored task opinions in rework banner/soft reminder/rail,
QC panel groups and history, acceptance source projection, stats
panel rows, frozen-comment displays (stripTaskOpinionLines);
submit/approve gates count visible problems only; stats panel
documents the 2026-10-14 scope switch.

Data untouched: no migration, no deletion, audit trail intact.
2026-10-14 19:02:29 +08:00

208 lines
10 KiB
Go

package api
import (
"droboticflow/internal/domain"
"encoding/json"
"net/http"
"testing"
)
func qualityReviewDraftFixture(t *testing.T) combinedDraftFixture {
t.Helper()
f := reviewSessionFixture(t)
if e := f.store.UpsertSliceRevision(f.ctx, domain.SliceRevisionRecord{ID: "draft-slices", OrganizationID: f.item.OrganizationID, TaskID: f.task.ID, Revision: 1, Segments: []domain.SliceSegment{{ID: "left", Name: "同名切片", Start: 0, End: 5}, {ID: "right", Name: "同名切片", Start: 5, End: 10}}}); e != nil {
t.Fatal(e)
}
if e := f.store.UpsertAnnotationRevision(f.ctx, domain.AnnotationRevisionRecord{ID: "draft-actions", OrganizationID: f.item.OrganizationID, TaskID: f.task.ID, Revision: 1, Segments: []domain.AnnotationSegment{{ID: "left-action", Start: 0, End: 5, Description: "左段动作"}, {ID: "right-action", Start: 5, End: 10, Description: "右段动作"}}}); e != nil {
t.Fatal(e)
}
return f
}
func openReviewDraftSession(t *testing.T, f combinedDraftFixture) (string, map[string]string) {
t.Helper()
w := f.request(http.MethodPost, "/api/human-items/"+f.item.ID+"/review-session", f.reviewer, map[string]any{"action": "takeover", "pageId": "draft-page"})
if w.Code != 200 {
t.Fatalf("session %d %s", w.Code, w.Body.String())
}
var s struct {
ResultVersion string `json:"resultVersion"`
Generation json.Number `json:"generation"`
}
json.Unmarshal(w.Body.Bytes(), &s)
return s.ResultVersion, map[string]string{"X-Review-Page": "draft-page", "X-Review-Generation": string(s.Generation)}
}
func TestQualityReviewDraftPersistsAndDoesNotDecide(t *testing.T) {
f := qualityReviewDraftFixture(t)
resultVersion, headers := openReviewDraftSession(t, f)
endpoint := "/api/human-items/" + f.item.ID + "/review-draft"
payload := map[string]any{"version": 0, "resultVersion": resultVersion, "operationId": "save-one", "problems": []map[string]any{{"id": "problem-left", "scope": "action", "sliceId": "left", "actionId": "left-action", "text": "核对左段起点", "atSeconds": 1}, {"id": "problem-right", "scope": "slice", "sliceId": "right", "text": "右段名称不符"}, {"id": "problem-mid", "scope": "slice", "sliceId": "left", "text": "左段分类存疑", "atSeconds": 2}}}
first := reviewSessionRequest(f, http.MethodPut, endpoint, f.reviewer, payload, headers)
if first.Code != 200 {
t.Fatalf("save %d %s", first.Code, first.Body.String())
}
var saved struct {
Draft struct {
Version int `json:"version"`
Problems []struct {
ID, Text, SliceID, ActionID string
Start, End float64
} `json:"problems"`
} `json:"draft"`
}
json.Unmarshal(first.Body.Bytes(), &saved)
if saved.Draft.Version != 1 || len(saved.Draft.Problems) != 3 || saved.Draft.Problems[0].SliceID != "left" || saved.Draft.Problems[0].Start != 0 || saved.Draft.Problems[0].End != 5 {
t.Fatalf("canonical result: %s", first.Body.String())
}
read := f.request(http.MethodGet, endpoint, f.reviewer, nil)
if read.Code != 200 {
t.Fatalf("read %d %s", read.Code, read.Body.String())
}
var recovered any
var original any
json.Unmarshal(read.Body.Bytes(), &recovered)
json.Unmarshal(first.Body.Bytes(), &original)
if string(read.Body.Bytes()) != string(first.Body.Bytes()) {
t.Fatalf("saved draft did not recover: %s", read.Body.String())
}
retry := reviewSessionRequest(f, http.MethodPut, endpoint, f.reviewer, payload, headers)
if retry.Code != 200 {
t.Fatalf("retry %d %s", retry.Code, retry.Body.String())
}
stale := map[string]any{"version": 0, "resultVersion": resultVersion, "operationId": "stale-save", "problems": []any{}}
conflict := reviewSessionRequest(f, http.MethodPut, endpoint, f.reviewer, stale, headers)
if conflict.Code != 409 {
t.Fatalf("stale save %d %s", conflict.Code, conflict.Body.String())
}
taskRead := f.request(http.MethodGet, "/api/plugins/annotation-qa/tasks/"+f.task.ID, f.reviewer, nil)
var detail struct {
Task domain.AnnotationTaskRecord `json:"task"`
Reviews []domain.AnnotationReviewRecord `json:"reviews"`
}
json.Unmarshal(taskRead.Body.Bytes(), &detail)
if detail.Task.CurrentRevision != 1 || detail.Task.Status != domain.AnnotationTaskStatusPendingQuality || len(detail.Reviews) != 0 {
t.Fatalf("save changed result or decided: %s", taskRead.Body.String())
}
stale["version"] = 1
stale["operationId"] = "clear"
cleared := reviewSessionRequest(f, http.MethodPut, endpoint, f.reviewer, stale, headers)
if cleared.Code != 200 {
t.Fatalf("clear %d %s", cleared.Code, cleared.Body.String())
}
}
func TestQualityReviewDraftRejectsWrongTargetsAndChangedContext(t *testing.T) {
f := qualityReviewDraftFixture(t)
resultVersion, headers := openReviewDraftSession(t, f)
endpoint := "/api/human-items/" + f.item.ID + "/review-draft"
payload := map[string]any{"version": 0, "resultVersion": resultVersion, "operationId": "bad-target", "problems": []map[string]any{{"id": "wrong", "scope": "action", "sliceId": "right", "actionId": "left-action", "text": "不能串到同名右片"}}}
wrong := reviewSessionRequest(f, http.MethodPut, endpoint, f.reviewer, payload, headers)
if wrong.Code != 400 {
t.Fatalf("cross-slice target accepted %d %s", wrong.Code, wrong.Body.String())
}
denied := reviewSessionRequest(f, http.MethodPut, endpoint, f.annotator, payload, headers)
if denied.Code != 403 && denied.Code != 409 {
t.Fatalf("another account accepted %d %s", denied.Code, denied.Body.String())
}
payload["operationId"] = "valid-after-failure"
payload["problems"] = []map[string]any{{"id": "correct", "scope": "action", "sliceId": "left", "actionId": "left-action", "text": "检查左片"}}
valid := reviewSessionRequest(f, http.MethodPut, endpoint, f.reviewer, payload, headers)
if valid.Code != 200 {
t.Fatalf("failed write stranded session %d %s", valid.Code, valid.Body.String())
}
payload["version"] = 1
payload["operationId"] = "old-round"
f.item.ReviewRound++
if e := f.store.UpsertHumanItem(f.ctx, f.item); e != nil {
t.Fatal(e)
}
changed := reviewSessionRequest(f, http.MethodPut, endpoint, f.reviewer, payload, headers)
if changed.Code != 409 {
t.Fatalf("old round accepted %d %s", changed.Code, changed.Body.String())
}
current := f.request(http.MethodGet, endpoint, f.reviewer, nil)
var state struct {
Draft struct {
Version int `json:"version"`
Problems []domain.ReviewProblem `json:"problems"`
} `json:"draft"`
}
json.Unmarshal(current.Body.Bytes(), &state)
if current.Code != 200 || state.Draft.Version != 0 || len(state.Draft.Problems) != 0 {
t.Fatalf("old round draft leaked %d %s", current.Code, current.Body.String())
}
}
func acceptanceReviewDraftFixture(t *testing.T) combinedDraftFixture {
t.Helper()
f := qualityReviewDraftFixture(t)
f.reviewer.Role = domain.UserRoleAcceptanceReviewer
if e := f.store.UpsertUser(f.ctx, f.reviewer); e != nil {
t.Fatal(e)
}
if e := f.store.UpsertProjectMember(f.ctx, domain.ProjectMemberRecord{ID: "member-" + f.reviewer.ID, OrganizationID: f.item.OrganizationID, ProjectID: f.item.ProjectID, UserID: f.reviewer.ID, SupplierID: f.reviewer.SupplierID, Roles: domain.AccountProductionRoles(f.reviewer)}); e != nil {
t.Fatal(e)
}
batch, e := f.store.GetHumanBatch(f.ctx, f.item.BatchID)
if e != nil {
t.Fatal(e)
}
batch.Stages = []domain.HumanStageDefinition{{ID: "prepackage_acceptance", Kind: domain.HumanStageAcceptance, RequiredRole: "acceptance_reviewer"}}
if e := f.store.UpsertHumanBatch(f.ctx, *batch); e != nil {
t.Fatal(e)
}
f.item.CurrentStageID = "prepackage_acceptance"
f.item.LegacyTaskID = ""
entries := []any{}
for _, source := range []string{"source-a", "source-b"} {
entries = append(entries, map[string]any{"sourceHumanItemId": source, "taskId": "task-" + source, "materialization": map[string]any{"artifactId": "artifact-" + source, "revision": 1}, "finalSlices": []domain.SliceSegment{{ID: "same", Name: "同名切片", Start: 10, End: 15}}, "annotation": []domain.AnnotationSegment{{ID: "same-action", Start: 10, End: 15, Description: "一样的动作"}}})
}
f.item.Subject.Payload = map[string]any{"items": entries}
if e := f.store.UpsertHumanItem(f.ctx, f.item); e != nil {
t.Fatal(e)
}
return f
}
func TestAcceptanceReviewDraftSeparatesSameNameSourceMembers(t *testing.T) {
f := acceptanceReviewDraftFixture(t)
version, headers := openReviewDraftSession(t, f)
endpoint := "/api/human-items/" + f.item.ID + "/review-draft"
problems := []map[string]any{}
for _, source := range []string{"source-a", "source-b"} {
problems = append(problems, map[string]any{"id": "problem-" + source, "scope": "action", "sourceItemId": source, "sliceId": "same", "actionId": "same-action", "atSeconds": 1, "text": "核对 " + source})
}
payload := map[string]any{"version": 0, "resultVersion": version, "operationId": "aggregate-save", "problems": problems}
saved := reviewSessionRequest(f, http.MethodPut, endpoint, f.reviewer, payload, headers)
if saved.Code != 200 {
t.Fatalf("aggregate save %d %s", saved.Code, saved.Body.String())
}
read := f.request(http.MethodGet, endpoint, f.reviewer, nil)
var state struct {
Draft domain.ReviewDraft `json:"draft"`
}
json.Unmarshal(read.Body.Bytes(), &state)
if read.Code != 200 || len(state.Draft.Problems) != 2 || state.Draft.Problems[0].SourceItemID == state.Draft.Problems[1].SourceItemID || state.Draft.Problems[0].Start != 0 || state.Draft.Problems[0].End != 5 || state.Draft.Problems[0].TimeBasis != "slice-seconds" {
t.Fatalf("sources aliased: %s", read.Body.String())
}
problems[0]["sourceItemId"] = "outsider"
payload["version"] = 1
payload["operationId"] = "bad-source"
denied := reviewSessionRequest(f, http.MethodPut, endpoint, f.reviewer, payload, headers)
if denied.Code != 400 {
t.Fatalf("foreign source accepted %d %s", denied.Code, denied.Body.String())
}
entries := f.item.Subject.Payload["items"].([]any)
entries[0].(map[string]any)["materialization"] = map[string]any{"artifactId": "new-artifact", "revision": 2}
if e := f.store.UpsertHumanItem(f.ctx, f.item); e != nil {
t.Fatal(e)
}
changed := reviewSessionRequest(f, http.MethodPut, endpoint, f.reviewer, payload, headers)
if changed.Code != 409 {
t.Fatalf("changed aggregate accepted %d %s", changed.Code, changed.Body.String())
}
fresh := f.request(http.MethodGet, endpoint, f.reviewer, nil)
json.Unmarshal(fresh.Body.Bytes(), &state)
if fresh.Code != 200 || state.Draft.Version != 0 || len(state.Draft.Problems) != 0 {
t.Fatalf("stale aggregate draft loaded: %s", fresh.Body.String())
}
}