forked from longtao.wu/droboticflow
98 lines
3.1 KiB
Go
98 lines
3.1 KiB
Go
package api
|
|
|
|
import (
|
|
"context"
|
|
"droboticflow/internal/domain"
|
|
"droboticflow/internal/store"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
)
|
|
|
|
type reviewReadCounter struct {
|
|
store.Store
|
|
batches, members, linked int
|
|
}
|
|
|
|
func (s *reviewReadCounter) GetHumanBatch(ctx context.Context, id string) (*domain.HumanBatchRecord, error) {
|
|
s.batches++
|
|
return s.Store.GetHumanBatch(ctx, id)
|
|
}
|
|
func (s *reviewReadCounter) ListProjectMembers(ctx context.Context, org, project string) ([]domain.ProjectMemberRecord, error) {
|
|
s.members++
|
|
return s.Store.ListProjectMembers(ctx, org, project)
|
|
}
|
|
func (s *reviewReadCounter) ListHumanItems(ctx context.Context, org string, q domain.HumanItemQuery) ([]domain.HumanItemRecord, error) {
|
|
if q.LegacyTaskID != "" {
|
|
s.linked++
|
|
}
|
|
return s.Store.ListHumanItems(ctx, org, q)
|
|
}
|
|
|
|
// Real list handlers with distinct batches reproduce the production N+1 pattern.
|
|
func TestReviewListsBoundRepeatedPermissionReads(t *testing.T) {
|
|
for _, path := range []string{"/api/human-items?pool=available&projectId=", "/api/plugins/annotation-qa/tasks?projectId="} {
|
|
t.Run(path, func(t *testing.T) {
|
|
f := newCombinedDraftFixture(t)
|
|
base, _ := f.store.GetHumanBatch(f.ctx, f.item.BatchID)
|
|
for i := 0; i < 40; i++ {
|
|
batch := *base
|
|
batch.ID = fmt.Sprintf("perf-batch-%d", i)
|
|
if err := f.store.UpsertHumanBatch(f.ctx, batch); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
task := f.task
|
|
task.ID = fmt.Sprintf("perf-task-%d", i)
|
|
if err := f.store.UpsertAnnotationTask(f.ctx, task); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
item := f.item
|
|
item.ID = fmt.Sprintf("perf-item-%d", i)
|
|
item.LegacyTaskID = task.ID
|
|
item.BatchID = batch.ID
|
|
item.CurrentStageID = "quality_review"
|
|
item.AssignedUserID = ""
|
|
item.Status = domain.HumanItemReady
|
|
if err := f.store.UpsertHumanItem(f.ctx, item); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
counter := &reviewReadCounter{Store: f.store}
|
|
f.handler = NewHandler(counter, nil)
|
|
res := f.request(http.MethodGet, path+f.task.ProjectID, f.reviewer, nil)
|
|
if res.Code != 200 {
|
|
t.Fatalf("%d %s", res.Code, res.Body.String())
|
|
}
|
|
if counter.members > 1 || counter.batches > 2 || counter.linked > 0 {
|
|
t.Fatalf("N+1 reads: memberships=%d batches=%d linked=%d", counter.members, counter.batches, counter.linked)
|
|
}
|
|
// Cache must end with the request: revoking membership immediately removes visibility.
|
|
var before struct {
|
|
Items []json.RawMessage `json:"items"`
|
|
}
|
|
if err := json.Unmarshal(res.Body.Bytes(), &before); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(before.Items) == 0 {
|
|
t.Fatal("fixture must expose review work")
|
|
}
|
|
u := f.reviewer
|
|
u.Status = domain.UserStatusDisabled
|
|
if err := f.store.UpsertUser(f.ctx, u); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
res = f.request(http.MethodGet, path+f.task.ProjectID, f.reviewer, nil)
|
|
var after struct {
|
|
Items []json.RawMessage `json:"items"`
|
|
}
|
|
if err := json.Unmarshal(res.Body.Bytes(), &after); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if res.Code != 200 || len(after.Items) != 0 {
|
|
t.Fatalf("stale permission cache: %d %s", res.Code, res.Body.String())
|
|
}
|
|
})
|
|
}
|
|
}
|