droboticflow/internal/api/review_session_test.go

158 lines
6.5 KiB
Go

package api
import (
"bytes"
"context"
"droboticflow/internal/domain"
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
)
func reviewSessionFixture(t *testing.T) combinedDraftFixture {
t.Helper()
f := newCombinedDraftFixture(t)
f.item.CurrentStageID = domain.FanyuV58StageQualityReview
f.item.AssignedUserID = f.reviewer.ID
f.item.CurrentRevision = 1
f.item.ReviewRound = 1
f.task.CurrentRevision = 1
f.task.Status = domain.AnnotationTaskStatusPendingQuality
if e := f.store.UpsertHumanItem(f.ctx, f.item); e != nil {
t.Fatal(e)
}
if e := f.store.UpsertAnnotationTask(f.ctx, f.task); e != nil {
t.Fatal(e)
}
return f
}
func reviewSessionRequest(f combinedDraftFixture, method, target string, user domain.UserRecord, body any, headers map[string]string) *httptest.ResponseRecorder {
encoded, _ := json.Marshal(body)
r := httptest.NewRequest(method, target, bytes.NewReader(encoded))
r.Header.Set("Content-Type", "application/json")
r.AddCookie(&http.Cookie{Name: csrfCookieName, Value: "session-test"})
r.Header.Set(csrfHeaderName, "session-test")
for k, v := range headers {
r.Header.Set(k, v)
}
r = r.WithContext(context.WithValue(r.Context(), authContextKey{}, &authenticatedPrincipal{User: user, Organization: domain.OrganizationRecord{ID: domain.DefaultOrganizationID, Status: domain.OrganizationStatusActive}}))
w := httptest.NewRecorder()
f.handler.ServeHTTP(w, r)
return w
}
func TestReviewSessionExplicitTakeoverAndNoHeaderBypass(t *testing.T) {
f := reviewSessionFixture(t)
endpoint := "/api/human-items/" + f.item.ID + "/review-session"
call := func(action, page string, generation int) *httptest.ResponseRecorder {
return f.request(http.MethodPost, endpoint, f.reviewer, map[string]any{"action": action, "pageId": page, "generation": generation})
}
first := call("acquire", "page-a", 0)
if first.Code != 200 {
t.Fatalf("acquire: %d %s", first.Code, first.Body.String())
}
var initial struct {
Generation int `json:"generation"`
Writable bool `json:"writable"`
ResultVersion string `json:"resultVersion"`
}
json.Unmarshal(first.Body.Bytes(), &initial)
if !initial.Writable || initial.Generation < 1 || initial.ResultVersion == "" {
t.Fatalf("invalid session %s", first.Body.String())
}
second := call("acquire", "page-b", 0)
if second.Code != 200 || !bytes.Contains(second.Body.Bytes(), []byte(`"writable":false`)) {
t.Fatalf("second page should read: %d %s", second.Code, second.Body.String())
}
taken := call("takeover", "page-b", 0)
if taken.Code != 200 || !bytes.Contains(taken.Body.Bytes(), []byte(`"writable":true`)) {
t.Fatalf("takeover: %d %s", taken.Code, taken.Body.String())
}
stale := call("renew", "page-a", initial.Generation)
if stale.Code != 409 {
t.Fatalf("old renewal: %d %s", stale.Code, stale.Body.String())
}
// Neither the legacy route nor the generic decision route can bypass an enrolled session.
for _, target := range []string{"/api/plugins/annotation-qa/tasks/" + f.task.ID + "/reviews", "/api/human-items/" + f.item.ID + "/decisions"} {
for _, headers := range []map[string]string{nil, {"X-Review-Page": "page-a", "X-Review-Generation": "1"}} {
w := reviewSessionRequest(f, http.MethodPost, target, f.reviewer, map[string]any{"version": f.item.Version, "stage": "quality", "decision": "approved"}, headers)
if w.Code != 409 || !bytes.Contains(w.Body.Bytes(), []byte(`review_session_lost`)) {
t.Fatalf("stale bypass %s: %d %s", target, w.Code, w.Body.String())
}
}
}
item := f.request(http.MethodGet, "/api/human-items/"+f.item.ID, f.reviewer, nil)
var out struct {
Item domain.HumanItemRecord `json:"item"`
}
json.Unmarshal(item.Body.Bytes(), &out)
if out.Item.Version != f.item.Version || out.Item.CurrentStageID != f.item.CurrentStageID {
t.Fatalf("lease changed result: %s", item.Body.String())
}
denied := f.request(http.MethodPost, endpoint, f.annotator, map[string]any{"action": "takeover", "pageId": "intruder"})
if denied.Code != 403 && denied.Code != 409 {
t.Fatalf("wrong role %d %s", denied.Code, denied.Body.String())
}
}
func TestReviewSessionVersionPermissionAndStageChanges(t *testing.T) {
for _, stage := range []string{domain.FanyuV58StageQualityReview, "prepackage_acceptance"} {
t.Run(stage, func(t *testing.T) {
f := reviewSessionFixture(t)
if stage == "prepackage_acceptance" {
f.reviewer.Role = domain.UserRoleAcceptanceReviewer
if e := f.store.UpsertUser(f.ctx, f.reviewer); e != nil {
t.Fatal(e)
}
if e := f.store.UpsertProjectMember(f.ctx, domain.ProjectMemberRecord{ID: "member-" + f.reviewer.ID, OrganizationID: f.item.OrganizationID, ProjectID: f.item.ProjectID, UserID: f.reviewer.ID, SupplierID: f.reviewer.SupplierID, Roles: domain.AccountProductionRoles(f.reviewer)}); e != nil {
t.Fatal(e)
}
batch, e := f.store.GetHumanBatch(f.ctx, f.item.BatchID)
if e != nil {
t.Fatal(e)
}
batch.Stages = []domain.HumanStageDefinition{{ID: stage, Kind: domain.HumanStageAcceptance, RequiredRole: "acceptance_reviewer"}}
if e := f.store.UpsertHumanBatch(f.ctx, *batch); e != nil {
t.Fatal(e)
}
f.item.CurrentStageID = stage
if e := f.store.UpsertHumanItem(f.ctx, f.item); e != nil {
t.Fatal(e)
}
}
endpoint := "/api/human-items/" + f.item.ID + "/review-session"
post := func(action string) *httptest.ResponseRecorder {
return f.request(http.MethodPost, endpoint, f.reviewer, map[string]any{"action": action, "pageId": "page-a", "generation": 1})
}
first := post("acquire")
if first.Code != 200 {
t.Fatalf("acquire: %d %s", first.Code, first.Body.String())
}
var before map[string]any
json.Unmarshal(first.Body.Bytes(), &before)
renewed := post("renew")
var after map[string]any
json.Unmarshal(renewed.Body.Bytes(), &after)
if renewed.Code != 200 || before["resultVersion"] != after["resultVersion"] {
t.Fatalf("heartbeat changed reviewed result %s", renewed.Body.String())
}
f.item.Subject.Payload["evidenceVersion"] = "new"
if e := f.store.UpsertHumanItem(f.ctx, f.item); e != nil {
t.Fatal(e)
}
stale := post("renew")
if stale.Code != 409 || !bytes.Contains(stale.Body.Bytes(), []byte("review_context_changed")) {
t.Fatalf("result change accepted: %d %s", stale.Code, stale.Body.String())
}
f.item.AssignedUserID = f.annotator.ID
if e := f.store.UpsertHumanItem(f.ctx, f.item); e != nil {
t.Fatal(e)
}
denied := post("takeover")
if denied.Code != 409 {
t.Fatalf("reassignment accepted: %d %s", denied.Code, denied.Body.String())
}
})
}
}