forked from longtao.wu/droboticflow
149 lines
5.9 KiB
Go
149 lines
5.9 KiB
Go
package api
|
||
|
||
import (
|
||
"context"
|
||
"droboticflow/internal/domain"
|
||
"fmt"
|
||
"strings"
|
||
)
|
||
|
||
// reworkQCNotePrefix 是复审"仍有问题"备注并入原意见文本的前缀(R2-Q7):
|
||
// 标注员侧一条意见 = 原文本 + 追加备注块,条目 ID 不变、基线条目数不多跳。
|
||
const reworkQCNotePrefix = "【质检备注】"
|
||
|
||
// The rejection gate, formal decision and next baseline must use the same
|
||
// effective opinions. Old clients without verdicts conservatively carry prior
|
||
// opinions forward. Deprecated task-scope data stays in frozen audit snapshots;
|
||
// the decision gate and renderers exclude it from visible rejection reasons.
|
||
func (s *server) qualityRejectionOpinions(ctx context.Context, item domain.HumanItemRecord, draft domain.ReviewDraft) ([]domain.ReviewProblem, []domain.ReviewProblem, error) {
|
||
var prior, unlocated []domain.ReviewProblem
|
||
if item.ReviewRound > 0 && item.CurrentStageID == domain.FanyuV58StageQualityReview {
|
||
baseline, err := s.reworkBaselineForRound(ctx, item, item.ReviewRound)
|
||
if err != nil {
|
||
return nil, nil, err
|
||
}
|
||
if baseline != nil {
|
||
baseline, err = s.effectiveAcceptanceBaseline(ctx, item, baseline)
|
||
if err != nil {
|
||
return nil, nil, err
|
||
}
|
||
prior, unlocated = baseline.Problems, baseline.UnlocatedProblems
|
||
}
|
||
}
|
||
known := map[string]bool{}
|
||
for _, p := range prior {
|
||
known[p.ID] = true
|
||
}
|
||
for _, p := range unlocated {
|
||
known[p.ID] = true
|
||
}
|
||
for _, p := range draft.Problems {
|
||
if known[p.ID] {
|
||
return nil, nil, fmt.Errorf("本轮意见身份与原退回意见重复,请刷新后核对")
|
||
}
|
||
}
|
||
return reworkBaselineProblems(prior, draft.Confirmations, draft.Problems), reworkBaselineProblems(unlocated, draft.Confirmations, nil), nil
|
||
}
|
||
|
||
func (s *server) qualityRejectionProblems(ctx context.Context, item domain.HumanItemRecord, draft domain.ReviewDraft) ([]domain.ReviewProblem, error) {
|
||
problems, _, err := s.qualityRejectionOpinions(ctx, item, draft)
|
||
return problems, err
|
||
}
|
||
|
||
// reworkBaselineProblems 构造再退回时的新基线意见集(R1-Q8,ADR 0008):
|
||
//
|
||
// 新基线 = 未解决旧意见(在前,同条目 ID 原样延续) + 本轮新写意见(在后)。
|
||
//
|
||
// - 判"已解决"的旧意见不进新基线:完整轨迹只保留在冻结的旧基线记录与
|
||
// 正式审查记录(AnnotationReviewRecord.Confirmations),界面永不显示;
|
||
// - 判"仍有问题"的旧意见保持同一条目(R2-Q7):备注以
|
||
// "\n【质检备注】…" 并入原文本,多轮判定逐块累积,不产生新条目 ID;
|
||
// - 兜底:没有核对结论的旧意见(旧多轮数据缺失意见状态、或旧客户端未送
|
||
// 核对结论)按"未解决"处理,继续进基线——宁可延续也不丢意见。
|
||
//
|
||
// 输入 confirmations 已由 canonicalReviewConfirmations 校验只引用旧基线意见;
|
||
// 这里对未校验来源(如直接复用)同样安全:未知 ID 的结论自然落空。
|
||
func reworkBaselineProblems(prior []domain.ReviewProblem, confirmations []domain.ReviewConfirmation, fresh []domain.ReviewProblem) []domain.ReviewProblem {
|
||
verdicts := make(map[string]domain.ReviewConfirmation, len(confirmations))
|
||
for _, c := range confirmations {
|
||
verdicts[c.OpinionID] = c
|
||
}
|
||
out := make([]domain.ReviewProblem, 0, len(prior)+len(fresh))
|
||
for _, p := range prior {
|
||
c, confirmed := verdicts[p.ID]
|
||
if confirmed && c.Resolved {
|
||
continue // 已解决:不进新基线(R1-Q8)。
|
||
}
|
||
if confirmed && !c.Resolved {
|
||
if note := strings.TrimSpace(c.Note); note != "" {
|
||
p.Text = p.Text + "\n" + reworkQCNotePrefix + note
|
||
}
|
||
}
|
||
out = append(out, p)
|
||
}
|
||
out = append(out, fresh...)
|
||
return out
|
||
}
|
||
|
||
// resolvedReworkOpinionIDs 汇总"核对过第 N 轮基线"的正式审查记录中判已解决的
|
||
// 意见 ID(ReviewRound == N 的 AnnotationReviewRecord.Confirmations)。没有对应
|
||
// 审查记录、或意见没有核对结论 → 不在集合内 = 未解决(兜底语义,ADR 0008)。
|
||
func resolvedReworkOpinionIDs(reviews []domain.AnnotationReviewRecord, round int) map[string]bool {
|
||
resolved := map[string]bool{}
|
||
for _, review := range reviews {
|
||
if review.ReviewRound != round {
|
||
continue
|
||
}
|
||
for _, c := range review.Confirmations {
|
||
if c.Resolved {
|
||
resolved[strings.TrimSpace(c.OpinionID)] = true
|
||
}
|
||
}
|
||
}
|
||
return resolved
|
||
}
|
||
|
||
// visibleReworkBaselineProblems 是所有基线查询接口的统一收窄视图(R1-Q8:
|
||
// 已解决意见彻底不返回,不折叠;ADR 0009:整体作用域意见一并隐藏)。
|
||
// 冻结记录本身不动,返回新切片。
|
||
func visibleReworkBaselineProblems(baseline *domain.ReworkBaselineRecord, reviews []domain.AnnotationReviewRecord) []domain.ReviewProblem {
|
||
if baseline == nil {
|
||
return nil
|
||
}
|
||
resolved := resolvedReworkOpinionIDs(reviews, baseline.Round)
|
||
out := make([]domain.ReviewProblem, 0, len(baseline.Problems))
|
||
for _, p := range baseline.Problems {
|
||
if p.Scope == "task" || resolved[p.ID] {
|
||
continue
|
||
}
|
||
out = append(out, p)
|
||
}
|
||
return out
|
||
}
|
||
|
||
// visibleReworkBaseline 读取第 round 轮冻结基线并应用 R1-Q8 收窄视图。
|
||
// 消费接口字段不变(只收窄 problems 内容);缺基线返回 nil 原样降级。
|
||
func (s *server) visibleReworkBaseline(ctx context.Context, item domain.HumanItemRecord, round int) (*domain.ReworkBaselineRecord, error) {
|
||
baseline, e := s.reworkBaselineForRound(ctx, item, round)
|
||
if e != nil || baseline == nil {
|
||
return baseline, e
|
||
}
|
||
baseline, e = s.effectiveAcceptanceBaseline(ctx, item, baseline)
|
||
if e != nil {
|
||
return nil, e
|
||
}
|
||
if item.LegacyTaskID == "" {
|
||
// 无审查记录可查时仍应用作用域收窄(ADR 0009),只是没有已解决过滤。
|
||
visible := *baseline
|
||
visible.Problems = visibleReworkBaselineProblems(baseline, nil)
|
||
return &visible, nil
|
||
}
|
||
reviews, e := s.store.ListAnnotationReviews(ctx, item.OrganizationID, item.LegacyTaskID)
|
||
if e != nil {
|
||
return nil, e
|
||
}
|
||
visible := *baseline
|
||
visible.Problems = visibleReworkBaselineProblems(baseline, reviews)
|
||
return &visible, nil
|
||
}
|