forked from longtao.wu/droboticflow
Contract step of the account-phone-login expand-migrate-contract rollout. Phone is now the sole account identifier end to end: - domain.UserRecord/CreateUserInput: delete Email, drop Phone's omitempty (required going forward). - store: delete email_unique Mongo index; phone_unique is now non-sparse (unique, not sparse) since every account creation path requires a phone. Delete FindUserByEmail, ensureUserEmailAvailableLocked, and ErrDuplicateUserEmail (confirmed dead via grep - all real call sites were already migrated to the *Phone equivalents by tickets 01-03). Mongo duplicate-key fallback and the account-mutation-guard's stale-write snapshot/filter now key off Phone instead of Email. - api: drop the now-impossible ErrDuplicateUserEmail branch in renderUserMutationError. The account-hierarchy audit endpoint and the supplier-deletion receipt struct both switch their identifying field from Email to Phone, since both are populated fresh from current account state (not frozen historical snapshots) - continuing to read a "email" key would silently go blank for every account created after this change. - frontend: src/types.ts User.phone is now required (email removed); AccountHierarchyIssue.email -> .phone in services/api/users.ts and pages/Users.tsx to match the backend audit endpoint's renamed field. - Rewrote the wide blast radius of Go test fixtures that constructed users by email across internal/api/*_test.go and internal/store/*_test.go, including the two dedicated memory-store uniqueness tests (merged into phone-only equivalents) and several opt-in "live" acceptance-fixture tests gated behind env vars for real Fanyu deployments. Repo-wide grep of Go and TS/TSX for Email/email/邮箱 turned up no remaining account-identifier references outside of a few harmless test-only cosmetic labels (e.g. "Email Tenant" as an org display name in a seed helper) and assertions that explicitly check "邮箱" text is absent from API responses. go build/vet clean. go test ./internal/api/... ./internal/store/... ./internal/domain/... : 75 failures, identical test names to the pre-ticket-05 baseline (diffed against a throwaway worktree at the prior tip). npm run lint:web (tsc --noEmit) clean. npm run test:frontend: 599/586/13, matching the stated baseline exactly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
60 lines
1.9 KiB
Go
60 lines
1.9 KiB
Go
package store
|
|
|
|
import (
|
|
"droboticflow/internal/domain"
|
|
"errors"
|
|
"fmt"
|
|
"testing"
|
|
)
|
|
|
|
func TestImmutableSupplierPersistence(t *testing.T) {
|
|
ds := NewMemoryStore()
|
|
ctx := t.Context()
|
|
for i, before := range []string{"supplier-a", ""} {
|
|
u := domain.UserRecord{ID: "u" + before, OrganizationID: "org-a", Phone: fmt.Sprintf("139%08d", i), SupplierID: before, Role: domain.UserRoleAnnotator}
|
|
if err := ds.UpsertUser(ctx, u); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
u.SupplierID = "supplier-b"
|
|
if err := ds.UpsertUser(ctx, u); !errors.Is(err, ErrSupplierImmutable) {
|
|
t.Fatalf("ownership changed: %v", err)
|
|
}
|
|
stored, _ := ds.GetUser(ctx, u.ID)
|
|
if stored.SupplierID != before {
|
|
t.Fatal("immutable write altered user")
|
|
}
|
|
m := domain.ProjectMemberRecord{ID: "m" + before, OrganizationID: "org-a", ProjectID: "p", UserID: u.ID, SupplierID: before, Roles: []domain.AnnotationAssignmentRole{domain.AnnotationRoleAnnotator}}
|
|
_ = ds.UpsertProjectMember(ctx, m)
|
|
m.SupplierID = "supplier-b"
|
|
if err := ds.UpsertProjectMember(ctx, m); !errors.Is(err, ErrSupplierImmutable) {
|
|
t.Fatal("member ownership changed")
|
|
}
|
|
fields, err := bsonDocumentWithoutSupplier(u)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, ok := fields["supplierId"]; ok {
|
|
t.Fatal("Mongo update would write ownership")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDefaultSupplierIsIdempotentAndOrganizationLocal(t *testing.T) {
|
|
ds := NewMemoryStore()
|
|
ctx := t.Context()
|
|
a, _ := ds.EnsureDefaultSupplier(ctx, "org-a")
|
|
again, _ := ds.EnsureDefaultSupplier(ctx, "org-a")
|
|
b, _ := ds.EnsureDefaultSupplier(ctx, "org-b")
|
|
if a.ID != again.ID || a.ID == b.ID || !a.IsDefault || a.Status != "active" {
|
|
t.Fatal("default supplier identity")
|
|
}
|
|
all, _ := ds.ListSuppliers(ctx, "org-a")
|
|
if len(all) != 1 {
|
|
t.Fatal("default supplier duplicated or escaped tenant")
|
|
}
|
|
users, _ := ds.ListUsers(ctx)
|
|
if len(users) != 0 {
|
|
t.Fatal("ensuring default supplier modified accounts")
|
|
}
|
|
}
|