* refactor(providers): make server-configured providers admin-managed, not client-overridable
A server-configured provider is now authoritative: the operator owns its API
key and base URL, and the client cannot override either. This collapses the
tri-state (server key / client base URL / client key) that was the root of a
recurring "missing API key" bug class — when the settings UI echoed a base URL
with an empty key, routes that treated "any base URL ⇒ fully client-configured"
dropped the server key. #533 patched that per-route via canUseServerApiKeyForBaseUrl;
this removes the guard entirely by fixing the design.
Server:
- resolve*ApiKey/BaseUrl ignore client values when the provider is server-
configured; add isServerConfiguredProvider(section, id); drop
canUseServerApiKeyForBaseUrl + normalizeProviderBaseUrl.
- getServer*Providers() no longer return base URLs — only allowed models
(LLM/image) and the managed flag (presence) — so an internal gateway/proxy
endpoint is never exposed to the client.
- routes (chat/image/video/tts/asr/pdf + verify-*) resolve managed providers
purely server-side; SSRF validation now applies only to unmanaged (client)
base URLs.
Client:
- drop serverBaseUrl from ProviderSettings, the settings store, request-building
(TTS base URL no longer echoes the server URL) and voice resolution.
- settings UI renders managed providers read-only: the key/base-URL override
inputs and region toggles are hidden, leaving the "managed by server" notice.
Tradeoff: overriding a server provider's key with your own for the same provider
is removed; add a separate custom provider instead. Closes#620.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* chore(providers): refresh managed-provider copy, drop dead audio-settings, add #620 e2e
- serverConfiguredNotice now says the provider is managed and not editable here,
pointing users to add a separate provider for their own credentials (7 locales).
- delete components/settings/audio-settings.tsx — unreferenced dead code.
- add e2e/tests/managed-provider-620.spec.ts: managed provider hides the
key/base-URL inputs; unmanaged provider keeps them.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* feat(providers): lock the model catalog for managed providers with a pinned list
When the operator pins an allowed model list (MODELS env/yaml ⇒ serverModels),
the model catalog is admin-managed too: the LLM provider panel shows the pinned
models read-only with a "Server" badge and no add / reset / edit / delete
affordances. Without a pinned list the server manages only credentials and the
user keeps curating models.
This removes the prior inconsistency where the settings panel let you add models
to a pinned managed provider that the generation toolbar then filtered out.
e2e: the managed-openai case now also asserts the catalog is locked.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(providers): ignore (not reject) client overrides for managed web-search; clear legacy serverBaseUrl
Addresses review feedback on #624:
1. Managed web-search providers now ignore a client-sent key/baseUrl instead of
validating and rejecting it. A server-configured provider is admin-owned, so
the server config is authoritative and a stale client base URL is dropped
rather than 400-ing the request. The allowlist validation still runs for
unmanaged providers, where the client base URL is actually used.
2. Drop the removed `serverBaseUrl` field from persisted localStorage on
rehydrate (settings version 2 -> 3, stripped in both migrate and merge), so
old clients don't keep a stale server URL in client state.
Tests: web-search route test split into unmanaged-rejects-allowlist and
managed-ignores-client-baseUrl; settings rehydrate test asserts a legacy
serverBaseUrl is stripped. Full suite 381 pass; e2e 2 pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: 杨慎 <117187635+cosarah@users.noreply.github.com>
* Fix server API key fallback for provider base URLs
* Format verify PDF provider route
---------
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
- Make validateUrlForSSRF async; resolve hostnames via dns.promises.lookup
with { all: true, verbatim: true } and reject if any address is private
- Add isPrivateIP helper covering IPv4 private ranges, IPv6 loopback/ULA/
link-local, IPv4-mapped IPv6, deprecated fec0::/10 site-local, 6to4
tunnel (2002::/16), and Teredo tunnel (2001:0000::/32)
- Detect IP literals via net.isIP() and validate directly without DNS
- Fail closed on DNS resolution errors
- Propagate async to resolveModel, resolveModelFromHeaders, and all 20+
route-level callers; preserve existing production-only gating
- Add 14 unit tests covering public pass-through, private literals, DNS
rebinding, mixed DNS answers, tunnel addresses, and DNS failure
Closes#378
* fix: fix 3 bugs found during code review
1. formatQuestionsForPrompt called .join() on QuizOption objects,
producing "[object Object]" in AI prompts instead of readable
option text (e.g. "A. Option1, B. Option2").
2. json-repair Fix 1 regex double-escaped valid JSON escapes (\t,
\n, \r, \b, \f) and couldn't handle strings with escaped quotes.
Now uses a proper string-aware regex and preserves valid escapes.
3. PlaybackEngine spotlight/laser actions used synchronous recursion
via processNext(), risking stack overflow with many consecutive
non-speech actions. Now uses queueMicrotask() to break recursion.
https://claude.ai/code/session_01JdigqQtiAvomeifvWSQbjm
* fix: ensure allowedActions whitelist applies to non-slide scenes
The early return in Step 6 (slide-only action filter) caused Step 7
(allowedActions whitelist) to be skipped for non-slide scenes. This
meant hallucinated actions from agents in quiz/interactive/pbl scenes
were not filtered by the role-based allowedActions whitelist.
Refactored to use a mutable result variable instead of early returns
so both filters always apply.
https://claude.ai/code/session_01JdigqQtiAvomeifvWSQbjm
* fix: prevent video playback hang and division by zero in CJK detection
1. executePlayVideo could hang forever if the video element was invalid
or the state change was missed between playVideo() and subscribe().
Added a 5-minute safety timeout to prevent indefinite blocking.
2. CJK language detection in browser TTS divided by chunkText.length
without checking for empty strings, producing NaN. Now guards
against zero-length text.
https://claude.ai/code/session_01JdigqQtiAvomeifvWSQbjm
* fix: prevent ordered entry with invalid index when partial text has no remaining content
When a previously-partial text item completed but all content had
already been streamed as deltas (remaining is empty), the code still
pushed an ordered entry pointing to textChunks.length - 1, which
could be -1 or reference an unrelated chunk. This caused spurious
warnings in director-graph and potential text loss.
Now only pushes the ordered entry when there is actual remaining
content to emit.
https://claude.ai/code/session_01JdigqQtiAvomeifvWSQbjm
* fix: validate quiz points parameter and fix parse-pdf metadata spread order
1. quiz-grade: `points` from request body was used without validation,
causing NaN in score calculation and invalid JSON responses when
points was undefined, negative, or non-numeric. Now validates it
is a positive finite number.
2. parse-pdf: metadata spread order put the default `pageCount` before
`...result.metadata`, so the spread would overwrite the fallback.
Fixed by spreading metadata first, then applying defaults after.
Also changed `||` to `??` so pageCount=0 is preserved correctly.
https://claude.ai/code/session_01JdigqQtiAvomeifvWSQbjm
* fix: crash in moveUpElement, dead-code in video options, wrong parens in canCombine
1. use-order-element.ts: moveUpElement crashed with TypeError when a
grouped element was already at the top of the z-order. The code
accessed copyOfElementList[maxLevel + 1] without bounds checking,
then dereferenced .groupId on undefined. Added early return guard
matching the pattern used in the non-grouped branch.
2. video-providers.ts: normalizeVideoOptions had a dead-code ternary
inside an if-block that already proved the condition was false.
Simplified to directly use the fallback value.
3. use-canvas-operations.ts: canCombine check had incorrect
parenthesization: (el.groupId && el.groupId) === firstGroupId
evaluated the && first, which is equivalent to just el.groupId.
Fixed to: el.groupId && el.groupId === firstGroupId.
https://claude.ai/code/session_01JdigqQtiAvomeifvWSQbjm
* style: fix prettier formatting in 3 files
https://claude.ai/code/session_01JdigqQtiAvomeifvWSQbjm
* fix: use valid ApiErrorCode in quiz-grade route
INVALID_PARAMETER is not a member of API_ERROR_CODES. Use
INVALID_REQUEST instead, which is the appropriate code for
invalid request parameters.
https://claude.ai/code/session_01JdigqQtiAvomeifvWSQbjm
---------
Co-authored-by: Claude <noreply@anthropic.com>
* fix: add structured request context to all API error logs (#323)
Replace generic log.error messages across 23 API routes with structured, context-rich error logs that include provider, model, input summary, and other request parameters for faster incident triage.
- Hoist key request params above try blocks for catch-block access
- Add createLogger imports to routes that lacked logging
- Truncate user-controlled strings (query, requirement) to prevent log flooding
- No behavioral changes — purely observability improvement
Closes#323
* style: run prettier on all API routes
* chore: remove accidental server.log from tracking