* refactor(quiz): extract grading helpers into lib/quiz/grading
* feat(classroom): add summarizeScenes aggregation helper
* feat(i18n): add classroomComplete translations
* feat(classroom): add ClassroomCompletePage component
* feat(stage): render ClassroomCompletePage when course finishes
* feat(stage): show 'Course complete' slot in sidebar
* chore: apply prettier formatting
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(classroom): richer completion visuals — confetti, gold trophy, stats cards
- Replace lucide Trophy with custom gradient SVG (3x larger, base + stem + star)
- Add one-shot confetti burst (55 particles, 7-color palette, no new dep)
- Add looping sparkles + pulsing halo around trophy
- Redesign stats from thin icon row into metric cards with count-up numbers
- Upgrade quiz block to gradient card with animated gold progress ring
- Add gradient ribbon badge above title, bg-clip gradient title
- Sidebar thumbnail: amber gradient + sparkles + larger filled trophy
- Respect prefers-reduced-motion (skips confetti/sparkles/count-up)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(stage): show course-complete title in header; tone down sidebar thumbnail
- Header top-left was showing loading fallback on pending slot; now renders
t('stage.courseComplete') when isCourseComplete && isPendingScene
- Sidebar thumbnail was too saturated next to neutral slide thumbnails; back
to soft amber-50 base with a subtle radial glow, smaller muted sparkles,
and colored amber-500 trophy (no more filled white on gradient)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(classroom): persist submitted quiz answers for completion page
Previously handleSubmit cleared the quizDraft cache, leaving nothing for
the completion page to read — score always showed 0/N. Now submit also
writes to a separate quizAnswers:<sceneId> key that is not cleared by
the normal in-progress draft lifecycle.
- quiz-view: on submit, mirror answers into quizAnswers:<sceneId>
- quiz-view: on retry, remove that persistent key too
- classroom-complete: read quizAnswers first; fall back to quizDraft so
an unsubmitted attempt still shows partial progress rather than 0
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(quiz): persist submitted quiz state across unmounts
Before: remounting a quiz scene after submit restarted it from 'not_started'
because the draft cache was cleared at submit time. Reopening meant redoing
everything.
Now on mount, read quizAnswers:<sceneId> + quizResults:<sceneId> and restore:
- Both present → jump to 'reviewing' with graded answers and feedback
- Only answers (mid-grading unmount) → 'answering' with answers pre-filled
- Neither → fall through to existing draft-restore path
Results are persisted when the grading useEffect transitions to 'reviewing',
and both keys are cleared together by handleRetry.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(home): prevent horizontal shift when recent classrooms expand
Expanding recent classrooms could grow the page past the viewport height,
making a vertical scrollbar appear. Because the scrollbar takes layout
width, the centered header and trigger row jumped horizontally. Reserve
the scrollbar gutter on <html> so the gutter is always present and layout
stays stable across expand/collapse.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(home): force always-visible scrollbar to eliminate expand/collapse shift
scrollbar-gutter: stable alone wasn't enough (browser/config dependent).
Adding overflow-y: scroll on html forces the vertical scrollbar to always
occupy layout width, so expanding recent classrooms past the viewport
no longer shifts the centered trigger row.
Trade-off: home page now always shows a scrollbar track, even when
content fits viewport. Acceptable cost for stable layout.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor(quiz): extract persistence module + sweep localStorage on delete
Addresses code review on #484:
1. New lib/quiz/persistence.ts centralizes the three per-scene localStorage
keys (draft / answers / results) behind readSubmittedState,
readAnswersForSummary, writeSubmittedAnswers, writeSubmittedResults,
clearSubmitted, clearAllForScene. quiz-view and classroom-complete now
both consume this module instead of hand-rolling localStorage calls,
removing the schema-coupling between the two components.
2. deleteStageData now collects scene ids before deletion and sweeps the
matching quiz persistence keys, fixing the storage leak when a
classroom is deleted.
3. ClassroomCompletePage gets role=status / aria-live=polite /
aria-label for screen readers to announce the completion moment.
4. Tests: 11 new unit tests covering the persistence module
(read/write/clear roundtrips, draft fallback, corrupt-JSON
tolerance, scene-isolation).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(classroom): address review on PR #484 (a11y, motion, coupling)
Addresses cosarah's review:
1. prefers-reduced-motion now fully honored — wrap ClassroomCompletePage
in MotionConfig with reducedMotion='always' when the OS preference is
on. This neutralizes the previously-uncovered animations (trophy
float repeat:Infinity, halo pulse repeat:Infinity, page/cards/trophy
entrance fade+scale+spring).
2. Move role='status' off the noisy outer wrapper; replace with a single
sr-only span carrying the title text so screen readers get one clean
announcement instead of every count-up tick. Outer is now a plain
<section aria-label=...>.
3. Wrap ClassroomCompletePageConnected in a motion.div inside
AnimatePresence so leaving the pending slot fades instead of snapping
(matches the loading-overlay branch).
4. quiz-view's draft cache key now uses the draftKey() helper exported
from lib/quiz/persistence so the prefix has one source of truth (no
silent desync if the schema evolves).
5. isCourseComplete now requires scenes.length === outlines.length, so
a partial generation with failed outlines doesn't falsely trigger.
6. aria-hidden on decorative motion wrappers (Confetti, Sparkles,
trophy entrance) for cleaner SR experience.
7. Comment on summarizeScenes useMemo explaining the mount-fresh
assumption.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore: prettier-format review-fix changes
CI's format check (pnpm check) failed because the previous commit's
changes weren't run through prettier locally before push.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: 杨慎 <117187635+cosarah@users.noreply.github.com>
34 lines
1.1 KiB
TypeScript
34 lines
1.1 KiB
TypeScript
import type { Scene, SceneType, QuizContent } from '@/lib/types/stage';
|
|
import { gradeChoiceQuestions } from '@/lib/quiz/grading';
|
|
|
|
export interface CompleteSummary {
|
|
countsByType: Partial<Record<SceneType, number>>;
|
|
quiz: { correct: number; total: number; pct: number } | null;
|
|
}
|
|
|
|
export type AnswerReader = (sceneId: string) => Record<string, string | string[]>;
|
|
|
|
export function summarizeScenes(scenes: Scene[], readAnswers: AnswerReader): CompleteSummary {
|
|
const countsByType: Partial<Record<SceneType, number>> = {};
|
|
for (const scene of scenes) {
|
|
countsByType[scene.type] = (countsByType[scene.type] ?? 0) + 1;
|
|
}
|
|
|
|
let correct = 0;
|
|
let total = 0;
|
|
for (const scene of scenes) {
|
|
if (scene.type !== 'quiz') continue;
|
|
const questions = (scene.content as QuizContent).questions ?? [];
|
|
const answers = readAnswers(scene.id);
|
|
const results = gradeChoiceQuestions(questions, answers);
|
|
for (const r of results) {
|
|
total += 1;
|
|
if (r.correct === true) correct += 1;
|
|
}
|
|
}
|
|
|
|
const quiz = total > 0 ? { correct, total, pct: Math.round((correct / total) * 100) } : null;
|
|
|
|
return { countsByType, quiz };
|
|
}
|