openmaic-custom/packages/@openmaic/editor/test/react/layers/ElementInteractionLayer.test.tsx
xuyuanwei678 c38da84ef6
feat(renderer): decouple editor UI from the app (#1072)
* docs: define renderer editor task 1 integration

* docs: plan renderer editor task 1

* feat: gate renderer slide editor

* feat: adapt renderer editor intents

* feat: connect renderer editor to slide surface

* test: complete renderer intent shape fixture

* fix: restore renderer editor action previews

* fix: render editor alignment guides

* perf: smooth renderer element dragging

* feat: align renderer hidden element behavior

* feat: add renderer canvas host commands

* feat: add renderer canvas context interactions

* test: cover renderer context menu interaction

* fix: preserve renderer canvas interaction semantics

* docs: design renderer text editing

* docs: plan renderer text editing

* feat(renderer): add ProseMirror text core

* feat(renderer): add rich text editor controller

* feat(renderer): render editable text in place

* feat(renderer): enter text editing on click

* feat: connect renderer rich text editing

* feat: finalize renderer text edit lifecycle

* fix: stabilize renderer text edit commits

* fix(renderer): move elements from selected borders

* docs: design renderer editing UI text toolbar

* feat(renderer): publish editing UI contracts

* feat(renderer): add controlled text format toolbar

* style(renderer): format editing UI contracts

* fix(renderer): address Task 2 review findings

* fix(renderer): handle zero font sizes in toolbar

* feat(renderer): add editing UI color picker

* fix(renderer): address Task 3 color picker review

* fix(renderer): commit native color input changes

* fix(renderer): coordinate native color picker interaction

* feat(renderer): anchor text toolbar to canvas elements

* feat(renderer): compose editable canvas with text UI

* feat(editor): use renderer text toolbar UI

* fix(renderer): make editing UI tests type-safe

* fix(renderer): harden editing UI integration

* feat(renderer): add editable text UI

* feat(renderer): add image and shape editing

* feat(editor): extend renderer editing controls

* feat(editor): add renderer chart insertion

* docs: design renderer latex editor

* docs: plan renderer latex editor

* feat(renderer): add latex editor contract

* feat(renderer): add latex editor dialog

* feat(renderer): compose latex insert and edit UI

* feat(editor): integrate renderer latex editing

* fix(editor): consolidate latex toolbar actions

* fix(renderer): show toolbar hover labels

* test(renderer): cover localized latex tooltips

* chore(renderer): hide latex sample palette

* feat(renderer): add video editing controls

* docs: define renderer audio editing

* feat(renderer): render audio elements

* feat(renderer): add audio editing UI

* feat(renderer): add preview audio controls

* feat(editor): add renderer element clipboard

* feat(renderer): decouple editor UI from app

* chore(renderer): release 0.0.6

* fix(renderer): clear editor CI gates

* fix(editor): adapt renderer canvas to media resolution API

* fix(i18n): complete French editor labels

* fix(renderer): hide toolbar vertical overflow

* chore(renderer): address review cleanup

* chore(docs): remove planning artifacts from pr

* feat(editor): add transactional core package

* chore(editor): ignore local test cache

* build(editor): publish core entrypoint

* refactor(editor): route renderer changes through transactions

* refactor(editor): split renderer editing into editor package

* ci(editor): register editor package for release

* docs(editor): document package dependencies

* ci: rerun validation after editor release registration

* test(editor): validate deletion against existing element

* fix(editor): address transaction and package review findings

* fix(editor): validate transactions and restore editor styles

* fix(editor): protect required updates and react styles

* fix(editor): validate required transaction fields

* fix(editor): prevent insert popovers shifting canvas

* refactor(editor): own renderer editing capabilities

* fix(editor): harden editing transaction boundaries

* refactor(editor): modularize editor UI integration

* docs(editor): harden third-party integration

* fix(editor): preserve video resize aspect ratio

* fix(editor): discard text draft before deletion

* fix(editor): preserve renderer picking and line presets

* chore(editor): remove unused pick-layer import
2026-08-10 19:56:24 +08:00

222 lines
6.6 KiB
TypeScript

// @vitest-environment jsdom
import { describe, expect, it, vi } from 'vitest';
import { render } from '@testing-library/react';
import type { PPTElement } from '@openmaic/dsl';
import {
areElementInteractionTargetPropsEqual,
ElementInteractionLayer,
type ElementInteractionTargetProps,
} from '../../../src/react/layers/ElementInteractionLayer';
const element = {
id: 'a',
type: 'text',
left: 10,
top: 20,
width: 200,
height: 80,
rotate: 0,
} as PPTElement;
function makeProps(): ElementInteractionTargetProps {
return {
element,
isSelected: true,
interactive: true,
movable: true,
sourceElements: [element],
selection: { elementIds: ['a'], primaryId: 'a' },
viewportLeft: 0,
viewportTop: 0,
canvasScale: 1,
editingTouchAction: 'none',
onElementPointerDown: vi.fn(),
onSelectionChange: vi.fn(),
};
}
describe('ElementInteractionLayer memoization', () => {
it('reuses an unchanged per-element interaction target', () => {
const props = makeProps();
expect(areElementInteractionTargetPropsEqual(props, props)).toBe(true);
});
it('updates only the target whose element object changed', () => {
const previous = makeProps();
const next = { ...previous, element: { ...element, left: 30 } as PPTElement };
expect(areElementInteractionTargetPropsEqual(previous, next)).toBe(false);
});
});
describe('ElementInteractionLayer context target ids', () => {
it('uses the element body for selection and the selected border for movement', () => {
const { container } = render(
<ElementInteractionLayer
elements={[element]}
sourceElements={[element]}
selection={{ elementIds: ['a'], primaryId: 'a' }}
interactive
movable
viewportLeft={0}
viewportTop={0}
canvasScale={1}
editingTouchAction="none"
onElementPointerDown={vi.fn()}
onSelectionChange={vi.fn()}
/>,
);
const body = container.querySelector('[data-select-element-id="a"]') as HTMLElement;
const border = container.querySelector('[data-element-id="a"]') as SVGElement;
expect(body.style.cursor).toBe('text');
expect(border.style.cursor).toBe('move');
});
it('does not expose a movement target before the element is selected', () => {
const { container } = render(
<ElementInteractionLayer
elements={[element]}
sourceElements={[element]}
selection={{ elementIds: [] }}
interactive
movable
viewportLeft={0}
viewportTop={0}
canvasScale={1}
editingTouchAction="none"
onElementPointerDown={vi.fn()}
onSelectionChange={vi.fn()}
/>,
);
expect(container.querySelector('[data-select-element-id="a"]')).not.toBeNull();
expect(container.querySelector('[data-element-id="a"]')).toBeNull();
});
it('keeps an outer move border for active text editing without exposing an overlapping underlay', () => {
const other = { ...element, id: 'b' } as PPTElement;
const underlay = {
...element,
id: 'underlay',
left: 0,
top: 0,
width: 400,
height: 200,
} as PPTElement;
const { container } = render(
<ElementInteractionLayer
elements={[underlay, element, other]}
sourceElements={[underlay, element, other]}
selection={{ elementIds: ['a'], primaryId: 'a', editingId: 'a' }}
interactive
movable
viewportLeft={0}
viewportTop={0}
canvasScale={1}
editingTouchAction="none"
onElementPointerDown={vi.fn()}
onSelectionChange={vi.fn()}
/>,
);
expect(container.querySelector('[data-select-element-id="a"]')).toBeNull();
expect(container.querySelector('[data-select-element-id="underlay"]')).toBeNull();
expect(container.querySelector('[data-select-element-id="b"]')).not.toBeNull();
expect(container.querySelectorAll('[data-element-id]')).toHaveLength(1);
expect(container.querySelector('[data-element-id="a"]')).not.toBeNull();
expect(container.querySelector('[data-element-id="b"]')).toBeNull();
expect(container.querySelectorAll('[data-move-border="a"]')).toHaveLength(4);
});
it('does not expose an overlapping underlay while editing a Shape label', () => {
const shape = {
id: 'shape',
type: 'shape',
left: 10,
top: 20,
width: 200,
height: 80,
rotate: 0,
viewBox: [200, 80],
path: 'M 0 0 L 200 80',
fill: '#fff',
} as PPTElement;
const underlay = { ...shape, id: 'underlay', left: 0, top: 0, width: 400, height: 200 };
const { container } = render(
<ElementInteractionLayer
elements={[underlay, shape]}
sourceElements={[underlay, shape]}
selection={{ elementIds: ['shape'], primaryId: 'shape', editingId: 'shape' }}
interactive
movable
viewportLeft={0}
viewportTop={0}
canvasScale={1}
editingTouchAction="none"
onElementPointerDown={vi.fn()}
onSelectionChange={vi.fn()}
/>,
);
expect(container.querySelector('[data-select-element-id="underlay"]')).toBeNull();
});
it('marks locked box blockers with their element id', () => {
const locked = { ...element, lock: true } as PPTElement;
const { container } = render(
<ElementInteractionLayer
elements={[locked]}
sourceElements={[locked]}
selection={{ elementIds: [] }}
interactive
movable
viewportLeft={0}
viewportTop={0}
canvasScale={1}
editingTouchAction="none"
onElementPointerDown={vi.fn()}
onSelectionChange={vi.fn()}
/>,
);
expect(
container.querySelector('[data-hit-kind="blocker"]')?.getAttribute('data-context-element-id'),
).toBe('a');
});
it('marks line stroke targets with their element id', () => {
const line = {
id: 'line-1',
type: 'line',
left: 0,
top: 0,
start: [0, 0],
end: [100, 50],
width: 2,
style: 'solid',
color: '#111111',
points: ['', ''],
} as PPTElement;
const { container } = render(
<ElementInteractionLayer
elements={[line]}
sourceElements={[line]}
selection={{ elementIds: [] }}
interactive
movable
viewportLeft={0}
viewportTop={0}
canvasScale={1}
editingTouchAction="none"
onElementPointerDown={vi.fn()}
onSelectionChange={vi.fn()}
/>,
);
expect(
container.querySelector('[data-hit-kind="line"]')?.getAttribute('data-context-element-id'),
).toBe('line-1');
});
});