* fix(interactive): keep-alive iframe pool so interactive scenes don't reload on remount (#619)
Interactive scene iframes reloaded on every remount — Pro mode toggle,
scene switch and back, any PlaybackChromeRoot remount — because the
<iframe srcDoc> was rendered inline in the scene subtree and React's
unmount (or a DOM re-parent) makes the browser drop and re-run the doc.
Persist the iframes in a stable host at the Stage root, outside the
mode-swap/scene subtree, keyed by sceneId:
- lib/store/interactive-iframe-pool: per-scene entries (srcDoc/src, content
hash, tracked rect, visibility), LRU-bounded (CAP=3). Re-mounting with an
unchanged hash keeps the existing content reference, so the iframe is
never re-set; only a content-hash change rebuilds it.
- InteractiveIframeHost: mounted once in Stage, portals one persisted
<iframe> per entry to document.body, positioned over each scene's rect.
Hidden (visibility, never display:none) in edit mode and whenever the
placeholder is gone. Owns the widget-iframe postMessage registration.
- InteractiveRenderer: now a placeholder that registers content, marks the
scene active/visible, reports its rect via a rAF loop, and hides (not
evicts) on unmount.
Mode toggle, back-and-forth scene switching, and re-renders now hit the
cache with zero reload and zero flash. widget-iframe messaging API is
unchanged; no change to the playback engine / SSE / edit-lock.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* test(e2e): interactive iframe keep-alive across Pro toggle + scene switch (#619)
Seeds an interactive scene whose widget holds click-counter state, then drives
the two remount triggers (Pro mode toggle, scene switch and back). A
MutationObserver scoped to the keep-alive iframe's title asserts the element is
never removed or recreated across either trigger, and the in-iframe counter
state is preserved — i.e. zero reload.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(interactive): address review — widget callback timing, fullscreen, content compare, rect gate (#619)
Code-review round-1 fixes for the keep-alive iframe pool:
- PlaybackChromeRoot: resolve the widget postMessage callback lazily at send
time instead of capturing it once at engine construction. The iframe (and its
registration) now lives in the keep-alive host, which registers a commit after
the engine is built — so eager capture got null on a scene's first visit and
silently dropped every widget action.
- InteractiveIframeHost: portal target follows document.fullscreenElement so the
iframe stays inside the presentation-fullscreen subtree (requestFullscreen runs
on the stage, not body) instead of vanishing. Known tradeoff: entering/exiting
fullscreen re-parents the iframe and reloads it once — accepted over an
invisible widget during presentation.
- InteractiveIframeHost: reset the pool when the host unmounts (classroom switch)
so a new classroom doesn't retain the previous one's resident iframes.
- InteractiveIframeHost: only show the iframe once its rect has a real measured
size (width>0 && height>0), avoiding a 0x0 flash at the viewport origin before
first layout.
- pool: drop the djb2 hash; compare srcDoc/src by value (string === is value
equality, so an equal-but-new remount string still hits the keep-alive path).
Removes the hash-collision-skips-rebuild hole and simplifies the store.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(interactive): owner-token visibility so stale cross-fade cleanup can't blank the iframe (#619)
cosarah reproduced: after toggling Edit mode on an interactive scene and
returning to playback, the scene flashed its preserved state then went
permanently blank. Root cause is a visibility race, not a reload — the document
stayed alive. Visibility was keyed only by sceneId, so during Stage's
AnimatePresence mode cross-fade the outgoing PlaybackChromeRoot's placeholder
cleanup (hide) ran after the incoming placeholder had already shown the same
scene, hiding the live iframe.
Give each placeholder mount a visibility-ownership token (useId). The pool
records the owner on claim(); release() only clears visibility when the caller
still owns it, so a stale cleanup no-ops instead of blanking a newer instance.
The host now shows iff entry.owner !== null.
- store: replace visible boolean + show/hide with owner + claim/release.
- interactive-renderer: owner = useId(); claim on mount, release on unmount.
- e2e: after returning from Pro mode, wait out the cross-fade and re-assert the
iframe stays visible with its state (guards the blank-on-return regression).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: 杨慎 <117187635+cosarah@users.noreply.github.com>