droboticflow-new/internal/worker/source_index_package_test.go

96 lines
4.4 KiB
Go

package worker
import (
"droboticflow/internal/domain"
"strings"
"testing"
)
func TestSourceIndexPackageRequiresCompatibleImmutableImageWithoutChangingLegacy(t *testing.T) {
node := domain.WorkflowNode{Data: domain.WorkflowNodeData{OperatorID: "operator-builtin-package", Image: "old-package:approved"}}
inputs := []domain.ExecutionArtifact{{Data: map[string]any{"sourceIndexSchema": "droboticflow.source-slice-index/v1"}}}
t.Setenv("ANNOTATION_SOURCE_PACKAGE_IMAGE", "")
if _, e := sourceIndexPackageImage(node, inputs, "runner"); e == nil {
t.Fatal("old package image accepted new source schema")
}
t.Setenv("ANNOTATION_SOURCE_PACKAGE_IMAGE", "new-package:latest")
if _, e := sourceIndexPackageImage(node, inputs, "runner"); e == nil {
t.Fatal("mutable image accepted")
}
image := "registry.test/package@sha256:" + strings.Repeat("a", 64)
t.Setenv("ANNOTATION_SOURCE_PACKAGE_IMAGE", image)
if got, e := sourceIndexPackageImage(node, inputs, "runner"); e != nil || got != image {
t.Fatal(got, e)
}
if got, e := sourceIndexPackageImage(node, nil, "runner"); e != nil || got != "old-package:approved" {
t.Fatal("legacy workflow image changed", got, e)
}
}
func TestV4PhysicalPackageRequiresExistingImmutableOverride(t *testing.T) {
node := domain.WorkflowNode{Data: domain.WorkflowNodeData{
OperatorID: "operator-builtin-package",
Image: "registry.test/package@sha256:" + strings.Repeat("d", 64),
Hyperparams: []domain.HyperParam{{Key: "DELIVERY_JSON_V4", Value: "true"}},
}}
physical := []domain.ExecutionArtifact{{Data: map[string]any{"schemaVersion": "physical-revision"}}}
for _, override := range []string{"", "registry.test/package:latest", "registry.test/package@sha256:short"} {
t.Run("reject-"+override, func(t *testing.T) {
t.Setenv("ANNOTATION_SOURCE_PACKAGE_IMAGE", override)
if got, err := sourceIndexPackageImage(node, physical, "runner"); err == nil || got != "" {
t.Fatalf("v4 physical input fell back to old workflow image: image=%q err=%v", got, err)
}
})
}
strict := "registry.test/package@sha256:" + strings.Repeat("e", 64)
t.Setenv("ANNOTATION_SOURCE_PACKAGE_IMAGE", strict)
for _, enabled := range []string{"true", "1", "yes", "on", " TRUE "} {
node.Data.Hyperparams[0].Value = enabled
if got, err := sourceIndexPackageImage(node, physical, "runner"); err != nil || got != strict {
t.Fatalf("v4=%q: image=%q err=%v", enabled, got, err)
}
}
}
func TestPackageProtocolsPreservePhysicalFallbackAndSourceIndexOverride(t *testing.T) {
strict := "registry.test/package@sha256:" + strings.Repeat("f", 64)
for _, protocol := range []string{"v1", "v2", "v3", "v4"} {
t.Run(protocol, func(t *testing.T) {
node := domain.WorkflowNode{Data: domain.WorkflowNodeData{OperatorID: "operator-builtin-package", Image: "old-package:approved"}}
if protocol != "v1" {
flag := map[string]string{"v2": "SOURCE_INDEX_DELIVERY", "v3": "DELIVERY_JSON_V3", "v4": "DELIVERY_JSON_V4"}[protocol]
node.Data.Hyperparams = []domain.HyperParam{{Key: flag, Value: "true"}}
}
source := []domain.ExecutionArtifact{{Data: map[string]any{"sourceIndexSchema": "droboticflow.source-slice-index/v1"}}}
t.Setenv("ANNOTATION_SOURCE_PACKAGE_IMAGE", strict)
if got, err := sourceIndexPackageImage(node, source, "runner"); err != nil || got != strict {
t.Fatalf("source-index override changed: image=%q err=%v", got, err)
}
expected := "old-package:approved"
if protocol == "v4" {
expected = strict
}
if got, err := sourceIndexPackageImage(node, nil, "runner"); err != nil || got != expected {
t.Fatalf("physical selection: image=%q err=%v", got, err)
}
t.Setenv("ANNOTATION_SOURCE_PACKAGE_IMAGE", "")
if _, err := sourceIndexPackageImage(node, source, "runner"); err == nil {
t.Fatal("source-index input accepted missing override")
}
if protocol != "v4" {
if got, err := sourceIndexPackageImage(node, nil, "runner"); err != nil || got != "old-package:approved" {
t.Fatalf("legacy physical input now requires override: image=%q err=%v", got, err)
}
}
})
}
}
func TestV4ImageOverrideDoesNotAffectOtherOperators(t *testing.T) {
t.Setenv("ANNOTATION_SOURCE_PACKAGE_IMAGE", "")
node := domain.WorkflowNode{Data: domain.WorkflowNodeData{OperatorID: "other-operator", Image: "other:approved", Hyperparams: []domain.HyperParam{{Key: "DELIVERY_JSON_V4", Value: "true"}}}}
if got, err := sourceIndexPackageImage(node, nil, "runner"); err != nil || got != "other:approved" {
t.Fatal(got, err)
}
}