✨ Complete focused review workspaces and resilient review flow #15

Merged
longtao.wu merged 23 commits from feature/local-dev-toolkit into dev 2026-09-23 11:27:19 +08:00
Collaborator

Problem

Quality review and final acceptance now need a dependable focused workspace for reviewing dense annotations. The previous revision added problem drafts and automatic continuation, but the final workflow still needed stable captions, non-blocking draft editing, explicit entry boundaries, and complete browser evidence.

What changed

  • Added independent F-based review problems with stable IDs, same-target multiple notes, recall versus edit separation, deletion confirmation, Esc cancellation, serial writes, late-response reconciliation, and whole-task view anchors.
  • Removed raw-record JSON from the reviewer view and standardized invalid captions to 无效片段.
  • Added focused review entry for quality and acceptance with left/right/dual-camera layouts, centered per-camera captions, ordinary-layout controls, minimum-window pause behavior, explicit manual recovery, stale-intent cancellation, and no auto-start on refresh, preview, or layout changes.
  • Preserved review-session ownership, takeover, permission, evidence, revision, formal-decision, and duplicate-submit safeguards.
  • Added the browser workflow, caption geometry, latency, session, decision, and entry regression coverage plus the Chinese user guide and validation report.

Validation

  • TypeScript and production build pass.
  • Review browser matrix: quality and acceptance × ordinary/focused pass for problem creation, multiple notes, editing, deletion, Esc, unsaved viewing, delayed writes, anchors, captions, and decision confirmation.
  • Automatic entry browser suite passes 10 quality and 5 acceptance scenarios using real local API claims/continues; controlled empty-queue transport edge is explicitly labeled in the test.
  • Ordinary HTTP takeover/session checks pass for both roles; old-page and missing-header writes are rejected with 409.
  • Full frontend: 609 total, 596 passed, 13 existing baseline failures, no new failures.
  • Tracked Go packages: 107 existing baseline leaf failures, no new failure family or build failure.

One recovery-only decision script remains a known local-fixture limitation: its selected item was already submitted and correctly returned 409 quality_review_already_submitted; the duplicate-decision gate was not weakened. No company deployment or customer data was changed.

## Problem Quality review and final acceptance now need a dependable focused workspace for reviewing dense annotations. The previous revision added problem drafts and automatic continuation, but the final workflow still needed stable captions, non-blocking draft editing, explicit entry boundaries, and complete browser evidence. ## What changed - Added independent F-based review problems with stable IDs, same-target multiple notes, recall versus edit separation, deletion confirmation, Esc cancellation, serial writes, late-response reconciliation, and whole-task view anchors. - Removed raw-record JSON from the reviewer view and standardized invalid captions to `无效片段`. - Added focused review entry for quality and acceptance with left/right/dual-camera layouts, centered per-camera captions, ordinary-layout controls, minimum-window pause behavior, explicit manual recovery, stale-intent cancellation, and no auto-start on refresh, preview, or layout changes. - Preserved review-session ownership, takeover, permission, evidence, revision, formal-decision, and duplicate-submit safeguards. - Added the browser workflow, caption geometry, latency, session, decision, and entry regression coverage plus the Chinese user guide and validation report. ## Validation - TypeScript and production build pass. - Review browser matrix: quality and acceptance × ordinary/focused pass for problem creation, multiple notes, editing, deletion, Esc, unsaved viewing, delayed writes, anchors, captions, and decision confirmation. - Automatic entry browser suite passes 10 quality and 5 acceptance scenarios using real local API claims/continues; controlled empty-queue transport edge is explicitly labeled in the test. - Ordinary HTTP takeover/session checks pass for both roles; old-page and missing-header writes are rejected with 409. - Full frontend: 609 total, 596 passed, 13 existing baseline failures, no new failures. - Tracked Go packages: 107 existing baseline leaf failures, no new failure family or build failure. One recovery-only decision script remains a known local-fixture limitation: its selected item was already submitted and correctly returned `409 quality_review_already_submitted`; the duplicate-decision gate was not weakened. No company deployment or customer data was changed.
zhanghongming added 20 commits 2026-09-23 07:16:22 +08:00
Drop the uniqueness-by-target rejection in canonicalReviewProblems so the
same action/slice/task can carry several problems identified by their own
IDs. Duplicate problem IDs, canonical evidence spans, permission, version
and operation idempotency handling stay unchanged, and input order remains
the persisted order.

Add public-handler regressions for quality and aggregate acceptance draft
saves: same-target multiple entries, edit/delete of a single entry,
duplicate-ID rejection and idempotent operation replay.
- Drop the 原始记录 JSON details block from ReviewCaptionDetails; the
  current-frame annotation full text and evidence error hints remain
- reviewCaptionAtTime no longer exposes the original record channel and
  renders invalid segments as 无效片段, keeping discarded and blank
  business states distinct
- Remove now-unused caption summary/pre styles and update the frontend
  and browser caption tests to the new contract
Introduce an optional viewAnchor viewing bookmark on ReviewProblem
(sourceItemId?, sliceId, atSeconds, timeBasis) persisted via JSON/BSON.
The anchor recalls the recorded picture, including for task-scope
problems whose target semantics stay global zeros, and never acts as a
problem target or decision gate input.

canonicalReviewProblems validates the anchor against the same current
reviewed evidence (aggregate source identity included), allows discarded
slices as bookmarks, rejects nonfinite time and unknown bases, converts
between capture-seconds and slice-seconds to the evidence's canonical
basis, and clamps out-of-window time like existing record validation.
Legacy problems without an anchor stay valid with no invented frame.

Cover with quality/acceptance public-handler tests for anchor
persistence, source isolation, invalid-anchor rejection, legacy saves
and idempotent replay, plus a canonicalization unit test for nonfinite
time and discarded-slice anchors.
Ticket 03 rule 10: a one-shot entry intent is armed only by explicit claim/continue actions and consumed exactly once after the write lease and task context are ready. Pauses latch the intent, scope mismatches always clear it, unrelated selections prune it, and lagging detail of a previous task can neither consume nor drop a fresh intent. Legacy-protocol tasks stay manual-only. Ordinary layout gains the same compact continuation status and pause/continue control as the focused heading; the acceptance card separates header preview from footer continue.
Reviewer follow-ups for ticket 03 rule 10: the 1413x615 bottom line now gates ordinary quality/acceptance layouts too (annotation pages unchanged), so an undersized window pauses the queue and blocks auto-entry until a manual continue. The ordinary compact status + pause/continue stay visible whenever the queue was engaged in this page lifetime, even with no editable item open (waiting after the last decision retired it). Explicit 返回任务池/返回我的任务 returns pause the queue in ordinary layout as the focused heading already did; layout display toggles still never pause or restart.
Reviewer-confirmed edge: in the ordinary layout an explicit claim/continue with an already undersized window marked an intent that the dimension-keyed pause effect never latched, so enlarging the window would auto-start without a manual continue. A fresh intent is now latched immediately whenever the review window is undersized; recovery stays manual (rule 10).
zhanghongming added 1 commit 2026-09-23 09:51:40 +08:00
zhanghongming added 1 commit 2026-09-23 10:39:49 +08:00
zhanghongming added 1 commit 2026-09-23 10:57:12 +08:00
Owner

LGTM

LGTM
longtao.wu merged commit 27b3f74e82 into dev 2026-09-23 11:27:19 +08:00
Sign in to join this conversation.
No Reviewers
No Label
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: longtao.wu/droboticflow#15
No description provided.