feat: 返工与复审工作流 + 自动保存(A/B 块全量) #44
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "feature/bigupdate-1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
关键行为变更(有意):质检退回定向归还原标注员(回退开关
FANYU_REWORK_RETURN=pool恢复公共池);时间点意见/核对结论编辑需新前端(旧后端拒收防静默丢失)。Evidence
After: 五角色复现栈全链路演示(退回→反馈→再提交→复审核对→通过,D7 确认冻结进 Review 记录);时间点 60.05s 存取/排他末帧拒绝/汇总带点位标签;50 人压测 350/350 PUT 全 200(p50 65ms/p99 1.1s/零慢查询)。
Merge Danger
Door: two-way
回退=回滚旧镜像(无迁移/无配置变更/新增字段全 optional,兼容性结论见 B05 Answer §4);行为开关可现场切回公共池。
Blast Radius: 标注/质检/终审三角色工作台与领取路由
返工定向归还改变领取分布(开关可回退);旧镜像可继续读写既有数据;时间点意见编辑需新前端。
- ReworkBaselineRecord: frozen at formal quality rejection via a new decision effect (idempotent apply); embeds original opinions, reject comment, and the reviewed revision's slice/action summaries - self-contained by design so revision pruning can never orphan it and no customer data is deleted - ReworkFeedbackRecord + GET/PUT /api/human-items/{id}/rework-feedback: writer restricted to the directed owner (incl. admin-reassigned owner) or manager; entries must reference baseline opinions; CAS version conflicts; readable by the reviewer; missing-baseline rounds return a graceful conflict - GET /rework-baseline returns null baseline for legacy rounds (degraded read, never blocks the flow) - ReviewDraft.Confirmations (D7): canonical validation against the current round's baseline (unknown/duplicate opinions rejected; unresolved requires note or a current-round opinion; no-baseline rounds must stay empty); frozen into AnnotationReviewRecord at the formal decision, matching the irreversible-verdict principle - tests: baseline freeze+embedded evidence, feedback contract (403/400/CAS/ reviewer-read), confirmation validation+freeze, graceful-missing - all green; internal/api failures identical to baseline (65), zero new- GET /api/human-items/{id}/source-opinions: per-source projection of rework baselines (round, frozen problems incl. timestamps, comment) and formal quality reviews (round, decision, reviewer, frozen D7 confirmations); aggregate items only - multi-source coordination detail: requireAcceptanceSourceReady and the decision gate now name the pending sources (itemKey + stage + status) instead of a generic message - AcceptanceSourceOpinions panel in the final-acceptance workspace: collapsible per-source history labelled who/which-round - rework_review badge extends to prepackage_acceptance rounds - tests: pending-gate names source then approves after ready; projection carries baselines/reviews/confirmations and rejects non-aggregate items; api failures identical to baseline (65), frontend zero new, tsc clean@zhanghongming 审查基线:dev=03db2a28,PR head=21127800。结论:发现阻断问题,暂缓合入 dev。
Standards
Spec
P1 同时违反自动保存规格 D2 的“不静默覆盖”和返工规格 §8 对“迟到响应”的验证要求。已用本 PR 实际 hook 加最小隔离 harness 复现:延迟 A 响应,在 B 上下文接收后得到 {task:B,humanItem:item-A};并非仅凭推测报告。
验证边界:后续整合候选的 TypeScript、25 项相关前端测试及 API/store/worker 定向测试通过,但现有测试没有覆盖上述切任务竞态。本次没有部署或修改客户数据。两项问题仍存在于 #45,不能通过合并后续 PR 绕过。
@zhanghongming 本轮再次检查:当前 head 仍为 21127800,dev 为 03db2a28;上一轮评论后没有新增修复提交或回复。仍暂缓合并。
请先修复已报告的两项问题:
这两项也被 #45 继承,需同步到后续功能分支。Git 显示可合并仅说明没有文本冲突,不代表问题已修复。本次无代码增量,未重复运行上一轮测试,也未合入 dev 或部署。
@zhanghongming 10月17日复核:本 PR head 仍为21127800,原阻断修复未回到此分支,因此不单独合入 dev。新的整合 PR #49 已包含本 PR,并保留自动保存会话隔离及物化清理公平推进修复;这两项在整合版本的代码层已确认。#49 仍有返工处理状态写权限问题,已用真实 HTTP handler 隔离复现并评论(#49 / issuecomment-24040)。#50 已合入 #49 的功能分支,合并提交10b0dddd。后续建议在整合分支补齐权限修复后统一重审,不通过先合旧 PR 绕过阻断。本次保留本 PR 开放,不自动关闭或合并。
@zhanghongming 本 PR 的21127800已是 dev=1aad4029 的祖先,全部功能及后续修复已通过 #52 整合进入主线。原自动保存跨任务响应和清理公平性问题在整合版本中已修正,返工处理权限也由 #53 补齐并通过本轮15场景回归。此PR按“已由 #52 覆盖”关闭,不重复合并旧状态,源分支保留。本次只完成代码整合与PR收尾,不表示新增上线或完整生产验收。
Pull request closed