feat: 切片编辑 UX 全量 + 最终验收六缺陷修复(批0-2 收口 + acceptance-fixes) #45
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "codex/inplace-slice-editing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Evidence
After: 前端
node --test798/784/14、Gogo test ./...70 失败名集均与基线逐名一致(新增测试全绿);线上已部署 daccd8df(发布记录 fanyu-20261014-sliceux-accfix-amd64,8/8 证据);真实客户 item 验收深链(领取→会话→意见保存落库→释放)线上实测通过;59 个线上 JS 分包修复特征串全命中Merge Danger
Door: two-way
镜像回退即回滚(发布记录已绑定 rollback digest 896c2c1c…);无迁移/无 schema/无配置变更。
Blast Radius: 全标注/质检/验收工作台(三角色 UI + 决策服务端),任务池计数与验收判定路径。
- ReworkBaselineRecord: frozen at formal quality rejection via a new decision effect (idempotent apply); embeds original opinions, reject comment, and the reviewed revision's slice/action summaries - self-contained by design so revision pruning can never orphan it and no customer data is deleted - ReworkFeedbackRecord + GET/PUT /api/human-items/{id}/rework-feedback: writer restricted to the directed owner (incl. admin-reassigned owner) or manager; entries must reference baseline opinions; CAS version conflicts; readable by the reviewer; missing-baseline rounds return a graceful conflict - GET /rework-baseline returns null baseline for legacy rounds (degraded read, never blocks the flow) - ReviewDraft.Confirmations (D7): canonical validation against the current round's baseline (unknown/duplicate opinions rejected; unresolved requires note or a current-round opinion; no-baseline rounds must stay empty); frozen into AnnotationReviewRecord at the formal decision, matching the irreversible-verdict principle - tests: baseline freeze+embedded evidence, feedback contract (403/400/CAS/ reviewer-read), confirmation validation+freeze, graceful-missing - all green; internal/api failures identical to baseline (65), zero new- GET /api/human-items/{id}/source-opinions: per-source projection of rework baselines (round, frozen problems incl. timestamps, comment) and formal quality reviews (round, decision, reviewer, frozen D7 confirmations); aggregate items only - multi-source coordination detail: requireAcceptanceSourceReady and the decision gate now name the pending sources (itemKey + stage + status) instead of a generic message - AcceptanceSourceOpinions panel in the final-acceptance workspace: collapsible per-source history labelled who/which-round - rework_review badge extends to prepackage_acceptance rounds - tests: pending-gate names source then approves after ready; projection carries baselines/reviews/confirmations and rejects non-aggregate items; api failures identical to baseline (65), frontend zero new, tsc clean- delete ReworkFeedback concept (editor, domain, API, store) per user decision - add /rework-handling API: one-click skip ('no change') with CAS + trace for re-review - add rework-emphasis pure lib: baseline-vs-workspace diff auto-clears red, merge reattach, multi-round (latest red, older dimmed), J/K jump order - workbench: red slice blocks + count badges, red/gray action blocks, red timestamp markers, per-slice opinion cards, summary strip above track, soft submit gate, help entries, one-line notice pointer - QC ripple: skipped chips replace feedback read in ReviewProblemPanel - docs: CONTEXT.md glossary (意见处理状态), ADR 0006, manual rewrite@zhanghongming 本次按 #44 的
21127800→ 本 PR 原 head7b299abe审查增量,并检查与 dev=03db2a28 的整合结果。#48 已独立审查并合入本功能分支(5be3e79f);结论仍是暂缓本 PR 合入 dev。Standards
继承 #44 两项未修复问题:跨任务自动保存迟到响应污染(P1,已离线复现)及物化清理固定前三任务导致后续任务无法推进(P2)。本 PR 的 useAnnotationAutosave.ts 没有补任务/用户代次隔离;原 head 的 AnnotationOperations.tsx:2707-2721 仍仅比较版本号就更新当前 detail 与基线。详见 #44 本轮审查评论。
Spec
[P2] internal/api/rework_handling.go:69-74 的写权限只判断 item.AssignedUserID,没有限制标注角色、返工阶段及当前轮次。重新送检后质检员领取同一 item,即可满足这个写条件,改写 skippedOpinionIds;?round= 还允许选历史轮次。ADR 0006 §3 把该状态定义为标注员一键“不改了”,复审侧显示“标注员标记不改”,因此复审员不能通过当前领取身份改写这份记录。请限制 PUT 为当前返工阶段的合法标注归属人及当前轮次,历史读取保持只读;补质检阶段写入/历史轮写入拒绝回归。此项目前是代码路径核实,独立接口复现另行补充。
ADR 0006/0008 已明确调整反馈编辑器和已解决意见展示,这些有依据的变更不作为缺陷。
本轮验证:隔离整合树 tsc 通过,相关前端 25/25、API/store/worker 定向测试通过。全量前端门禁的 devboot 测试超过 22 分钟未结束,已终止该测试;不能宣称全量通过,也不将此次中止当成已证实的产品回归。Gitea CI 仍等待运行。没有执行公司部署或客户数据写操作。
@zhanghongming 按最新合并请求再次复核:当前 head 仍为 5be3e79f,目标 dev 仍为 03db2a28;相较上一轮审查没有新增修复提交,#48 已包含在本分支。
合并结论保持暂缓,请逐项修复并补回归:
本次仅复核远端提交和既有评论,没有新代码可供增量测试;上一轮测试结果不等于上述问题已经修复。更新提交后再按新 head 审查合并。
@zhanghongming 10月17日复核:本 PR head 仍为5be3e79f,没有新增修复,不单独合入 dev。整合 PR #49 已完整包含本 PR,并补上自动保存会话隔离及清理公平推进;本 PR 曾报告的 rework-handling 权限缺口在整合版本仍存在,现已通过实际 HTTP handler 复现质检员写当前轮及历史轮均返回200,详见 #49 本轮评论。#50 的独立增量已审查并合入整合功能分支(10b0dddd),不是合入 dev。请在整合分支限制返工处理 PUT 的角色、阶段、当前轮次并补拒绝回归;通过后再统一审查整合 PR。本次保留 #45 开放,不自动关闭或合并。
@zhanghongming 本 PR 的5be3e79f已通过 #52 完整进入 dev=1aad4029,Git祖先关系已确认。自动保存隔离、清理公平推进及返工处理写权限的后续修复也已整合;#53 的15项权限边界、本轮相关回归已通过。按“已由整合PR覆盖”关闭本重复入口,不再单独合并旧版本,源分支保留。#56/#57 的新问题在各自PR跟进,不影响本次已通过范围;没有新增部署或客户数据操作。
Pull request closed