17 KiB
Raw Permalink Blame History

SDD ledger — plan: local-data/verification/annotation-workspace-layout/annotation-workspace-layout-plan.md

Implementation baseline: ee2e355b. Current branch: feature/local-dev-toolkit. Full final review compares this baseline to final HEAD.

Ruling: Implement the eight newly published workspace-layout tickets, not repeat the eleven completed keyboard tickets — the user referenced the previous count while asking to execute the current tickets — if wrong, a separately scoped additional task may be needed.

Ruling: Work in the current clean feature checkout — the explicitly invoked implement skill requires commits on the current branch and this checkout owns the local verification stack — if wrong, later isolation would require moving local commits.

Ruling: Use ee2e355b as the final code-review fixed point — it is the recorded implementation-start HEAD immediately after all eight tickets were published — if wrong, a broader historical review would need a different baseline.

Preflight: individual tickets

Task Internal consistency
1 Published behavior, dependency and browser/API acceptance agree; no source-string tests required.
2 Published behavior, dependency and browser/API acceptance agree; no source-string tests required.
3 Published behavior, dependency and browser/API acceptance agree; no source-string tests required.
4 Published behavior, dependency and browser/API acceptance agree; no source-string tests required.
5 Published behavior, dependency and browser/API acceptance agree; no source-string tests required.
6 Published behavior, dependency and browser/API acceptance agree; no source-string tests required.
7 Published behavior, dependency and browser/API acceptance agree; no source-string tests required.
8 Published behavior, dependency and browser/API acceptance agree; no source-string tests required.

Preflight: shared surfaces

Pair Producer / consumer and finding
1 / 2 Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found.
1 / 3 Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found.
1 / 4 Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found.
1 / 5 Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found.
1 / 6 Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found.
1 / 7 Task 1 supplies focused/legacy presentation identity and stable session boundary; later layout changes must not remount editing state. No conflicting requirement found.
1 / 8 Task 1 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found.
2 / 3 Task 2 establishes shared video/timeline/editor regions; later changes consume this stable geometry without replacing media/session state. No conflicting requirement found.
2 / 4 Task 2 establishes shared video/timeline/editor regions; later changes consume this stable geometry without replacing media/session state. No conflicting requirement found.
2 / 5 Task 2 establishes shared video/timeline/editor regions; later changes consume this stable geometry without replacing media/session state. No conflicting requirement found.
2 / 6 Task 2 establishes shared video/timeline/editor regions; later changes consume this stable geometry without replacing media/session state. No conflicting requirement found.
2 / 7 Task 2 establishes shared video/timeline/editor regions; later changes consume this stable geometry without replacing media/session state. No conflicting requirement found.
2 / 8 Task 2 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found.
3 / 4 Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found.
3 / 5 Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found.
3 / 6 Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found.
3 / 7 Viewport suspension wraps existing play/continuation boundaries independently of panel contents; delayed results must still reconcile. No conflicting requirement found.
3 / 8 Task 3 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found.
4 / 5 Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found.
4 / 6 Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found.
4 / 7 Viewport suspension wraps existing play/continuation boundaries independently of panel contents; delayed results must still reconcile. No conflicting requirement found.
4 / 8 Task 4 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found.
5 / 6 Existing task/session state and presentation identity remain shared; execute sequentially and retain prior task regressions. No conflicting requirement found.
5 / 7 Viewport suspension wraps existing play/continuation boundaries independently of panel contents; delayed results must still reconcile. No conflicting requirement found.
5 / 8 Task 5 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found.
6 / 7 Viewport suspension wraps existing play/continuation boundaries independently of panel contents; delayed results must still reconcile. No conflicting requirement found.
6 / 8 Task 6 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found.
7 / 8 Task 7 produces behavior and evidence; task 8 consumes it for full workflow verification, not deferred implementation. No conflicting requirement found.

Tasks

  • Task 1: complete; base ee2e355b, implementation a5753731, fix6acc5803. /root/review_workspace_01 approved scoped re-review. Browser/API+44 focused tests+typecheck/build pass.
  • Task 2: complete; base304fbca5, heada3c780e8; /root/review_workspace_02 approved. Five-sizebrowser52tests/typecheck/buildpass; generationversion5 four slices412s. Reviewer actualerror-control hit-testpass; Minor durableassertion to08. Fixturepool01ownedslice.
  • Task 3: complete; base9fae45f4, heade462437a; /root/review_workspace_03 approved. Browser5size/N/N/drafts/save409/history/cancel+56tests/type/buildpass. Realannotate-delayedquality_reviewv6 independentlyread. Minor CSSactionrowduplicate970vs882/887 tofinalcleanup.
  • Task 4: complete; base2c242df5, implementation94b238d5, fixe95adca8; /root/review_workspace_04 re-review approved. Manybrowser/tinyordinal/crossscopehistory/frozenpointer/API +shell56tests/type/buildpass. Finalmanyannov47,slicev1.
  • Task 5: complete; base64397225 impl1de1d85b fix6c76e5d2; /root/review_workspace_05 re-reviewapproved. Inline/longtext+47tests/type/buildpass; focusfixrealbrowserbothdict+typepass. Primaryv61; nativeOSIMEunverifiedlimit.
  • Task 6: complete; base db5e6d23 impl ee3d6b16 fix af7df833; /root/review_workspace_06 approved. Corrected real minimum dual410.54x334/single531x432,0occlusion; hidden camera recovery preservesframe/nodes/prefs;79tests/type/build/browserpass.
  • Task 7: complete; base39bed0fc, implcb74444e, fix972721e. /root/review_workspace_07 scoped re-review approved; actual browser/API,35tests,type/build pass; owned lookup race fixed with real RED/GREEN.
  • Task 8: complete; basec0d344bf, impl89c9e168, fixab89c63a. /root/review_workspace_08 scoped re-review approved. Exactfinalrunner full3taskchain exit0,12zoom,5size,error/dict/reviewercases,54tests/type/build pass within documented limits.

Final gates

  • Full tests: complete with documented baseline failures; full-suite-results.md
  • Standards review: a313b22a reviewed; map violation fixed b83e810e and scoped review approved;3 advisory smells deferred with reasons/costs.
  • Spec review: /root/workspace_final_spec no actionable findings, documented coverage limits retained.
  • Final report/manual: delivered; task reports,finalreviews,ledger archived under docs/verification/annotation-workspace-layout.

Task 1 fix round 1: reviewer requests behavioral stop-after-current preservation across toggles; /root/workspace_01 assigned scoped test addition. Controller independently verified baseline tag54a35afa and complete bundle (git bundle verify okay).

Ruling: Keep proportional timeline entries within each bounded four-item page and provide exact ordinal search/selection — the spec requires bounded accessible navigation, while existing duration/drag mapping must remain meaningful — if wrong, equal-width list cards would need an additional presentation surface; tiny entries must still be selectable through search and editable in the fixed editor.

Task 4 fix round 1: /root/review_workspace_04 found twoImportant: destination scope resets crossslice history target; pageedge drag clamp/rescale drift. /root/workspace_04 assigned reproduce/fix/browserregression before nextticket.

Task 4 fix round 1 delivered e95adca8, re-review /root/review_workspace_04. Both actualbrowserREDs reproduced; crossscope nulleditorpage4 and frozenpointerbothdirections/samexstable pass; sharedframepublicAPI persistence verified. manyannov47, slicev1. Existing56tests/type/build/shell+five-size pass.

Task 5 fix round 1: reviewer reproduced Tabfromdictpager tooutsideUndo followedEsc leavesdictopen andglobalkeysblocked. /root/workspace_05 assigned focusedfix+bothdict outsidefocus browserregression.

Task5fixround1 delivered6c76e5d2, /root/review_workspace_05 scopedre-review. BothdictTab/outsideclick→EscSpace noPOST/draftloss/geometrychange; selectiontextfocusretained; typecheckpass.

Native OS IME supplemental attempt: separate headed Edge draft-only window prepared; cua.getApp tool blocked for an abnormally long time and returned unrelated existing browser window. No native typing/input-source changes were performed. Own runner stopped; its browser had already closed. No native IME pass claimed. Avoid further desktop tool calls for this attempt.

Task6 fixround1: reviewer identifies inspection progress overlay atvideo bottom and original camera flags trapping hidden camera on return focused. /root/workspace_06 assigned reproduce/fix, realpicture occlusion checks and successful screenshots.

Task6 fixround1 delivered af7df833, scopedreview /root/review_workspace_06. Corrected single531x432 with reserved28px progress and0occlusion; nonzero frame6 original hide-left/right recovery retains nodes/draft/prefs/sync;79tests/type/build/browserpass. Rootviewed successfulleft/right screenshots. Browser zoom readiness independently proven in isolated persistent Edge profile via actual setDefaultZoom; see ignored zoom-readiness.md. No user browser profile modified.

Final verification started for unchanged backend surfaces: full Go source packages, Python in .venv, Rust offline. Logs and exit codes in local-data/verification/annotation-workspace-layout/final-checks. Sessions Go60933/Python48131/Rust84597. Frontend suite awaits Task07 product completion. Additional create-once local fixtures: workspace-viewport-unknown (two unowned ready slices), workspace-viewport-generation (owned slice-primary), workspace-full-workflow (owned slice-primary plus two ready pool tasks, reserved for Task08). No previous task/evidence reset.

Root final backend checks completed: Go13 packages pass/2 no tests/60 existing API failures exact name set; Python648pass25fail3skip, no new failures vs prior25 (old json_to_csv cache failures absent); Rust25tests/lint/release pass; Go builds/script syntax pass; Go formatting existing single-file debt; K8s client discovery localhost8080 blocked,22 local YAML structures pass. Full-suite-status.md and final-checks comparison JSON retain evidence. Backup tag and complete bundle reverified successfully.

Task07 implemented cb74444e; review package39bed0fc..cb74444e dispatched /root/review_workspace_07. Root visually checked actual1100×600 pause prompt, screenshot root-pause-visual.png; no task writes. Full frontend initial578/568/10:9baseline plusobsolete dictionary portal source assertion, assigned08 behavioral verification/retirement. Fullformat53warnings:Layout.tsx only touchedwarning, assigned08 formatting;52untoucheddebt.

Task07 fix round1 dispatched /root/workspace_07: /root/review_workspace_07 actual browser RED delayed owned-pool GET switches completed annotate-primary to owned pool-01 while viewport suspended (no writes). Root agrees Important: owned lookup is not an allocated claim; defer opening next owned task until explicit Continue, retaining handoff intent. Existing in-flight actual claim reconciliation unchanged. Reviewer final report pending.

Task07 fix1 delivered972721e; scoped re-review /root/review_workspace_07. Real pool and summary delays independently RED→GREEN, both continuous/resume-only;0writes/claims,versions3/2 unchanged. Prior viewport suite/type/build pass after fix.

Task08 runtime assistance: fresh workspace-full-workflow2 created after runner seek-timing consumed initial fixtures; prior generated/submitted effects retained. Added two new local reviewer users with correct global quality_reviewer / acceptance_reviewer roles and copied12project memberships each, since snapshot fanyu-full-qc/acceptance are globally annotators. New ignored qc-reviewer-auth.json / acceptance-reviewer-auth.json mode0600; existing users/tasks untouched. Original QA/acceptance login200 but route redirects; opsadmin single known-password login401, no password changes.

Task08 implementation89c9e168, review /root/review_workspace_08. Important committed test-runner cleanup error independently confirmed: wrong annotate assertion before mutation, loop closed early and out-of-scope names. Fixround1 /root/workspace_08; fresh full-workflow4 prepared for runtimeRED(no writes,verifyv1) then finalcandidate completeGREEN. Earlier authoritative3-task evidence retained, never reset. Root archive initial20reports prepared; refresh after fixes/reviews.

Task08 fix1 runtime investigation: finalcandidate runner hash a20779d7c1187106f1f01e441574094bc19bc507964e82f9a78f5b8a14fa9f56; committedRED on fresh4 beforewrites verifiedv1. Generation later interrupted despite unchangedproductsource. Actual controlled Markdown append/restore each emitted ViteWSfull-reload→pagehide/navigation→explicitrecovery,0POST; rootonlydocwrites caused interference. API99553/Vite97816 unchanged, no restart. Coordinated ALL-file-write freeze; freshfull-workflow5 exactcandidate complete exit0,3generate/3save/3handoff/2successclaims/1empty, primaryv8 pools v9QA. Freeze ended afterexit; previousfull4v4 preserved. Fixcommit/report pending.

Ruling: Defer shared browser reachability-helper extraction — current independent acceptance runners passed and extraction would broaden final test changes without a product defect — if wrong, duplicated helpers may drift and need coordinated future updates. Ruling: Defer centralized four-entry pagination policy — both current consumers agree on the accepted fixed page size, with actual cross-page evidence — if wrong, a future page-size change could miss a consumer until refactoring. Ruling: Defer shared viewport-size predicate extraction — all current checks match and fresh dispatch-time reads protect races; no behavior defect was found — if wrong, a future minimum-size change could diverge until the checks are centralized. Final whole-feature fixed HEADa313b22a, Standards1docviolation+3lowheuristics,Spec0. /root/workspace_final_docs_fix assigned sole documented violation.

Final root APIreadback: full-workflow5 primaryv8, pool02/pool01v9, allquality_review/ready. FinalSpec0,Standardsdocviolationclosed+3nonblockingadvisories. Localfeaturebranch preserved; no push/deploy/merge. Plan execution complete.